Re: [PATCH] :Staging :Wlan-ng Fixed coding style issues
On Sun, Sep 16, 2018 at 01:23:26AM -0300, Pablo Pellecchia wrote: > Fixed coding style issues on wlan-ng directory. > > Changes include: > - Parenthesis alignment > - Wrong casting issues > - Adding comments > - Lines ending with '(' > > Signed-off-by: Pablo Pellecchia > --- > drivers/staging/wlan-ng/cfg80211.c | 40 > +--- > drivers/staging/wlan-ng/hfa384x.h| 5 +++-- > drivers/staging/wlan-ng/p80211conv.c | 2 +- > drivers/staging/wlan-ng/prism2mgmt.c | 28 - > 4 files changed, 37 insertions(+), 38 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
Re: [PATCH] :Staging :Wlan-ng Fixed coding style issues
On Sun, Sep 16, 2018 at 01:23:26AM -0300, Pablo Pellecchia wrote: > Fixed coding style issues on wlan-ng directory. > > Changes include: > - Parenthesis alignment > - Wrong casting issues > - Adding comments > - Lines ending with '(' > > Signed-off-by: Pablo Pellecchia > --- > drivers/staging/wlan-ng/cfg80211.c | 40 > +--- > drivers/staging/wlan-ng/hfa384x.h| 5 +++-- > drivers/staging/wlan-ng/p80211conv.c | 2 +- > drivers/staging/wlan-ng/prism2mgmt.c | 28 - > 4 files changed, 37 insertions(+), 38 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
[PATCH] :Staging :Wlan-ng Fixed coding style issues
Fixed coding style issues on wlan-ng directory. Changes include: - Parenthesis alignment - Wrong casting issues - Adding comments - Lines ending with '(' Signed-off-by: Pablo Pellecchia --- drivers/staging/wlan-ng/cfg80211.c | 40 +--- drivers/staging/wlan-ng/hfa384x.h| 5 +++-- drivers/staging/wlan-ng/p80211conv.c | 2 +- drivers/staging/wlan-ng/prism2mgmt.c | 28 - 4 files changed, 37 insertions(+), 38 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index d4cf09b11e33..38bf555a8d3e 100644 --- a/drivers/staging/wlan-ng/cfg80211.c +++ b/drivers/staging/wlan-ng/cfg80211.c @@ -234,8 +234,8 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev, int result = 0; result = prism2_domibset_uint32(wlandev, - DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, - key_index); + DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, + key_index); if (result) err = -EFAULT; @@ -331,8 +331,8 @@ static int prism2_scan(struct wiphy *wiphy, (i < request->n_channels) && i < ARRAY_SIZE(prism2_channels); i++) msg1.channellist.data.data[i] = - ieee80211_frequency_to_channel( - request->channels[i]->center_freq); + ieee80211_frequency_to_channel + (request->channels[i]->center_freq); msg1.channellist.data.len = request->n_channels; msg1.maxchanneltime.data = 250; @@ -366,17 +366,16 @@ static int prism2_scan(struct wiphy *wiphy, freq = ieee80211_channel_to_frequency(msg2.dschannel.data, NL80211_BAND_2GHZ); bss = cfg80211_inform_bss(wiphy, - ieee80211_get_channel(wiphy, freq), - CFG80211_BSS_FTYPE_UNKNOWN, - (const u8 *), - msg2.timestamp.data, msg2.capinfo.data, - msg2.beaconperiod.data, - ie_buf, - ie_len, - (msg2.signal.data - 65536) * 100, /* Conversion to signed type */ - GFP_KERNEL - ); - + ieee80211_get_channel(wiphy, freq), + CFG80211_BSS_FTYPE_UNKNOWN, + (const u8 *), + msg2.timestamp.data, msg2.capinfo.data, + msg2.beaconperiod.data, + ie_buf, + ie_len, + (msg2.signal.data - 65536) * 100, /* Conversion to signed type */ + GFP_KERNEL + ); if (!bss) { err = -ENOMEM; goto exit; @@ -482,14 +481,13 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, } result = prism2_domibset_uint32(wlandev, - DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, - sme->key_idx); + DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, + sme->key_idx); if (result) goto exit; /* send key to driver */ - did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key( - sme->key_idx + 1); + did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(sme->key_idx + 1); result = prism2_domibset_pstr32(wlandev, did, sme->key_len, (u8 *)sme->key); @@ -595,8 +593,8 @@ static int prism2_set_tx_power(struct wiphy *wiphy, struct wireless_dev *wdev, data = MBM_TO_DBM(mbm); result = prism2_domibset_uint32(wlandev, - DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel, - data); + DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel, + data); if (result) { err = -EFAULT; diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 992ebaa1071f..f2ea389c870b 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++
[PATCH] :Staging :Wlan-ng Fixed coding style issues
Fixed coding style issues on wlan-ng directory. Changes include: - Parenthesis alignment - Wrong casting issues - Adding comments - Lines ending with '(' Signed-off-by: Pablo Pellecchia --- drivers/staging/wlan-ng/cfg80211.c | 40 +--- drivers/staging/wlan-ng/hfa384x.h| 5 +++-- drivers/staging/wlan-ng/p80211conv.c | 2 +- drivers/staging/wlan-ng/prism2mgmt.c | 28 - 4 files changed, 37 insertions(+), 38 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index d4cf09b11e33..38bf555a8d3e 100644 --- a/drivers/staging/wlan-ng/cfg80211.c +++ b/drivers/staging/wlan-ng/cfg80211.c @@ -234,8 +234,8 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev, int result = 0; result = prism2_domibset_uint32(wlandev, - DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, - key_index); + DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, + key_index); if (result) err = -EFAULT; @@ -331,8 +331,8 @@ static int prism2_scan(struct wiphy *wiphy, (i < request->n_channels) && i < ARRAY_SIZE(prism2_channels); i++) msg1.channellist.data.data[i] = - ieee80211_frequency_to_channel( - request->channels[i]->center_freq); + ieee80211_frequency_to_channel + (request->channels[i]->center_freq); msg1.channellist.data.len = request->n_channels; msg1.maxchanneltime.data = 250; @@ -366,17 +366,16 @@ static int prism2_scan(struct wiphy *wiphy, freq = ieee80211_channel_to_frequency(msg2.dschannel.data, NL80211_BAND_2GHZ); bss = cfg80211_inform_bss(wiphy, - ieee80211_get_channel(wiphy, freq), - CFG80211_BSS_FTYPE_UNKNOWN, - (const u8 *), - msg2.timestamp.data, msg2.capinfo.data, - msg2.beaconperiod.data, - ie_buf, - ie_len, - (msg2.signal.data - 65536) * 100, /* Conversion to signed type */ - GFP_KERNEL - ); - + ieee80211_get_channel(wiphy, freq), + CFG80211_BSS_FTYPE_UNKNOWN, + (const u8 *), + msg2.timestamp.data, msg2.capinfo.data, + msg2.beaconperiod.data, + ie_buf, + ie_len, + (msg2.signal.data - 65536) * 100, /* Conversion to signed type */ + GFP_KERNEL + ); if (!bss) { err = -ENOMEM; goto exit; @@ -482,14 +481,13 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, } result = prism2_domibset_uint32(wlandev, - DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, - sme->key_idx); + DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID, + sme->key_idx); if (result) goto exit; /* send key to driver */ - did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key( - sme->key_idx + 1); + did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(sme->key_idx + 1); result = prism2_domibset_pstr32(wlandev, did, sme->key_len, (u8 *)sme->key); @@ -595,8 +593,8 @@ static int prism2_set_tx_power(struct wiphy *wiphy, struct wireless_dev *wdev, data = MBM_TO_DBM(mbm); result = prism2_domibset_uint32(wlandev, - DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel, - data); + DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel, + data); if (result) { err = -EFAULT; diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 992ebaa1071f..f2ea389c870b 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++