Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code
On Thursday 03 January 2008 11:39:12 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > It is not really useful to lock machine checks against oopses. And > > machine checks normally don't nest, so they don't need their own > > locking. Just call bust_spinlock/console_verbose directly. > > is this in response to any particular incident you've seen? No, that was a preparatory patch for the "use 64bit machine check code for 32bit kernels" because 32bit doesn't have oops_begin(), but it is useful on its own. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code
* Andi Kleen <[EMAIL PROTECTED]> wrote: > It is not really useful to lock machine checks against oopses. And > machine checks normally don't nest, so they don't need their own > locking. Just call bust_spinlock/console_verbose directly. is this in response to any particular incident you've seen? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code
* Andi Kleen [EMAIL PROTECTED] wrote: It is not really useful to lock machine checks against oopses. And machine checks normally don't nest, so they don't need their own locking. Just call bust_spinlock/console_verbose directly. is this in response to any particular incident you've seen? Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code
On Thursday 03 January 2008 11:39:12 Ingo Molnar wrote: * Andi Kleen [EMAIL PROTECTED] wrote: It is not really useful to lock machine checks against oopses. And machine checks normally don't nest, so they don't need their own locking. Just call bust_spinlock/console_verbose directly. is this in response to any particular incident you've seen? No, that was a preparatory patch for the use 64bit machine check code for 32bit kernels because 32bit doesn't have oops_begin(), but it is useful on its own. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code
It is not really useful to lock machine checks against oopses. And
machine checks normally don't nest, so they don't need their
own locking. Just call bust_spinlock/console_verbose directly.
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mcheck/mce_64.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/arch/x86/kernel/cpu/mcheck/mce_64.c
===
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_64.c
@@ -133,7 +133,8 @@ static void mce_panic(char *msg, struct
{
int i;
- oops_begin();
+ console_verbose();
+ bust_spinlocks(1);
for (i = 0; i < MCE_LOG_LEN; i++) {
unsigned long tsc = mcelog.entry[i].tsc;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code
It is not really useful to lock machine checks against oopses. And
machine checks normally don't nest, so they don't need their
own locking. Just call bust_spinlock/console_verbose directly.
Signed-off-by: Andi Kleen [EMAIL PROTECTED]
---
arch/x86/kernel/cpu/mcheck/mce_64.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/arch/x86/kernel/cpu/mcheck/mce_64.c
===
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_64.c
@@ -133,7 +133,8 @@ static void mce_panic(char *msg, struct
{
int i;
- oops_begin();
+ console_verbose();
+ bust_spinlocks(1);
for (i = 0; i MCE_LOG_LEN; i++) {
unsigned long tsc = mcelog.entry[i].tsc;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
