Re: [PATCH] [net/sched] Remove redundant skb null check

2020-06-20 Thread David Miller 
From: Gaurav Singh 
Date: Fri, 19 Jun 2020 15:24:13 -0400

> Remove the redundant null check for skb.
> 
> Signed-off-by: Gaurav Singh 

Applied to net-next.

[PATCH] [net/sched] Remove redundant skb null check

2020-06-19 Thread Gaurav Singh 
Remove the redundant null check for skb.

Signed-off-by: Gaurav Singh 
---
 net/sched/act_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 8ac7eb0a8309..90be8fe9128c 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -1475,7 +1475,7 @@ static int tc_ctl_action(struct sk_buff *skb, struct 
nlmsghdr *n,
 {
struct net *net = sock_net(skb->sk);
struct nlattr *tca[TCA_ROOT_MAX + 1];
-   u32 portid = skb ? NETLINK_CB(skb).portid : 0;
+   u32 portid = NETLINK_CB(skb).portid;
int ret = 0, ovr = 0;
 
if ((n->nlmsg_type != RTM_GETACTION) &&
-- 
2.17.1