Re: [PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

2008-02-02 Thread Tomas Winkler 
On Feb 2, 2008 9:48 PM, Roel Kluin <[EMAIL PROTECTED]> wrote:
> '!' has a higher priority than '&': bitanding has no effect.
>
> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c 
> b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 569347f..2439868 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> @@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(struct iwl4965_priv 
> *priv,
>
> if (sta_ht_inf) {
> if ((!sta_ht_inf->ht_supported) ||
> -  (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
> +  (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
> return 0;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

ACK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

2008-02-02 Thread Roel Kluin 
'!' has a higher priority than '&': bitanding has no effect.

Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c 
b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 569347f..2439868 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(struct iwl4965_priv 
*priv,
 
if (sta_ht_inf) {
if ((!sta_ht_inf->ht_supported) ||
-  (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
+  (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
return 0;
}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

2008-02-02 Thread Roel Kluin 
'!' has a higher priority than '': bitanding has no effect.

Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c 
b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 569347f..2439868 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(struct iwl4965_priv 
*priv,
 
if (sta_ht_inf) {
if ((!sta_ht_inf-ht_supported) ||
-  (!sta_ht_inf-cap  IEEE80211_HT_CAP_SUP_WIDTH))
+  (!(sta_ht_inf-cap  IEEE80211_HT_CAP_SUP_WIDTH)))
return 0;
}
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

2008-02-02 Thread Tomas Winkler 
On Feb 2, 2008 9:48 PM, Roel Kluin [EMAIL PROTECTED] wrote:
 '!' has a higher priority than '': bitanding has no effect.

 Signed-off-by: Roel Kluin [EMAIL PROTECTED]
 ---
 diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c 
 b/drivers/net/wireless/iwlwifi/iwl-4965.c
 index 569347f..2439868 100644
 --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
 +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
 @@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(struct iwl4965_priv 
 *priv,

 if (sta_ht_inf) {
 if ((!sta_ht_inf-ht_supported) ||
 -  (!sta_ht_inf-cap  IEEE80211_HT_CAP_SUP_WIDTH))
 +  (!(sta_ht_inf-cap  IEEE80211_HT_CAP_SUP_WIDTH)))
 return 0;
 }

 -
 To unsubscribe from this list: send the line unsubscribe linux-wireless in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html


ACK
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/