Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

[Evgeniy Polyakov]

Hi Ingo

Sorry for late reply and because of forcing you to resend the patch, your 
changes are correct

01.05.2018, 17:10, "Ingo Flaschberger" :
> 1wire family module autoload fails because of upper/lower
>   case mismatch.
>
> Signed-off-by: Ingo Flaschberger 

Greg, please pull this patch into your tree.
Should it be stable material?

Acked-by: Evgeniy Polyakov 

> ---
>   drivers/w1/w1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index ab0931e..aa458f2 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev,
> struct w1_reg_num *rn)
>
>  /* slave modules need to be loaded in a context with unlocked
> mutex */
>  mutex_unlock(>mutex);
> -   request_module("w1-family-0x%02x", rn->family);
> +   request_module("w1-family-0x%02X", rn->family);
>  mutex_lock(>mutex);
>
>  spin_lock(_flock);
> --
> 2.7.4

Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

[Evgeniy Polyakov]

Hi Ingo

Sorry for late reply and because of forcing you to resend the patch, your 
changes are correct

01.05.2018, 17:10, "Ingo Flaschberger" :
> 1wire family module autoload fails because of upper/lower
>   case mismatch.
>
> Signed-off-by: Ingo Flaschberger 

Greg, please pull this patch into your tree.
Should it be stable material?

Acked-by: Evgeniy Polyakov 

> ---
>   drivers/w1/w1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index ab0931e..aa458f2 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev,
> struct w1_reg_num *rn)
>
>  /* slave modules need to be loaded in a context with unlocked
> mutex */
>  mutex_unlock(>mutex);
> -   request_module("w1-family-0x%02x", rn->family);
> +   request_module("w1-family-0x%02X", rn->family);
>  mutex_lock(>mutex);
>
>  spin_lock(_flock);
> --
> 2.7.4

Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

[gre...@linuxfoundation.org]

On Tue, May 01, 2018 at 09:54:37PM +0300, Evgeniy Polyakov wrote:
> Hi Ingo
> 
> Sorry for late reply and because of forcing you to resend the patch, your 
> changes are correct
> 
> 01.05.2018, 17:10, "Ingo Flaschberger" :
> > 1wire family module autoload fails because of upper/lower
> >   case mismatch.
> >
> > Signed-off-by: Ingo Flaschberger 
> 
> Greg, please pull this patch into your tree.
> Should it be stable material?

Looks like it, I'll queue it up to the proper place, thanks!

greg k-h

Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

[gre...@linuxfoundation.org]

On Tue, May 01, 2018 at 09:54:37PM +0300, Evgeniy Polyakov wrote:
> Hi Ingo
> 
> Sorry for late reply and because of forcing you to resend the patch, your 
> changes are correct
> 
> 01.05.2018, 17:10, "Ingo Flaschberger" :
> > 1wire family module autoload fails because of upper/lower
> >   case mismatch.
> >
> > Signed-off-by: Ingo Flaschberger 
> 
> Greg, please pull this patch into your tree.
> Should it be stable material?

Looks like it, I'll queue it up to the proper place, thanks!

greg k-h

[PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

[Ingo Flaschberger]

1wire family module autoload fails because of upper/lower
 case mismatch.

Signed-off-by: Ingo Flaschberger 

---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index ab0931e..aa458f2 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev, 
struct w1_reg_num *rn)


    /* slave modules need to be loaded in a context with unlocked 
mutex */

    mutex_unlock(>mutex);
-   request_module("w1-family-0x%02x", rn->family);
+   request_module("w1-family-0x%02X", rn->family);
    mutex_lock(>mutex);

    spin_lock(_flock);
--
2.7.4

[PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

[Ingo Flaschberger]

1wire family module autoload fails because of upper/lower
 case mismatch.

Signed-off-by: Ingo Flaschberger 

---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index ab0931e..aa458f2 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev, 
struct w1_reg_num *rn)


    /* slave modules need to be loaded in a context with unlocked 
mutex */

    mutex_unlock(>mutex);
-   request_module("w1-family-0x%02x", rn->family);
+   request_module("w1-family-0x%02X", rn->family);
    mutex_lock(>mutex);

    spin_lock(_flock);
--
2.7.4

[PATCH] 1wire: family module autoload fails because of upper/lower, case mismatch.

[Ingo Flaschberger]

1wire family module autoload fails because of upper/lower
 case mismatch.

Signed-off-by: Ingo Flaschberger 

---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index ab0931e..aa458f2 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev, 
struct w1_reg_num *rn)


    /* slave modules need to be loaded in a context with unlocked 
mutex */

    mutex_unlock(>mutex);
-   request_module("w1-family-0x%02x", rn->family);
+   request_module("w1-family-0x%02X", rn->family);
    mutex_lock(>mutex);

    spin_lock(_flock);
--
2.7.4

[PATCH] 1wire: family module autoload fails because of upper/lower, case mismatch.

[Ingo Flaschberger]

1wire family module autoload fails because of upper/lower
 case mismatch.

Signed-off-by: Ingo Flaschberger 

---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index ab0931e..aa458f2 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev, 
struct w1_reg_num *rn)


    /* slave modules need to be loaded in a context with unlocked 
mutex */

    mutex_unlock(>mutex);
-   request_module("w1-family-0x%02x", rn->family);
+   request_module("w1-family-0x%02X", rn->family);
    mutex_lock(>mutex);

    spin_lock(_flock);
--
2.7.4