Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
On Thu, 28 Jun 2001 10:45:55 +0200 (MET DST), Andrzej Krzysztofowicz <[EMAIL PROTECTED]> wrote: >Keith Owens wrote: >> Index: 6-pre6.1/drivers/net/Config.in >> - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI >> + if [ "$CONFIG_ISA" = "y" -o "$CONFIG_EISA" = "y" -o "$CONFIG_PCI" = "y" ]; then >CONFIG_EISA check in this condition is redundant. True, but the line is a cut and paste from higher up in drivers/net/Config.in. Even though it is redundant, it is consistent with the rest of the file. drivers/net/Config.in needs a major cleanup, lots of the if statements can go and be replaced by dep_xxx statements, CONFIG_ETHERTAP is marked obsolete but is tested against experimental, CONFIG_ZNET is marked experimental but is tested against obsolete, etc. I started to clean up the file then decided to leave it, the entire thing is being replaced in 2.5 anyway. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
Keith Owens wrote: > On Thu, 28 Jun 2001 00:07:13 -0400, > Jeff Garzik <[EMAIL PROTECTED]> wrote: > >Steven Cole wrote: > >> - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI > >> + dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI >$CONFIG_PCI > > > >See the "EISA" and "VLB" parts in there? EISA != PCI > > Against 2.4.6-pre6. > > Index: 6-pre6.1/drivers/net/Config.in > --- 6-pre6.1/drivers/net/Config.in Thu, 28 Jun 2001 10:34:32 +1000 kaos >(linux-2.4/l/c/9_Config.in 1.1.2.2.1.3.1.8 644) > +++ 6-pre6.1(w)/drivers/net/Config.in Thu, 28 Jun 2001 16:07:03 +1000 kaos >(linux-2.4/l/c/9_Config.in 1.1.2.2.1.3.1.8 644) > @@ -142,7 +142,11 @@ if [ "$CONFIG_NET_ETHERNET" = "y" ]; the >tristate ' NE/2 (ne2000 MCA version) support' CONFIG_NE2_MCA >tristate ' IBM LAN Adapter/A support' CONFIG_IBMLANA > fi > - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI > + if [ "$CONFIG_ISA" = "y" -o "$CONFIG_EISA" = "y" -o "$CONFIG_PCI" = "y" ]; then CONFIG_EISA check in this condition is redundant. Intentionally ? > + bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI Andrzej -- === Andrzej M. Krzysztofowicz [EMAIL PROTECTED] phone (48)(58) 347 14 61 Faculty of Applied Phys. & Math., Technical University of Gdansk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
Keith Owens wrote: On Thu, 28 Jun 2001 00:07:13 -0400, Jeff Garzik [EMAIL PROTECTED] wrote: Steven Cole wrote: - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI + dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI $CONFIG_PCI See the EISA and VLB parts in there? EISA != PCI Against 2.4.6-pre6. Index: 6-pre6.1/drivers/net/Config.in --- 6-pre6.1/drivers/net/Config.in Thu, 28 Jun 2001 10:34:32 +1000 kaos (linux-2.4/l/c/9_Config.in 1.1.2.2.1.3.1.8 644) +++ 6-pre6.1(w)/drivers/net/Config.in Thu, 28 Jun 2001 16:07:03 +1000 kaos (linux-2.4/l/c/9_Config.in 1.1.2.2.1.3.1.8 644) @@ -142,7 +142,11 @@ if [ $CONFIG_NET_ETHERNET = y ]; the tristate ' NE/2 (ne2000 MCA version) support' CONFIG_NE2_MCA tristate ' IBM LAN Adapter/A support' CONFIG_IBMLANA fi - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI + if [ $CONFIG_ISA = y -o $CONFIG_EISA = y -o $CONFIG_PCI = y ]; then CONFIG_EISA check in this condition is redundant. Intentionally ? + bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI Andrzej -- === Andrzej M. Krzysztofowicz [EMAIL PROTECTED] phone (48)(58) 347 14 61 Faculty of Applied Phys. Math., Technical University of Gdansk - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
On Thu, 28 Jun 2001 10:45:55 +0200 (MET DST), Andrzej Krzysztofowicz [EMAIL PROTECTED] wrote: Keith Owens wrote: Index: 6-pre6.1/drivers/net/Config.in - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI + if [ $CONFIG_ISA = y -o $CONFIG_EISA = y -o $CONFIG_PCI = y ]; then CONFIG_EISA check in this condition is redundant. True, but the line is a cut and paste from higher up in drivers/net/Config.in. Even though it is redundant, it is consistent with the rest of the file. drivers/net/Config.in needs a major cleanup, lots of the if statements can go and be replaced by dep_xxx statements, CONFIG_ETHERTAP is marked obsolete but is tested against experimental, CONFIG_ZNET is marked experimental but is tested against obsolete, etc. I started to clean up the file then decided to leave it, the entire thing is being replaced in 2.5 anyway. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
Steven Cole wrote: > - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI > + dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI $CONFIG_PCI See the "EISA" and "VLB" parts in there? EISA != PCI -- Jeff Garzik | Andre the Giant has a posse. Building 1024| MandrakeSoft | - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
I got this error for 2.4.6-pre6 for make xconfig drivers/net/Config.in: 145: can't handle dep_bool/dep_mbool/dep_tristate condition make[1]: *** [kconfig.tk] Error 1 make[1]: Leaving directory `/usr/src/linux-2.4.6-pre6/scripts' make: *** [xconfig] Error 2 This may be the proper fix. Steven --- linux/drivers/net/Config.in.originalWed Jun 27 20:39:50 2001 +++ linux/drivers/net/Config.in Wed Jun 27 20:41:28 2001 @@ -142,7 +142,7 @@ tristate ' NE/2 (ne2000 MCA version) support' CONFIG_NE2_MCA tristate ' IBM LAN Adapter/A support' CONFIG_IBMLANA fi - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI + dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI $CONFIG_PCI if [ "$CONFIG_NET_PCI" = "y" ]; then dep_tristate 'AMD PCnet32 PCI support' CONFIG_PCNET32 $CONFIG_PCI dep_tristate 'Adaptec Starfire support (EXPERIMENTAL)' CONFIG_ADAPTEC_STARFIRE $CONFIG_PCI $CONFIG_EXPERIMENTAL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
I got this error for 2.4.6-pre6 for make xconfig drivers/net/Config.in: 145: can't handle dep_bool/dep_mbool/dep_tristate condition make[1]: *** [kconfig.tk] Error 1 make[1]: Leaving directory `/usr/src/linux-2.4.6-pre6/scripts' make: *** [xconfig] Error 2 This may be the proper fix. Steven --- linux/drivers/net/Config.in.originalWed Jun 27 20:39:50 2001 +++ linux/drivers/net/Config.in Wed Jun 27 20:41:28 2001 @@ -142,7 +142,7 @@ tristate ' NE/2 (ne2000 MCA version) support' CONFIG_NE2_MCA tristate ' IBM LAN Adapter/A support' CONFIG_IBMLANA fi - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI + dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI $CONFIG_PCI if [ $CONFIG_NET_PCI = y ]; then dep_tristate 'AMD PCnet32 PCI support' CONFIG_PCNET32 $CONFIG_PCI dep_tristate 'Adaptec Starfire support (EXPERIMENTAL)' CONFIG_ADAPTEC_STARFIRE $CONFIG_PCI $CONFIG_EXPERIMENTAL - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
Steven Cole wrote: - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI + dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI $CONFIG_PCI See the EISA and VLB parts in there? EISA != PCI -- Jeff Garzik | Andre the Giant has a posse. Building 1024| MandrakeSoft | - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
