Re: [PATCH] ACPI: nfit: constify *_attribute_group.

[Dan Williams]

On Thu, Jun 22, 2017 at 3:14 AM, Arvind Yadav  wrote:
> File size before:
>textdata bss dec hex filename
>   207921580 994   233665b46 drivers/acpi/nfit/core.o
>
> File size After adding 'const':
>textdata bss dec hex filename
>   209681388 994   233505b36 drivers/acpi/nfit/core.o
>
> Signed-off-by: Arvind Yadav 
> ---
>  drivers/acpi/nfit/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Looks good to me, applied.

Re: [PATCH] ACPI: nfit: constify *_attribute_group.

[Dan Williams]

On Thu, Jun 22, 2017 at 3:14 AM, Arvind Yadav  wrote:
> File size before:
>textdata bss dec hex filename
>   207921580 994   233665b46 drivers/acpi/nfit/core.o
>
> File size After adding 'const':
>textdata bss dec hex filename
>   209681388 994   233505b36 drivers/acpi/nfit/core.o
>
> Signed-off-by: Arvind Yadav 
> ---
>  drivers/acpi/nfit/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Looks good to me, applied.

[PATCH] ACPI: nfit: constify *_attribute_group.

[Arvind Yadav]

File size before:
   textdata bss dec hex filename
  207921580 994   233665b46 drivers/acpi/nfit/core.o

File size After adding 'const':
   textdata bss dec hex filename
  209681388 994   233505b36 drivers/acpi/nfit/core.o

Signed-off-by: Arvind Yadav 
---
 drivers/acpi/nfit/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 656acb5..1871bec 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1066,7 +1066,7 @@ static umode_t nfit_visible(struct kobject *kobj, struct 
attribute *a, int n)
NULL,
 };
 
-static struct attribute_group acpi_nfit_attribute_group = {
+static const struct attribute_group acpi_nfit_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_attributes,
.is_visible = nfit_visible,
@@ -1346,7 +1346,7 @@ static umode_t acpi_nfit_dimm_attr_visible(struct kobject 
*kobj,
return a->mode;
 }
 
-static struct attribute_group acpi_nfit_dimm_attribute_group = {
+static const struct attribute_group acpi_nfit_dimm_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_dimm_attributes,
.is_visible = acpi_nfit_dimm_attr_visible,
@@ -1640,7 +1640,7 @@ static ssize_t range_index_show(struct device *dev,
NULL,
 };
 
-static struct attribute_group acpi_nfit_region_attribute_group = {
+static const struct attribute_group acpi_nfit_region_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_region_attributes,
 };
-- 
1.9.1

[PATCH] ACPI: nfit: constify *_attribute_group.

[Arvind Yadav]

File size before:
   textdata bss dec hex filename
  207921580 994   233665b46 drivers/acpi/nfit/core.o

File size After adding 'const':
   textdata bss dec hex filename
  209681388 994   233505b36 drivers/acpi/nfit/core.o

Signed-off-by: Arvind Yadav 
---
 drivers/acpi/nfit/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 656acb5..1871bec 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1066,7 +1066,7 @@ static umode_t nfit_visible(struct kobject *kobj, struct 
attribute *a, int n)
NULL,
 };
 
-static struct attribute_group acpi_nfit_attribute_group = {
+static const struct attribute_group acpi_nfit_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_attributes,
.is_visible = nfit_visible,
@@ -1346,7 +1346,7 @@ static umode_t acpi_nfit_dimm_attr_visible(struct kobject 
*kobj,
return a->mode;
 }
 
-static struct attribute_group acpi_nfit_dimm_attribute_group = {
+static const struct attribute_group acpi_nfit_dimm_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_dimm_attributes,
.is_visible = acpi_nfit_dimm_attr_visible,
@@ -1640,7 +1640,7 @@ static ssize_t range_index_show(struct device *dev,
NULL,
 };
 
-static struct attribute_group acpi_nfit_region_attribute_group = {
+static const struct attribute_group acpi_nfit_region_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_region_attributes,
 };
-- 
1.9.1