Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
applied thanks for quickly finding and fixing this 2.6.25-rc1 regression. -len On Tuesday 12 February 2008 18:32, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The _WAK global ACPI control method has to be called with the > argument representing the sleep state being exited. Make it happen. > > Special thanks to Mirco Tischler <[EMAIL PROTECTED]> for reporting the > problem and debugging. > > Reported-by: Mirco Tischler <[EMAIL PROTECTED]> > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > --- > drivers/acpi/hardware/hwsleep.c |1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6/drivers/acpi/hardware/hwsleep.c > === > --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c > +++ linux-2.6/drivers/acpi/hardware/hwsleep.c > @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl > return_ACPI_STATUS(status); > } > > + arg.integer.value = sleep_state; > status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL); > if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { > ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK")); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
On Wednesday, 13 of February 2008, Pavel Machek wrote: > On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > The _WAK global ACPI control method has to be called with the > > argument representing the sleep state being exited. Make it happen. > > > > Special thanks to Mirco Tischler <[EMAIL PROTECTED]> for reporting the > > problem and debugging. > > > > Reported-by: Mirco Tischler <[EMAIL PROTECTED]> > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > > ACK. AFAICT this is 2.6.25 material. Sure, it certainly is. The bug has been breaking suspend on people's boxes already. Thanks, Rafael > > --- > > drivers/acpi/hardware/hwsleep.c |1 + > > 1 file changed, 1 insertion(+) > > > > Index: linux-2.6/drivers/acpi/hardware/hwsleep.c > > === > > --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c > > +++ linux-2.6/drivers/acpi/hardware/hwsleep.c > > @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl > > return_ACPI_STATUS(status); > > } > > > > + arg.integer.value = sleep_state; > > status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL); > > if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { > > ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK")); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The _WAK global ACPI control method has to be called with the > argument representing the sleep state being exited. Make it happen. > > Special thanks to Mirco Tischler <[EMAIL PROTECTED]> for reporting the > problem and debugging. > > Reported-by: Mirco Tischler <[EMAIL PROTECTED]> > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> ACK. AFAICT this is 2.6.25 material. Pavel > --- > drivers/acpi/hardware/hwsleep.c |1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6/drivers/acpi/hardware/hwsleep.c > === > --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c > +++ linux-2.6/drivers/acpi/hardware/hwsleep.c > @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl > return_ACPI_STATUS(status); > } > > + arg.integer.value = sleep_state; > status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL); > if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { > ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK")); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ACPI suspend: Execute _WAK with the right argument
From: Rafael J. Wysocki <[EMAIL PROTECTED]> The _WAK global ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen. Special thanks to Mirco Tischler <[EMAIL PROTECTED]> for reporting the problem and debugging. Reported-by: Mirco Tischler <[EMAIL PROTECTED]> Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> --- drivers/acpi/hardware/hwsleep.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6/drivers/acpi/hardware/hwsleep.c === --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c +++ linux-2.6/drivers/acpi/hardware/hwsleep.c @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl return_ACPI_STATUS(status); } + arg.integer.value = sleep_state; status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL); if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK")); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/