Re: [PATCH] ALSA: hda - Remove compilation warning

[Takashi Iwai]

On Mon, 20 Jun 2016 21:42:31 +0200,
Helen Koike wrote:
> 
> Remove the warning:
> warning: ‘err’ may be used uninitialized in this function 
> [-Wmaybe-uninitialized]

It's a false positive, a compiler problem.


Takashi

> 
> Signed-off-by: Helen Koike 
> ---
>  sound/hda/hdac_regmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c
> index 87041dd..7be6ca1 100644
> --- a/sound/hda/hdac_regmap.c
> +++ b/sound/hda/hdac_regmap.c
> @@ -279,7 +279,7 @@ static int hda_reg_write(void *context, unsigned int reg, 
> unsigned int val)
>  {
>   struct hdac_device *codec = context;
>   unsigned int verb;
> - int i, bytes, err;
> + int i, bytes, err = 0;
>   int pm_lock = 0;
>  
>   if (codec->caps_overwriting)
> -- 
> 1.9.1
> 
> 

Re: [PATCH] ALSA: hda - Remove compilation warning

[Takashi Iwai]

On Mon, 20 Jun 2016 21:42:31 +0200,
Helen Koike wrote:
> 
> Remove the warning:
> warning: ‘err’ may be used uninitialized in this function 
> [-Wmaybe-uninitialized]

It's a false positive, a compiler problem.


Takashi

> 
> Signed-off-by: Helen Koike 
> ---
>  sound/hda/hdac_regmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c
> index 87041dd..7be6ca1 100644
> --- a/sound/hda/hdac_regmap.c
> +++ b/sound/hda/hdac_regmap.c
> @@ -279,7 +279,7 @@ static int hda_reg_write(void *context, unsigned int reg, 
> unsigned int val)
>  {
>   struct hdac_device *codec = context;
>   unsigned int verb;
> - int i, bytes, err;
> + int i, bytes, err = 0;
>   int pm_lock = 0;
>  
>   if (codec->caps_overwriting)
> -- 
> 1.9.1
> 
> 

[PATCH] ALSA: hda - Remove compilation warning

[Helen Koike]

Remove the warning:
warning: ‘err’ may be used uninitialized in this function 
[-Wmaybe-uninitialized]

Signed-off-by: Helen Koike 
---
 sound/hda/hdac_regmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c
index 87041dd..7be6ca1 100644
--- a/sound/hda/hdac_regmap.c
+++ b/sound/hda/hdac_regmap.c
@@ -279,7 +279,7 @@ static int hda_reg_write(void *context, unsigned int reg, 
unsigned int val)
 {
struct hdac_device *codec = context;
unsigned int verb;
-   int i, bytes, err;
+   int i, bytes, err = 0;
int pm_lock = 0;
 
if (codec->caps_overwriting)
-- 
1.9.1

[PATCH] ALSA: hda - Remove compilation warning

[Helen Koike]

Remove the warning:
warning: ‘err’ may be used uninitialized in this function 
[-Wmaybe-uninitialized]

Signed-off-by: Helen Koike 
---
 sound/hda/hdac_regmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c
index 87041dd..7be6ca1 100644
--- a/sound/hda/hdac_regmap.c
+++ b/sound/hda/hdac_regmap.c
@@ -279,7 +279,7 @@ static int hda_reg_write(void *context, unsigned int reg, 
unsigned int val)
 {
struct hdac_device *codec = context;
unsigned int verb;
-   int i, bytes, err;
+   int i, bytes, err = 0;
int pm_lock = 0;
 
if (codec->caps_overwriting)
-- 
1.9.1