Re: [PATCH] ARC: unwind: Mark expected switch fall-throughs

[Vineet Gupta]

On 8/6/19 1:02 AM, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warnings (Building: haps_hs_defconfig arc):
> 
> arch/arc/kernel/unwind.c:827:20: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> arch/arc/kernel/unwind.c:836:20: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Gustavo A. R. Silva 

Thx for the patch, applied to arc for-curr.

-Vineet

Re: [PATCH] ARC: unwind: Mark expected switch fall-throughs

[Kees Cook]

On Mon, Aug 05, 2019 at 02:32:32PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warnings (Building: haps_hs_defconfig arc):
> 
> arch/arc/kernel/unwind.c:827:20: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> arch/arc/kernel/unwind.c:836:20: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Gustavo A. R. Silva 

Reviewed-by: Kees Cook 

-Kees

> ---
>  arch/arc/kernel/unwind.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
> index c2663fce7f6c..445e4d702f43 100644
> --- a/arch/arc/kernel/unwind.c
> +++ b/arch/arc/kernel/unwind.c
> @@ -826,7 +826,7 @@ static int processCFI(const u8 *start, const u8 *end, 
> unsigned long targetLoc,
>   case DW_CFA_def_cfa:
>   state->cfa.reg = get_uleb128(, end);
>   unw_debug("cfa_def_cfa: r%lu ", state->cfa.reg);
> - /*nobreak*/
> + /* fall through */
>   case DW_CFA_def_cfa_offset:
>   state->cfa.offs = get_uleb128(, end);
>   unw_debug("cfa_def_cfa_offset: 0x%lx ",
> @@ -834,7 +834,7 @@ static int processCFI(const u8 *start, const u8 *end, 
> unsigned long targetLoc,
>   break;
>   case DW_CFA_def_cfa_sf:
>   state->cfa.reg = get_uleb128(, end);
> - /*nobreak */
> + /* fall through */
>   case DW_CFA_def_cfa_offset_sf:
>   state->cfa.offs = get_sleb128(, end)
>   * state->dataAlign;
> -- 
> 2.22.0
> 

-- 
Kees Cook

[PATCH] ARC: unwind: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

Mark switch cases where we are expecting to fall through.

This patch fixes the following warnings (Building: haps_hs_defconfig arc):

arch/arc/kernel/unwind.c:827:20: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
arch/arc/kernel/unwind.c:836:20: warning: this statement may fall through 
[-Wimplicit-fallthrough=]

Signed-off-by: Gustavo A. R. Silva 
---
 arch/arc/kernel/unwind.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
index c2663fce7f6c..445e4d702f43 100644
--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -826,7 +826,7 @@ static int processCFI(const u8 *start, const u8 *end, 
unsigned long targetLoc,
case DW_CFA_def_cfa:
state->cfa.reg = get_uleb128(, end);
unw_debug("cfa_def_cfa: r%lu ", state->cfa.reg);
-   /*nobreak*/
+   /* fall through */
case DW_CFA_def_cfa_offset:
state->cfa.offs = get_uleb128(, end);
unw_debug("cfa_def_cfa_offset: 0x%lx ",
@@ -834,7 +834,7 @@ static int processCFI(const u8 *start, const u8 *end, 
unsigned long targetLoc,
break;
case DW_CFA_def_cfa_sf:
state->cfa.reg = get_uleb128(, end);
-   /*nobreak */
+   /* fall through */
case DW_CFA_def_cfa_offset_sf:
state->cfa.offs = get_sleb128(, end)
* state->dataAlign;
-- 
2.22.0