Re: [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

2015-01-19 Thread Paul Walmsley 
On Tue, 20 Jan 2015, Keerthy wrote:

> On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:
> > This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
> > error during suspend.
> > 
> > This is because smart idle is broken.
> > Tested in dra7-evm D1 board.
> 
> Ping on this.
> 
> > Signed-off-by: Keerthy 
> > ---
> >   arch/arm/mach-omap2/omap_hwmod_7xx_data.c |3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > index 9cdd8b8..29e55fe 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > @@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
> > .name   = "gpmc",
> > .class  = _gpmc_hwmod_class,
> > .clkdm_name = "l3main1_clkdm",
> > -   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> > +   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
> > +  HWMOD_SWSUP_SIDLE),
> > .main_clk   = "l3_iclk_div",
> > .prcm = {
> > .omap4 = {

Thanks, queued for v3.20.

Note that I cannot test this since I don't have a DRA7xx board.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

2015-01-19 Thread Keerthy 

Hi Tony,

On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:

This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
error during suspend.

This is because smart idle is broken.
Tested in dra7-evm D1 board.


Ping on this.


Signed-off-by: Keerthy 
---
  arch/arm/mach-omap2/omap_hwmod_7xx_data.c |3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 9cdd8b8..29e55fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
.name   = "gpmc",
.class  = _gpmc_hwmod_class,
.clkdm_name = "l3main1_clkdm",
-   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
+  HWMOD_SWSUP_SIDLE),
.main_clk   = "l3_iclk_div",
.prcm = {
.omap4 = {


Regards,
Keerthy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

2015-01-19 Thread Keerthy 

Hi Tony,

On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:

This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
error during suspend.

This is because smart idle is broken.
Tested in dra7-evm D1 board.


Ping on this.


Signed-off-by: Keerthy j-keer...@ti.com
---
  arch/arm/mach-omap2/omap_hwmod_7xx_data.c |3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 9cdd8b8..29e55fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
.name   = gpmc,
.class  = dra7xx_gpmc_hwmod_class,
.clkdm_name = l3main1_clkdm,
-   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
+  HWMOD_SWSUP_SIDLE),
.main_clk   = l3_iclk_div,
.prcm = {
.omap4 = {


Regards,
Keerthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

2015-01-19 Thread Paul Walmsley 
On Tue, 20 Jan 2015, Keerthy wrote:

 On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:
  This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
  error during suspend.
  
  This is because smart idle is broken.
  Tested in dra7-evm D1 board.
 
 Ping on this.
 
  Signed-off-by: Keerthy j-keer...@ti.com
  ---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
  
  diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
  b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
  index 9cdd8b8..29e55fe 100644
  --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
  +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
  @@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
  .name   = gpmc,
  .class  = dra7xx_gpmc_hwmod_class,
  .clkdm_name = l3main1_clkdm,
  -   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
  +   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
  +  HWMOD_SWSUP_SIDLE),
  .main_clk   = l3_iclk_div,
  .prcm = {
  .omap4 = {

Thanks, queued for v3.20.

Note that I cannot test this since I don't have a DRA7xx board.


- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

2015-01-13 Thread Keerthy 
This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
error during suspend.

This is because smart idle is broken.
Tested in dra7-evm D1 board.

Signed-off-by: Keerthy 
---
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 9cdd8b8..29e55fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
.name   = "gpmc",
.class  = _gpmc_hwmod_class,
.clkdm_name = "l3main1_clkdm",
-   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
+  HWMOD_SWSUP_SIDLE),
.main_clk   = "l3_iclk_div",
.prcm = {
.omap4 = {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

2015-01-13 Thread Keerthy 
This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
error during suspend.

This is because smart idle is broken.
Tested in dra7-evm D1 board.

Signed-off-by: Keerthy j-keer...@ti.com
---
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 9cdd8b8..29e55fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
.name   = gpmc,
.class  = dra7xx_gpmc_hwmod_class,
.clkdm_name = l3main1_clkdm,
-   .flags  = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+   .flags  = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
+  HWMOD_SWSUP_SIDLE),
.main_clk   = l3_iclk_div,
.prcm = {
.omap4 = {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/