Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
* Ladislav Michl [190827 18:15]: > On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > > * Markus Elfring [190826 06:31]: > > > From: Markus Elfring > > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > > > A null pointer would be passed to a call of the function "kfree" directly > > > after a call of the function "kzalloc" failed at one place. > > > Remove this superfluous function call. > > > > > > This issue was detected by using the Coccinelle software. > > > > Applying into omap-for-v5.4/soc thanks. > > Is it really wise touching almost dead code? Last user is pandora board, so > +Cc: Nikolaus Schaller Yeah would be good to finally get rid of that old code. Anyways, I'll keep the $subject patch to cut down on coccinelle produced issue. Regards, Tony
Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > * Markus Elfring [190826 06:31]: > > From: Markus Elfring > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > A null pointer would be passed to a call of the function "kfree" directly > > after a call of the function "kzalloc" failed at one place. > > Remove this superfluous function call. > > > > This issue was detected by using the Coccinelle software. > > Applying into omap-for-v5.4/soc thanks. Is it really wise touching almost dead code? Last user is pandora board, so +Cc: Nikolaus Schaller
Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
* Markus Elfring [190826 06:31]: > From: Markus Elfring > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > A null pointer would be passed to a call of the function "kfree" directly > after a call of the function "kzalloc" failed at one place. > Remove this superfluous function call. > > This issue was detected by using the Coccinelle software. Applying into omap-for-v5.4/soc thanks. Tony
[PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init()
From: Markus Elfring Date: Mon, 26 Aug 2019 15:05:31 +0200 A null pointer would be passed to a call of the function "kfree" directly after a call of the function "kzalloc" failed at one place. Remove this superfluous function call. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/mach-omap2/hsmmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c index 14b9c13c1fa0..63423ea6a240 100644 --- a/arch/arm/mach-omap2/hsmmc.c +++ b/arch/arm/mach-omap2/hsmmc.c @@ -32,10 +32,8 @@ static int __init omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c, char *hc_name; hc_name = kzalloc(HSMMC_NAME_LEN + 1, GFP_KERNEL); - if (!hc_name) { - kfree(hc_name); + if (!hc_name) return -ENOMEM; - } snprintf(hc_name, (HSMMC_NAME_LEN + 1), "mmc%islot%i", c->mmc, 1); mmc->name = hc_name; -- 2.23.0