Re: [PATCH] ARM: don't export unused return_address()
Hi Arnd,
On Fri, Sep 6, 2019 at 5:47 PM Arnd Bergmann wrote:
> Without the frame pointer enabled, return_address() is an inline
> function and does not need to be exported, as shown by this warning:
>
> WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.
>
> Signed-off-by: Arnd Bergmann
Thanks for your patch!
Tested-by: Geert Uytterhoeven
> --- a/arch/arm/kernel/return_address.c
> +++ b/arch/arm/kernel/return_address.c
> @@ -53,6 +53,7 @@ void *return_address(unsigned int level)
> return NULL;
> }
>
Checkpatch doesn't like the empty line above:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> +EXPORT_SYMBOL_GPL(return_address);
> +
> #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
>
> -EXPORT_SYMBOL_GPL(return_address);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] ARM: don't export unused return_address()
On Sat, Sep 7, 2019 at 12:47 AM Arnd Bergmann wrote: > > Without the frame pointer enabled, return_address() is an inline > function and does not need to be exported, as shown by this warning: > > WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL > > Move the EXPORT_SYMBOL_GPL() into the #ifdef as well. > > Signed-off-by: Arnd Bergmann Reviewed-by: Masahiro Yamada -- Best Regards Masahiro Yamada
[PATCH] ARM: don't export unused return_address()
Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning: WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL Move the EXPORT_SYMBOL_GPL() into the #ifdef as well. Signed-off-by: Arnd Bergmann --- arch/arm/kernel/return_address.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c index b0d2f1fe891d..fb0fc1910102 100644 --- a/arch/arm/kernel/return_address.c +++ b/arch/arm/kernel/return_address.c @@ -53,6 +53,7 @@ void *return_address(unsigned int level) return NULL; } +EXPORT_SYMBOL_GPL(return_address); + #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */ -EXPORT_SYMBOL_GPL(return_address); -- 2.20.0
