Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: > The chipidea driver adds an extra line of spam to the log when a > host-only chipidea instance is left set to the default of a dual role > controller. > > [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget > > Set the dr_mode property to host on all the host-only nodes > to avoid this warning. > > Signed-off-by: Matt Porter Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. Signed-off-by: Matt Porter mpor...@konsulko.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Tue, Mar 03, 2015 at 10:08:09AM -0500, Matt Porter wrote: > On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote: > > On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: > > > > > > On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: > > > > The chipidea driver adds an extra line of spam to the log when a > > > > host-only chipidea instance is left set to the default of a dual role > > > > controller. > > > > > > > > [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget > > > > > > > > Set the dr_mode property to host on all the host-only nodes > > > > to avoid this warning. > > > > It is not an warning, it is dev_info. > > True enough, it's info level but is essentially warning that, in the > case of instances that are restricted to host only (at the SoC level), > that the DT hardware description is incorrect. Yes, it's benign, but > if the dtsi is corrected for those parts we don't have to see that > message. You are right. > > > In fact, imx28, imx6sl and imx6sx's second controller is dual-role > > controller, we only set dr_mode at board's dts according to design > > unless the controller's capability register is incorrect. > > The patch doesn't set dr_mode to host on the second controller for > the imx6sl or imx6sx, only on the third host-only controller. If > imx28's second controller is really dual-role capable then the > reference manual is incorrect and I can drop that hunk in v2. > I only have imx6q and imx6d parts in hand to verify so for the rest > I went by the RM claim of which controllers were host-only. Maybe IC guys don't want to export that imx28's that capabilities, so don't need to change. > > > So, sorry, I don't think this change is necessary. > > I can correct the set of instances that should have dr_mode set to host > in v2 of this. We clearly have some that should have this set in their > SoC .dtsi to have the hardware description correct. Will that work for > you or do you want the SoC-specific cases of this property to be only > reflected in the board level dts? > After thinking more, it is a benefit fix, and doesn't need to do any changes, thanks. Acked-by: Peter Chen -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote: > On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: > > > > On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: > > > The chipidea driver adds an extra line of spam to the log when a > > > host-only chipidea instance is left set to the default of a dual role > > > controller. > > > > > > [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget > > > > > > Set the dr_mode property to host on all the host-only nodes > > > to avoid this warning. > > It is not an warning, it is dev_info. True enough, it's info level but is essentially warning that, in the case of instances that are restricted to host only (at the SoC level), that the DT hardware description is incorrect. Yes, it's benign, but if the dtsi is corrected for those parts we don't have to see that message. > In fact, imx28, imx6sl and imx6sx's second controller is dual-role > controller, we only set dr_mode at board's dts according to design > unless the controller's capability register is incorrect. The patch doesn't set dr_mode to host on the second controller for the imx6sl or imx6sx, only on the third host-only controller. If imx28's second controller is really dual-role capable then the reference manual is incorrect and I can drop that hunk in v2. I only have imx6q and imx6d parts in hand to verify so for the rest I went by the RM claim of which controllers were host-only. > So, sorry, I don't think this change is necessary. I can correct the set of instances that should have dr_mode set to host in v2 of this. We clearly have some that should have this set in their SoC .dtsi to have the hardware description correct. Will that work for you or do you want the SoC-specific cases of this property to be only reflected in the board level dts? -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote: On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. It is not an warning, it is dev_info. True enough, it's info level but is essentially warning that, in the case of instances that are restricted to host only (at the SoC level), that the DT hardware description is incorrect. Yes, it's benign, but if the dtsi is corrected for those parts we don't have to see that message. In fact, imx28, imx6sl and imx6sx's second controller is dual-role controller, we only set dr_mode at board's dts according to design unless the controller's capability register is incorrect. The patch doesn't set dr_mode to host on the second controller for the imx6sl or imx6sx, only on the third host-only controller. If imx28's second controller is really dual-role capable then the reference manual is incorrect and I can drop that hunk in v2. I only have imx6q and imx6d parts in hand to verify so for the rest I went by the RM claim of which controllers were host-only. So, sorry, I don't think this change is necessary. I can correct the set of instances that should have dr_mode set to host in v2 of this. We clearly have some that should have this set in their SoC .dtsi to have the hardware description correct. Will that work for you or do you want the SoC-specific cases of this property to be only reflected in the board level dts? -Matt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Tue, Mar 03, 2015 at 10:08:09AM -0500, Matt Porter wrote: On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote: On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. It is not an warning, it is dev_info. True enough, it's info level but is essentially warning that, in the case of instances that are restricted to host only (at the SoC level), that the DT hardware description is incorrect. Yes, it's benign, but if the dtsi is corrected for those parts we don't have to see that message. You are right. In fact, imx28, imx6sl and imx6sx's second controller is dual-role controller, we only set dr_mode at board's dts according to design unless the controller's capability register is incorrect. The patch doesn't set dr_mode to host on the second controller for the imx6sl or imx6sx, only on the third host-only controller. If imx28's second controller is really dual-role capable then the reference manual is incorrect and I can drop that hunk in v2. I only have imx6q and imx6d parts in hand to verify so for the rest I went by the RM claim of which controllers were host-only. Maybe IC guys don't want to export that imx28's that capabilities, so don't need to change. So, sorry, I don't think this change is necessary. I can correct the set of instances that should have dr_mode set to host in v2 of this. We clearly have some that should have this set in their SoC .dtsi to have the hardware description correct. Will that work for you or do you want the SoC-specific cases of this property to be only reflected in the board level dts? After thinking more, it is a benefit fix, and doesn't need to do any changes, thanks. Acked-by: Peter Chen peter.c...@freescale.com -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: > > On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: > > The chipidea driver adds an extra line of spam to the log when a > > host-only chipidea instance is left set to the default of a dual role > > controller. > > > > [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget > > > > Set the dr_mode property to host on all the host-only nodes > > to avoid this warning. It is not an warning, it is dev_info. In fact, imx28, imx6sl and imx6sx's second controller is dual-role controller, we only set dr_mode at board's dts according to design unless the controller's capability register is incorrect. So, sorry, I don't think this change is necessary. > > > > Signed-off-by: Matt Porter > > --- > > arch/arm/boot/dts/imx27.dtsi | 2 ++ > > arch/arm/boot/dts/imx28.dtsi | 1 + > > arch/arm/boot/dts/imx35.dtsi | 1 + > > arch/arm/boot/dts/imx50.dtsi | 3 +++ > > arch/arm/boot/dts/imx51.dtsi | 3 +++ > > arch/arm/boot/dts/imx53.dtsi | 3 +++ > > arch/arm/boot/dts/imx6qdl.dtsi | 3 +++ > > arch/arm/boot/dts/imx6sl.dtsi | 1 + > > arch/arm/boot/dts/imx6sx.dtsi | 1 + > > 9 files changed, 18 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > > index 4b063b6..6951b66 100644 > > --- a/arch/arm/boot/dts/imx27.dtsi > > +++ b/arch/arm/boot/dts/imx27.dtsi > > @@ -488,6 +488,7 @@ > > interrupts = <54>; > > clocks = < IMX27_CLK_USB_IPG_GATE>; > > fsl,usbmisc = < 1>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > @@ -497,6 +498,7 @@ > > interrupts = <55>; > > clocks = < IMX27_CLK_USB_IPG_GATE>; > > fsl,usbmisc = < 2>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > > index 47f68ac..02330f4 100644 > > --- a/arch/arm/boot/dts/imx28.dtsi > > +++ b/arch/arm/boot/dts/imx28.dtsi > > @@ -1197,6 +1197,7 @@ > > interrupts = <92>; > > clocks = < 61>; > > fsl,usbphy = <>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi > > index 6932928..b6478e9 100644 > > --- a/arch/arm/boot/dts/imx35.dtsi > > +++ b/arch/arm/boot/dts/imx35.dtsi > > @@ -318,6 +318,7 @@ > > clocks = < 73>; > > fsl,usbmisc = < 1>; > > fsl,usbphy = <>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi > > index 620b0f0..e245713 100644 > > --- a/arch/arm/boot/dts/imx50.dtsi > > +++ b/arch/arm/boot/dts/imx50.dtsi > > @@ -197,6 +197,7 @@ > > reg = <0x53f80200 0x0200>; > > interrupts = <14>; > > clocks = < IMX5_CLK_USB_PHY2_GATE>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > @@ -205,6 +206,7 @@ > > reg = <0x53f80400 0x0200>; > > interrupts = <16>; > > clocks = < IMX5_CLK_USBOH3_GATE>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > @@ -213,6 +215,7 @@ > > reg = <0x53f80600 0x0200>; > > interrupts = <17>; > > clocks = < IMX5_CLK_USBOH3_GATE>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi > > index c0116cf..f46fe9b 100644 > > --- a/arch/arm/boot/dts/imx51.dtsi > > +++ b/arch/arm/boot/dts/imx51.dtsi > > @@ -265,6 +265,7 @@ > > interrupts = <14>; > > clocks = < IMX5_CLK_USBOH3_GATE>; > > fsl,usbmisc = < 1>; > > + dr_mode = "host"; > > status = "disabled"; > > }; > > > > @@ -274,6 +275,7 @@ > > interrupts = <16>; > > clocks = < IMX5_CLK_USBOH3_GATE>; > > fsl,usbmisc = < 2>; > > + dr_mode = "host"; > >
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
Peter, Can you take a look at Matt's patch below? Shawn On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: > The chipidea driver adds an extra line of spam to the log when a > host-only chipidea instance is left set to the default of a dual role > controller. > > [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget > > Set the dr_mode property to host on all the host-only nodes > to avoid this warning. > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/imx27.dtsi | 2 ++ > arch/arm/boot/dts/imx28.dtsi | 1 + > arch/arm/boot/dts/imx35.dtsi | 1 + > arch/arm/boot/dts/imx50.dtsi | 3 +++ > arch/arm/boot/dts/imx51.dtsi | 3 +++ > arch/arm/boot/dts/imx53.dtsi | 3 +++ > arch/arm/boot/dts/imx6qdl.dtsi | 3 +++ > arch/arm/boot/dts/imx6sl.dtsi | 1 + > arch/arm/boot/dts/imx6sx.dtsi | 1 + > 9 files changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index 4b063b6..6951b66 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -488,6 +488,7 @@ > interrupts = <54>; > clocks = < IMX27_CLK_USB_IPG_GATE>; > fsl,usbmisc = < 1>; > + dr_mode = "host"; > status = "disabled"; > }; > > @@ -497,6 +498,7 @@ > interrupts = <55>; > clocks = < IMX27_CLK_USB_IPG_GATE>; > fsl,usbmisc = < 2>; > + dr_mode = "host"; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > index 47f68ac..02330f4 100644 > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -1197,6 +1197,7 @@ > interrupts = <92>; > clocks = < 61>; > fsl,usbphy = <>; > + dr_mode = "host"; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi > index 6932928..b6478e9 100644 > --- a/arch/arm/boot/dts/imx35.dtsi > +++ b/arch/arm/boot/dts/imx35.dtsi > @@ -318,6 +318,7 @@ > clocks = < 73>; > fsl,usbmisc = < 1>; > fsl,usbphy = <>; > + dr_mode = "host"; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi > index 620b0f0..e245713 100644 > --- a/arch/arm/boot/dts/imx50.dtsi > +++ b/arch/arm/boot/dts/imx50.dtsi > @@ -197,6 +197,7 @@ > reg = <0x53f80200 0x0200>; > interrupts = <14>; > clocks = < IMX5_CLK_USB_PHY2_GATE>; > + dr_mode = "host"; > status = "disabled"; > }; > > @@ -205,6 +206,7 @@ > reg = <0x53f80400 0x0200>; > interrupts = <16>; > clocks = < IMX5_CLK_USBOH3_GATE>; > + dr_mode = "host"; > status = "disabled"; > }; > > @@ -213,6 +215,7 @@ > reg = <0x53f80600 0x0200>; > interrupts = <17>; > clocks = < IMX5_CLK_USBOH3_GATE>; > + dr_mode = "host"; > status = "disabled"; > }; > > diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi > index c0116cf..f46fe9b 100644 > --- a/arch/arm/boot/dts/imx51.dtsi > +++ b/arch/arm/boot/dts/imx51.dtsi > @@ -265,6 +265,7 @@ > interrupts = <14>; > clocks = < IMX5_CLK_USBOH3_GATE>; > fsl,usbmisc = < 1>; > + dr_mode = "host"; > status = "disabled"; > }; > > @@ -274,6 +275,7 @@ > interrupts = <16>; > clocks = < IMX5_CLK_USBOH3_GATE>; > fsl,usbmisc = < 2>; > + dr_mode = "host"; > status = "disabled"; > }; > > @@ -283,6 +285,7 @@ > interrupts = <17>; > clocks = < IMX5_CLK_USBOH3_GATE>; > fsl,usbmisc = < 3>; > + dr_mode = "host"; > status = "disabled"; > }; > > diff --git
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
Peter, Can you take a look at Matt's patch below? Shawn On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. Signed-off-by: Matt Porter mpor...@konsulko.com --- arch/arm/boot/dts/imx27.dtsi | 2 ++ arch/arm/boot/dts/imx28.dtsi | 1 + arch/arm/boot/dts/imx35.dtsi | 1 + arch/arm/boot/dts/imx50.dtsi | 3 +++ arch/arm/boot/dts/imx51.dtsi | 3 +++ arch/arm/boot/dts/imx53.dtsi | 3 +++ arch/arm/boot/dts/imx6qdl.dtsi | 3 +++ arch/arm/boot/dts/imx6sl.dtsi | 1 + arch/arm/boot/dts/imx6sx.dtsi | 1 + 9 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 4b063b6..6951b66 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -488,6 +488,7 @@ interrupts = 54; clocks = clks IMX27_CLK_USB_IPG_GATE; fsl,usbmisc = usbmisc 1; + dr_mode = host; status = disabled; }; @@ -497,6 +498,7 @@ interrupts = 55; clocks = clks IMX27_CLK_USB_IPG_GATE; fsl,usbmisc = usbmisc 2; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 47f68ac..02330f4 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1197,6 +1197,7 @@ interrupts = 92; clocks = clks 61; fsl,usbphy = usbphy1; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index 6932928..b6478e9 100644 --- a/arch/arm/boot/dts/imx35.dtsi +++ b/arch/arm/boot/dts/imx35.dtsi @@ -318,6 +318,7 @@ clocks = clks 73; fsl,usbmisc = usbmisc 1; fsl,usbphy = usbphy1; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi index 620b0f0..e245713 100644 --- a/arch/arm/boot/dts/imx50.dtsi +++ b/arch/arm/boot/dts/imx50.dtsi @@ -197,6 +197,7 @@ reg = 0x53f80200 0x0200; interrupts = 14; clocks = clks IMX5_CLK_USB_PHY2_GATE; + dr_mode = host; status = disabled; }; @@ -205,6 +206,7 @@ reg = 0x53f80400 0x0200; interrupts = 16; clocks = clks IMX5_CLK_USBOH3_GATE; + dr_mode = host; status = disabled; }; @@ -213,6 +215,7 @@ reg = 0x53f80600 0x0200; interrupts = 17; clocks = clks IMX5_CLK_USBOH3_GATE; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index c0116cf..f46fe9b 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -265,6 +265,7 @@ interrupts = 14; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 1; + dr_mode = host; status = disabled; }; @@ -274,6 +275,7 @@ interrupts = 16; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 2; + dr_mode = host; status = disabled; }; @@ -283,6 +285,7 @@ interrupts = 17; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 3; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index ff4fa7e..c3e3ca9 100644 ---
Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote: On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote: The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. It is not an warning, it is dev_info. In fact, imx28, imx6sl and imx6sx's second controller is dual-role controller, we only set dr_mode at board's dts according to design unless the controller's capability register is incorrect. So, sorry, I don't think this change is necessary. Signed-off-by: Matt Porter mpor...@konsulko.com --- arch/arm/boot/dts/imx27.dtsi | 2 ++ arch/arm/boot/dts/imx28.dtsi | 1 + arch/arm/boot/dts/imx35.dtsi | 1 + arch/arm/boot/dts/imx50.dtsi | 3 +++ arch/arm/boot/dts/imx51.dtsi | 3 +++ arch/arm/boot/dts/imx53.dtsi | 3 +++ arch/arm/boot/dts/imx6qdl.dtsi | 3 +++ arch/arm/boot/dts/imx6sl.dtsi | 1 + arch/arm/boot/dts/imx6sx.dtsi | 1 + 9 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 4b063b6..6951b66 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -488,6 +488,7 @@ interrupts = 54; clocks = clks IMX27_CLK_USB_IPG_GATE; fsl,usbmisc = usbmisc 1; + dr_mode = host; status = disabled; }; @@ -497,6 +498,7 @@ interrupts = 55; clocks = clks IMX27_CLK_USB_IPG_GATE; fsl,usbmisc = usbmisc 2; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 47f68ac..02330f4 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1197,6 +1197,7 @@ interrupts = 92; clocks = clks 61; fsl,usbphy = usbphy1; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index 6932928..b6478e9 100644 --- a/arch/arm/boot/dts/imx35.dtsi +++ b/arch/arm/boot/dts/imx35.dtsi @@ -318,6 +318,7 @@ clocks = clks 73; fsl,usbmisc = usbmisc 1; fsl,usbphy = usbphy1; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi index 620b0f0..e245713 100644 --- a/arch/arm/boot/dts/imx50.dtsi +++ b/arch/arm/boot/dts/imx50.dtsi @@ -197,6 +197,7 @@ reg = 0x53f80200 0x0200; interrupts = 14; clocks = clks IMX5_CLK_USB_PHY2_GATE; + dr_mode = host; status = disabled; }; @@ -205,6 +206,7 @@ reg = 0x53f80400 0x0200; interrupts = 16; clocks = clks IMX5_CLK_USBOH3_GATE; + dr_mode = host; status = disabled; }; @@ -213,6 +215,7 @@ reg = 0x53f80600 0x0200; interrupts = 17; clocks = clks IMX5_CLK_USBOH3_GATE; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index c0116cf..f46fe9b 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -265,6 +265,7 @@ interrupts = 14; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 1; + dr_mode = host; status = disabled; }; @@ -274,6 +275,7 @@ interrupts = 16; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 2; + dr_mode = host; status = disabled; }; @@ -283,6 +285,7 @@ interrupts = 17; clocks = clks IMX5_CLK_USBOH3_GATE;
[PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. Signed-off-by: Matt Porter --- arch/arm/boot/dts/imx27.dtsi | 2 ++ arch/arm/boot/dts/imx28.dtsi | 1 + arch/arm/boot/dts/imx35.dtsi | 1 + arch/arm/boot/dts/imx50.dtsi | 3 +++ arch/arm/boot/dts/imx51.dtsi | 3 +++ arch/arm/boot/dts/imx53.dtsi | 3 +++ arch/arm/boot/dts/imx6qdl.dtsi | 3 +++ arch/arm/boot/dts/imx6sl.dtsi | 1 + arch/arm/boot/dts/imx6sx.dtsi | 1 + 9 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 4b063b6..6951b66 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -488,6 +488,7 @@ interrupts = <54>; clocks = < IMX27_CLK_USB_IPG_GATE>; fsl,usbmisc = < 1>; + dr_mode = "host"; status = "disabled"; }; @@ -497,6 +498,7 @@ interrupts = <55>; clocks = < IMX27_CLK_USB_IPG_GATE>; fsl,usbmisc = < 2>; + dr_mode = "host"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 47f68ac..02330f4 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1197,6 +1197,7 @@ interrupts = <92>; clocks = < 61>; fsl,usbphy = <>; + dr_mode = "host"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index 6932928..b6478e9 100644 --- a/arch/arm/boot/dts/imx35.dtsi +++ b/arch/arm/boot/dts/imx35.dtsi @@ -318,6 +318,7 @@ clocks = < 73>; fsl,usbmisc = < 1>; fsl,usbphy = <>; + dr_mode = "host"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi index 620b0f0..e245713 100644 --- a/arch/arm/boot/dts/imx50.dtsi +++ b/arch/arm/boot/dts/imx50.dtsi @@ -197,6 +197,7 @@ reg = <0x53f80200 0x0200>; interrupts = <14>; clocks = < IMX5_CLK_USB_PHY2_GATE>; + dr_mode = "host"; status = "disabled"; }; @@ -205,6 +206,7 @@ reg = <0x53f80400 0x0200>; interrupts = <16>; clocks = < IMX5_CLK_USBOH3_GATE>; + dr_mode = "host"; status = "disabled"; }; @@ -213,6 +215,7 @@ reg = <0x53f80600 0x0200>; interrupts = <17>; clocks = < IMX5_CLK_USBOH3_GATE>; + dr_mode = "host"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index c0116cf..f46fe9b 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -265,6 +265,7 @@ interrupts = <14>; clocks = < IMX5_CLK_USBOH3_GATE>; fsl,usbmisc = < 1>; + dr_mode = "host"; status = "disabled"; }; @@ -274,6 +275,7 @@ interrupts = <16>; clocks = < IMX5_CLK_USBOH3_GATE>; fsl,usbmisc = < 2>; + dr_mode = "host"; status = "disabled"; }; @@ -283,6 +285,7 @@ interrupts = <17>; clocks = < IMX5_CLK_USBOH3_GATE>; fsl,usbmisc = < 3>; + dr_mode = "host"; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index ff4fa7e..c3e3ca9 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -309,6 +309,7 @@ clocks = < IMX5_CLK_USBOH3_GATE>;
[PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
The chipidea driver adds an extra line of spam to the log when a host-only chipidea instance is left set to the default of a dual role controller. [2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget Set the dr_mode property to host on all the host-only nodes to avoid this warning. Signed-off-by: Matt Porter mpor...@konsulko.com --- arch/arm/boot/dts/imx27.dtsi | 2 ++ arch/arm/boot/dts/imx28.dtsi | 1 + arch/arm/boot/dts/imx35.dtsi | 1 + arch/arm/boot/dts/imx50.dtsi | 3 +++ arch/arm/boot/dts/imx51.dtsi | 3 +++ arch/arm/boot/dts/imx53.dtsi | 3 +++ arch/arm/boot/dts/imx6qdl.dtsi | 3 +++ arch/arm/boot/dts/imx6sl.dtsi | 1 + arch/arm/boot/dts/imx6sx.dtsi | 1 + 9 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 4b063b6..6951b66 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -488,6 +488,7 @@ interrupts = 54; clocks = clks IMX27_CLK_USB_IPG_GATE; fsl,usbmisc = usbmisc 1; + dr_mode = host; status = disabled; }; @@ -497,6 +498,7 @@ interrupts = 55; clocks = clks IMX27_CLK_USB_IPG_GATE; fsl,usbmisc = usbmisc 2; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 47f68ac..02330f4 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1197,6 +1197,7 @@ interrupts = 92; clocks = clks 61; fsl,usbphy = usbphy1; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index 6932928..b6478e9 100644 --- a/arch/arm/boot/dts/imx35.dtsi +++ b/arch/arm/boot/dts/imx35.dtsi @@ -318,6 +318,7 @@ clocks = clks 73; fsl,usbmisc = usbmisc 1; fsl,usbphy = usbphy1; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi index 620b0f0..e245713 100644 --- a/arch/arm/boot/dts/imx50.dtsi +++ b/arch/arm/boot/dts/imx50.dtsi @@ -197,6 +197,7 @@ reg = 0x53f80200 0x0200; interrupts = 14; clocks = clks IMX5_CLK_USB_PHY2_GATE; + dr_mode = host; status = disabled; }; @@ -205,6 +206,7 @@ reg = 0x53f80400 0x0200; interrupts = 16; clocks = clks IMX5_CLK_USBOH3_GATE; + dr_mode = host; status = disabled; }; @@ -213,6 +215,7 @@ reg = 0x53f80600 0x0200; interrupts = 17; clocks = clks IMX5_CLK_USBOH3_GATE; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index c0116cf..f46fe9b 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -265,6 +265,7 @@ interrupts = 14; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 1; + dr_mode = host; status = disabled; }; @@ -274,6 +275,7 @@ interrupts = 16; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 2; + dr_mode = host; status = disabled; }; @@ -283,6 +285,7 @@ interrupts = 17; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 3; + dr_mode = host; status = disabled; }; diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index ff4fa7e..c3e3ca9 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -309,6 +309,7 @@ clocks = clks
