Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

2024-01-27 Thread Bjorn Andersson 


On Mon, 04 Dec 2023 11:46:49 +0200, Matti Lehtimäki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys
  commit: ffb05e91b68bc58484b94b5d3d1aa8e559278fd6

Best regards,
-- 
Bjorn Andersson

Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

2023-12-04 Thread Luca Weiss 
On Montag, 4. Dezember 2023 10:46:49 CET Matti Lehtimäki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
> 
> Signed-off-by: Matti Lehtimäki 
> ---
>  .../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts| 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index
> f516e0426bb9..8a2ba2aadf23 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -268,6 +268,13 @@ touchscreen@4a {
>   interrupt-parent = <>;
>   interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> 
> + linux,keycodes =  +   KEY_RESERVED
> +   KEY_RESERVED
> +   KEY_RESERVED
> +   KEY_APPSELECT
> +   KEY_BACK>;

Might be prettier like this since it's 6 items you're adding, not one long 
property?

linux,keycodes = ,
  ,
  ,
  ,
  ,
  ;

Resulting dtb should be the same, so it's just a stylistic thing.

In any case:

Reviewed-by: Luca Weiss 

> +
>   pinctrl-names = "default";
>   pinctrl-0 = <_int_rst_default_state>;

Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

2023-12-04 Thread Konrad Dybcio 
On 4.12.2023 10:46, Matti Lehtimäki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
> 
> Signed-off-by: Matti Lehtimäki 
> ---
Reviewed-by: Konrad Dybcio 

Konrad

[PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

2023-12-04 Thread Matti Lehtimäki 
Add touch keys which are handled in touchscreen driver.
Use KEY_APPSELECT for the left button because other devices use that
even though downstream kernel uses KEY_RECENT.

Signed-off-by: Matti Lehtimäki 
---
 .../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts| 7 +++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts 
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index f516e0426bb9..8a2ba2aadf23 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -268,6 +268,13 @@ touchscreen@4a {
interrupt-parent = <>;
interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
 
+   linux,keycodes = ;
+
pinctrl-names = "default";
pinctrl-0 = <_int_rst_default_state>;
 
-- 
2.40.1