Re: [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support
On 2019/8/20 下午9:56, Heiko Stuebner wrote:
Hi Kever,
Am Dienstag, 20. August 2019, 12:03:52 CEST schrieb Kever Yang:
Since there is no one using this board, remove it.
so just to elaborate a bit, I guess this board was internal to Rockchip,
never went to the market and therefore is obsolete without any users,
right?
Yes, even if there is someone using this board, they don't use upstream
source code, you can see
there is only one commit relate to board itself, but never update. So I
would like to remove it
from kernel and U-Boot upstream.
Also we should remove the binding from
Documentation/devicetree/bindings/arm/rockchip.yaml as well
Will update.
Thanks,
- Kever
Heiko
Signed-off-by: Kever Yang
---
arch/arm/boot/dts/rk3288-fennec.dts | 347
1 file changed, 347 deletions(-)
delete mode 100644 arch/arm/boot/dts/rk3288-fennec.dts
diff --git a/arch/arm/boot/dts/rk3288-fennec.dts
b/arch/arm/boot/dts/rk3288-fennec.dts
deleted file mode 100644
index 4847cf902a15..
--- a/arch/arm/boot/dts/rk3288-fennec.dts
+++ /dev/null
@@ -1,347 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-
-/dts-v1/;
-
-#include "rk3288.dtsi"
-
-/ {
- model = "Rockchip RK3288 Fennec Board";
- compatible = "rockchip,rk3288-fennec", "rockchip,rk3288";
-
- memory@0 {
- reg = <0x0 0x0 0x0 0x8000>;
- device_type = "memory";
- };
-
- ext_gmac: external-gmac-clock {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <12500>;
- clock-output-names = "ext_gmac";
- };
-
- vcc_sys: vsys-regulator {
- compatible = "regulator-fixed";
- regulator-name = "vcc_sys";
- regulator-min-microvolt = <500>;
- regulator-max-microvolt = <500>;
- regulator-always-on;
- regulator-boot-on;
- };
-};
-
- {
- cpu0-supply = <_cpu>;
-};
-
- {
- bus-width = <8>;
- cap-mmc-highspeed;
- non-removable;
- pinctrl-names = "default";
- pinctrl-0 = <_clk _cmd _pwr _bus8>;
- status = "okay";
-};
-
- {
- assigned-clocks = < SCLK_MAC>;
- assigned-clock-parents = <_gmac>;
- clock_in_out = "input";
- pinctrl-names = "default";
- pinctrl-0 = <_pins>, <_rst>, <_pmeb>, <_int>;
- phy-supply = <_lan>;
- phy-mode = "rgmii";
- snps,reset-active-low;
- snps,reset-delays-us = <0 1 100>;
- snps,reset-gpio = < RK_PB0 GPIO_ACTIVE_LOW>;
- tx_delay = <0x30>;
- rx_delay = <0x10>;
- status = "okay";
-};
-
- {
- mali-supply = <_gpu>;
- status = "okay";
-};
-
- {
- status = "okay";
-};
-
- {
- status = "okay";
- clock-frequency = <40>;
-
- rk808: pmic@1b {
- compatible = "rockchip,rk808";
- reg = <0x1b>;
- interrupt-parent = <>;
- interrupts = ;
- #clock-cells = <1>;
- clock-output-names = "xin32k", "rk808-clkout2";
- pinctrl-names = "default";
- pinctrl-0 = <_int _pwroff>;
- rockchip,system-power-controller;
- wakeup-source;
-
- vcc1-supply = <_sys>;
- vcc2-supply = <_sys>;
- vcc3-supply = <_sys>;
- vcc4-supply = <_sys>;
- vcc6-supply = <_sys>;
- vcc7-supply = <_sys>;
- vcc8-supply = <_io>;
- vcc9-supply = <_io>;
- vcc10-supply = <_io>;
- vcc11-supply = <_io>;
- vcc12-supply = <_io>;
- vddio-supply = <_io>;
-
- regulators {
- vdd_cpu: DCDC_REG1 {
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <75>;
- regulator-max-microvolt = <135>;
- regulator-name = "vdd_arm";
- regulator-state-mem {
- regulator-off-in-suspend;
- };
- };
-
- vdd_gpu: DCDC_REG2 {
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <85>;
- regulator-max-microvolt = <125>;
- regulator-name = "vdd_gpu";
- regulator-state-mem {
- regulator-on-in-suspend;
- regulator-suspend-microvolt = <100>;
- };
- };
-
- vcc_ddr:
Re: [PATCH] ARM: dts: rockchip: remove rk3288 fennec board support
Hi Kever,
Am Dienstag, 20. August 2019, 12:03:52 CEST schrieb Kever Yang:
> Since there is no one using this board, remove it.
so just to elaborate a bit, I guess this board was internal to Rockchip,
never went to the market and therefore is obsolete without any users,
right?
Also we should remove the binding from
Documentation/devicetree/bindings/arm/rockchip.yaml as well
Heiko
> Signed-off-by: Kever Yang
> ---
>
> arch/arm/boot/dts/rk3288-fennec.dts | 347
> 1 file changed, 347 deletions(-)
> delete mode 100644 arch/arm/boot/dts/rk3288-fennec.dts
>
> diff --git a/arch/arm/boot/dts/rk3288-fennec.dts
> b/arch/arm/boot/dts/rk3288-fennec.dts
> deleted file mode 100644
> index 4847cf902a15..
> --- a/arch/arm/boot/dts/rk3288-fennec.dts
> +++ /dev/null
> @@ -1,347 +0,0 @@
> -// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> -
> -/dts-v1/;
> -
> -#include "rk3288.dtsi"
> -
> -/ {
> - model = "Rockchip RK3288 Fennec Board";
> - compatible = "rockchip,rk3288-fennec", "rockchip,rk3288";
> -
> - memory@0 {
> - reg = <0x0 0x0 0x0 0x8000>;
> - device_type = "memory";
> - };
> -
> - ext_gmac: external-gmac-clock {
> - compatible = "fixed-clock";
> - #clock-cells = <0>;
> - clock-frequency = <12500>;
> - clock-output-names = "ext_gmac";
> - };
> -
> - vcc_sys: vsys-regulator {
> - compatible = "regulator-fixed";
> - regulator-name = "vcc_sys";
> - regulator-min-microvolt = <500>;
> - regulator-max-microvolt = <500>;
> - regulator-always-on;
> - regulator-boot-on;
> - };
> -};
> -
> - {
> - cpu0-supply = <_cpu>;
> -};
> -
> - {
> - bus-width = <8>;
> - cap-mmc-highspeed;
> - non-removable;
> - pinctrl-names = "default";
> - pinctrl-0 = <_clk _cmd _pwr _bus8>;
> - status = "okay";
> -};
> -
> - {
> - assigned-clocks = < SCLK_MAC>;
> - assigned-clock-parents = <_gmac>;
> - clock_in_out = "input";
> - pinctrl-names = "default";
> - pinctrl-0 = <_pins>, <_rst>, <_pmeb>, <_int>;
> - phy-supply = <_lan>;
> - phy-mode = "rgmii";
> - snps,reset-active-low;
> - snps,reset-delays-us = <0 1 100>;
> - snps,reset-gpio = < RK_PB0 GPIO_ACTIVE_LOW>;
> - tx_delay = <0x30>;
> - rx_delay = <0x10>;
> - status = "okay";
> -};
> -
> - {
> - mali-supply = <_gpu>;
> - status = "okay";
> -};
> -
> - {
> - status = "okay";
> -};
> -
> - {
> - status = "okay";
> - clock-frequency = <40>;
> -
> - rk808: pmic@1b {
> - compatible = "rockchip,rk808";
> - reg = <0x1b>;
> - interrupt-parent = <>;
> - interrupts = ;
> - #clock-cells = <1>;
> - clock-output-names = "xin32k", "rk808-clkout2";
> - pinctrl-names = "default";
> - pinctrl-0 = <_int _pwroff>;
> - rockchip,system-power-controller;
> - wakeup-source;
> -
> - vcc1-supply = <_sys>;
> - vcc2-supply = <_sys>;
> - vcc3-supply = <_sys>;
> - vcc4-supply = <_sys>;
> - vcc6-supply = <_sys>;
> - vcc7-supply = <_sys>;
> - vcc8-supply = <_io>;
> - vcc9-supply = <_io>;
> - vcc10-supply = <_io>;
> - vcc11-supply = <_io>;
> - vcc12-supply = <_io>;
> - vddio-supply = <_io>;
> -
> - regulators {
> - vdd_cpu: DCDC_REG1 {
> - regulator-always-on;
> - regulator-boot-on;
> - regulator-min-microvolt = <75>;
> - regulator-max-microvolt = <135>;
> - regulator-name = "vdd_arm";
> - regulator-state-mem {
> - regulator-off-in-suspend;
> - };
> - };
> -
> - vdd_gpu: DCDC_REG2 {
> - regulator-always-on;
> - regulator-boot-on;
> - regulator-min-microvolt = <85>;
> - regulator-max-microvolt = <125>;
> - regulator-name = "vdd_gpu";
> - regulator-state-mem {
> - regulator-on-in-suspend;
> - regulator-suspend-microvolt = <100>;
> - };
> - };
> -
> - vcc_ddr: DCDC_REG3 {
> - regulator-always-on;
> - regulator-boot-on;
> - regulator-name = "vcc_ddr";
> - regulator-state-mem {
> -
[PATCH] ARM: dts: rockchip: remove rk3288 fennec board support
Since there is no one using this board, remove it.
Signed-off-by: Kever Yang
---
arch/arm/boot/dts/rk3288-fennec.dts | 347
1 file changed, 347 deletions(-)
delete mode 100644 arch/arm/boot/dts/rk3288-fennec.dts
diff --git a/arch/arm/boot/dts/rk3288-fennec.dts
b/arch/arm/boot/dts/rk3288-fennec.dts
deleted file mode 100644
index 4847cf902a15..
--- a/arch/arm/boot/dts/rk3288-fennec.dts
+++ /dev/null
@@ -1,347 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-
-/dts-v1/;
-
-#include "rk3288.dtsi"
-
-/ {
- model = "Rockchip RK3288 Fennec Board";
- compatible = "rockchip,rk3288-fennec", "rockchip,rk3288";
-
- memory@0 {
- reg = <0x0 0x0 0x0 0x8000>;
- device_type = "memory";
- };
-
- ext_gmac: external-gmac-clock {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <12500>;
- clock-output-names = "ext_gmac";
- };
-
- vcc_sys: vsys-regulator {
- compatible = "regulator-fixed";
- regulator-name = "vcc_sys";
- regulator-min-microvolt = <500>;
- regulator-max-microvolt = <500>;
- regulator-always-on;
- regulator-boot-on;
- };
-};
-
- {
- cpu0-supply = <_cpu>;
-};
-
- {
- bus-width = <8>;
- cap-mmc-highspeed;
- non-removable;
- pinctrl-names = "default";
- pinctrl-0 = <_clk _cmd _pwr _bus8>;
- status = "okay";
-};
-
- {
- assigned-clocks = < SCLK_MAC>;
- assigned-clock-parents = <_gmac>;
- clock_in_out = "input";
- pinctrl-names = "default";
- pinctrl-0 = <_pins>, <_rst>, <_pmeb>, <_int>;
- phy-supply = <_lan>;
- phy-mode = "rgmii";
- snps,reset-active-low;
- snps,reset-delays-us = <0 1 100>;
- snps,reset-gpio = < RK_PB0 GPIO_ACTIVE_LOW>;
- tx_delay = <0x30>;
- rx_delay = <0x10>;
- status = "okay";
-};
-
- {
- mali-supply = <_gpu>;
- status = "okay";
-};
-
- {
- status = "okay";
-};
-
- {
- status = "okay";
- clock-frequency = <40>;
-
- rk808: pmic@1b {
- compatible = "rockchip,rk808";
- reg = <0x1b>;
- interrupt-parent = <>;
- interrupts = ;
- #clock-cells = <1>;
- clock-output-names = "xin32k", "rk808-clkout2";
- pinctrl-names = "default";
- pinctrl-0 = <_int _pwroff>;
- rockchip,system-power-controller;
- wakeup-source;
-
- vcc1-supply = <_sys>;
- vcc2-supply = <_sys>;
- vcc3-supply = <_sys>;
- vcc4-supply = <_sys>;
- vcc6-supply = <_sys>;
- vcc7-supply = <_sys>;
- vcc8-supply = <_io>;
- vcc9-supply = <_io>;
- vcc10-supply = <_io>;
- vcc11-supply = <_io>;
- vcc12-supply = <_io>;
- vddio-supply = <_io>;
-
- regulators {
- vdd_cpu: DCDC_REG1 {
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <75>;
- regulator-max-microvolt = <135>;
- regulator-name = "vdd_arm";
- regulator-state-mem {
- regulator-off-in-suspend;
- };
- };
-
- vdd_gpu: DCDC_REG2 {
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <85>;
- regulator-max-microvolt = <125>;
- regulator-name = "vdd_gpu";
- regulator-state-mem {
- regulator-on-in-suspend;
- regulator-suspend-microvolt = <100>;
- };
- };
-
- vcc_ddr: DCDC_REG3 {
- regulator-always-on;
- regulator-boot-on;
- regulator-name = "vcc_ddr";
- regulator-state-mem {
- regulator-on-in-suspend;
- };
- };
-
- vcc_io: DCDC_REG4 {
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <330>;
- regulator-max-microvolt = <330>;
-
