[PATCH] ARM:net: an issue for k which is u32, never < 0
k is u32 which never < 0, need type cast, or cause issue. Signed-off-by: Chen Gang --- arch/arm/net/bpf_jit_32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 6828ef6..a0bd8a7 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c @@ -576,7 +576,7 @@ load_ind: /* x = ((*(frame + k)) & 0xf) << 2; */ ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL; /* the interpreter should deal with the negative K */ - if (k < 0) + if ((int)k < 0) return -1; /* offset in r1: we might have to take the slow path */ emit_mov_i(r_off, k, ctx); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
From: Chen Gang Date: Sun, 10 Mar 2013 10:15:54 +0800 > > k is u32 which never < 0, need type cast, or cause issue. > > Signed-off-by: Chen Gang Who will apply this, ARM folks or me? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
于 2013年03月11日 05:12, David Miller 写道: > From: Chen Gang > Date: Sun, 10 Mar 2013 10:15:54 +0800 > >> > >> > k is u32 which never < 0, need type cast, or cause issue. >> > >> > Signed-off-by: Chen Gang > Who will apply this, ARM folks or me? > > sorry I don't know, either. I get the mail addresses by ./scripts/get_maintainers.pl. it includes you. if no others reply within a week, I hope you can help to check and apply it. thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote: > From: Chen Gang > Date: Sun, 10 Mar 2013 10:15:54 +0800 > > > > > k is u32 which never < 0, need type cast, or cause issue. > > > > Signed-off-by: Chen Gang > > Who will apply this, ARM folks or me? I'm happy if you wish to take the patch: Acked-by: Russell King Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013/3/10 Chen Gang : > > k is u32 which never < 0, need type cast, or cause issue. > > Signed-off-by: Chen Gang > --- > arch/arm/net/bpf_jit_32.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c > index 6828ef6..a0bd8a7 100644 > --- a/arch/arm/net/bpf_jit_32.c > +++ b/arch/arm/net/bpf_jit_32.c > @@ -576,7 +576,7 @@ load_ind: > /* x = ((*(frame + k)) & 0xf) << 2; */ > ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL; > /* the interpreter should deal with the negative K */ > - if (k < 0) > + if ((int)k < 0) > return -1; > /* offset in r1: we might have to take the slow path > */ > emit_mov_i(r_off, k, ctx); > -- > 1.7.7.6 Acked-by: Mircea Gherzan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
于 2013年03月12日 00:47, Russell King - ARM Linux 写道: > On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote: >> > From: Chen Gang >> > Date: Sun, 10 Mar 2013 10:15:54 +0800 >> > >>> > > >>> > > k is u32 which never < 0, need type cast, or cause issue. >>> > > >>> > > Signed-off-by: Chen Gang >> > >> > Who will apply this, ARM folks or me? > I'm happy if you wish to take the patch: > > Acked-by: Russell King > > Thanks. > > thank you very much. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
于 2013年03月12日 00:54, Mircea Gherzan 写道: > 2013/3/10 Chen Gang : >> > >> > k is u32 which never < 0, need type cast, or cause issue. >> > >> > Signed-off-by: Chen Gang >> > --- >> > arch/arm/net/bpf_jit_32.c |2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c >> > index 6828ef6..a0bd8a7 100644 >> > --- a/arch/arm/net/bpf_jit_32.c >> > +++ b/arch/arm/net/bpf_jit_32.c >> > @@ -576,7 +576,7 @@ load_ind: >> > /* x = ((*(frame + k)) & 0xf) << 2; */ >> > ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL; >> > /* the interpreter should deal with the negative K >> > */ >> > - if (k < 0) >> > + if ((int)k < 0) >> > return -1; >> > /* offset in r1: we might have to take the slow >> > path */ >> > emit_mov_i(r_off, k, ctx); >> > -- >> > 1.7.7.6 > Acked-by: Mircea Gherzan > > thank you very much. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
From: Russell King - ARM Linux Date: Mon, 11 Mar 2013 16:47:41 + > On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote: >> From: Chen Gang >> Date: Sun, 10 Mar 2013 10:15:54 +0800 >> >> > >> > k is u32 which never < 0, need type cast, or cause issue. >> > >> > Signed-off-by: Chen Gang >> >> Who will apply this, ARM folks or me? > > I'm happy if you wish to take the patch: > > Acked-by: Russell King Great, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
