Re: [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement
On 2015-06-11 14:22, Sebastian Andrzej Siewior wrote: This was spotted by Fernando Lopez-Lezcano while he tried to compile a -RT kernel with this driver enabled. "make C=2" would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano Signed-off-by: Sebastian Andrzej Siewior --- sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..b0c3e0e56302 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(>ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), - sst_shim_write64(shim, SST_CSR, shim_regs->csr), + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): Don't you mean ';' and not ':'? + sst_shim_write64(shim, SST_CSR, shim_regs->csr); spin_unlock_irqrestore(>ipc_spin_lock, irq_flags); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement
This was spotted by Fernando Lopez-Lezcano while he tried to compile a -RT kernel with this driver enabled. "make C=2" would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano Signed-off-by: Sebastian Andrzej Siewior --- sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..b0c3e0e56302 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(>ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), - sst_shim_write64(shim, SST_CSR, shim_regs->csr), + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): + sst_shim_write64(shim, SST_CSR, shim_regs->csr); spin_unlock_irqrestore(>ipc_spin_lock, irq_flags); } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement
This was spotted by Fernando Lopez-Lezcano na...@ccrma.stanford.edu while he tried to compile a -RT kernel with this driver enabled. make C=2 would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano na...@ccrma.stanford.edu Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..b0c3e0e56302 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(ctx-ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs-imrx), - sst_shim_write64(shim, SST_CSR, shim_regs-csr), + sst_shim_write64(shim, SST_IMRX, shim_regs-imrx): + sst_shim_write64(shim, SST_CSR, shim_regs-csr); spin_unlock_irqrestore(ctx-ipc_spin_lock, irq_flags); } -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement
On 2015-06-11 14:22, Sebastian Andrzej Siewior wrote: This was spotted by Fernando Lopez-Lezcano na...@ccrma.stanford.edu while he tried to compile a -RT kernel with this driver enabled. make C=2 would also warn about this. This is is based on his patch. Reported-by: Fernando Lopez-Lezcano na...@ccrma.stanford.edu Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- sound/soc/intel/atom/sst/sst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index 96c2e420cce6..b0c3e0e56302 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, * initialize by FW or driver when firmware is loaded */ spin_lock_irqsave(ctx-ipc_spin_lock, irq_flags); - sst_shim_write64(shim, SST_IMRX, shim_regs-imrx), - sst_shim_write64(shim, SST_CSR, shim_regs-csr), + sst_shim_write64(shim, SST_IMRX, shim_regs-imrx): Don't you mean ';' and not ':'? + sst_shim_write64(shim, SST_CSR, shim_regs-csr); spin_unlock_irqrestore(ctx-ipc_spin_lock, irq_flags); } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
