[PATCH] ASoC: cygnus: fix for_each_child.cocci warnings
From: kernel test robot Function "for_each_available_child_of_node" should have of_node_put() before return around line 1352. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Sumera Priyadarsini Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- cygnus-ssp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/sound/soc/bcm/cygnus-ssp.c +++ b/sound/soc/bcm/cygnus-ssp.c @@ -1348,8 +1348,10 @@ static int cygnus_ssp_probe(struct platf &cygnus_ssp_dai[active_port_count]); /* negative is err, 0 is active and good, 1 is disabled */ - if (err < 0) + if (err < 0) { + of_node_put(child_node); return err; + } else if (!err) { dev_dbg(dev, "Activating DAI: %s\n", cygnus_ssp_dai[active_port_count].name);
Re: [PATCH] ASoC: cygnus: fix for_each_child.cocci warnings
On Sun, 28 Mar 2021 16:54:45 +0200 (CEST), Julia Lawall wrote: > Function "for_each_available_child_of_node" should have of_node_put() > before return around line 1352. > > Generated by: scripts/coccinelle/iterators/for_each_child.cocci Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cygnus: fix for_each_child.cocci warnings commit: aa320c7cd45647b75af2233430d36a8d154703d4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark