Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote: > > On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > > > Note that this isn't causing a warning upstream, presumably due to an > > > implicit inclusion that isn't present in the v4.4 kernel that you appear > > > to be using, or gets missed due to config differences. > > > Ok. Is this just an observation or are these reasons to not accept the > > change? > > An observation, you should already have a mail about it being applied. Ah ok! Thanks for pointing that out (and for reviewing/accepting the patch). cheers, grant
Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > Note that this isn't causing a warning upstream, presumably due to an > > implicit inclusion that isn't present in the v4.4 kernel that you appear > > to be using, or gets missed due to config differences. > Ok. Is this just an observation or are these reasons to not accept the > change? An observation, you should already have a mail about it being applied. signature.asc Description: PGP signature
Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
[resending as plain/text - sorry] On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote: > > > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: >> >> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: >> > Commit ca917f9fe1a0fab added use of usleep_range() but not >> > the corresponding "include ". The result is >> > with Chrome OS won't build because warnings are forced >> > to be errors: >> > mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: >> > error: implicit declaration of function 'usleep_range' >> > [-Werror,-Wimplicit-function-declaration] >> > usleep_range(1, 11000); >> > ^ >> >> Note that this isn't causing a warning upstream, presumably due to an >> implicit inclusion that isn't present in the v4.4 kernel that you appear >> to be using, or gets missed due to config differences. > > > Ok. Is this just an observation or are these reasons to not accept the change? > > cheers, > grant
Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: > Commit ca917f9fe1a0fab added use of usleep_range() but not > the corresponding "include ". The result is > with Chrome OS won't build because warnings are forced > to be errors: > mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: > error: implicit declaration of function 'usleep_range' > [-Werror,-Wimplicit-function-declaration] > usleep_range(1, 11000); > ^ Note that this isn't causing a warning upstream, presumably due to an implicit inclusion that isn't present in the v4.4 kernel that you appear to be using, or gets missed due to config differences. signature.asc Description: PGP signature
Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
Hi Grant, On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: > Commit ca917f9fe1a0fab added use of usleep_range() but not > the corresponding "include ". The result is > with Chrome OS won't build because warnings are forced > to be errors: > mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: > error: implicit declaration of function 'usleep_range' > [-Werror,-Wimplicit-function-declaration] > usleep_range(1, 11000); > ^ > > Including delay.h "fixes" this. > > Signed-off-by: Grant Grundler Reviewed-by: Benson Leung Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature
[PATCH] ASoC: max98373: usleep_range() needs include/delay.h
Commit ca917f9fe1a0fab added use of usleep_range() but not the corresponding "include ". The result is with Chrome OS won't build because warnings are forced to be errors: mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function 'usleep_range' [-Werror,-Wimplicit-function-declaration] usleep_range(1, 11000); ^ Including delay.h "fixes" this. Signed-off-by: Grant Grundler --- sound/soc/codecs/max98373.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index 92b7125ea169..1f97b2f7c851 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -2,6 +2,7 @@ // Copyright (c) 2017, Maxim Integrated #include +#include #include #include #include -- 2.19.0.rc2.392.g5ba43deb5a-goog
