Re: [PATCH] Add ENOSYS into sys_io_cancel
On Tue, Jul 12, 2005 at 11:49:47AM -0400, Wendy Cheng wrote: > Didn't realize the patch was sent to linux-kernel (that I don't > subscribe) instead of linux-aio - revised patch attached. Thanks for the > help Wendy Okay, applied. Thanks! -ben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add ENOSYS into sys_io_cancel
Benjamin LaHaise wrote: Also, please cc [EMAIL PROTECTED] on future aio patches. Didn't realize the patch was sent to linux-kernel (that I don't subscribe) instead of linux-aio - revised patch attached. Thanks for the help Wendy On Mon, Jul 11, 2005 at 03:06:52PM -0400, Wendy Cheng wrote: Note that other than few exceptions, most of the current filesystem and/or drivers do not have aio cancel specifically defined (kiob->ki_cancel field is mostly NULL). However, sys_io_cancel system call universally sets return code to -EGAIN. This gives applications a wrong impression that this call is implemented but just never works. We have customer inquires about this issue. Upload a trivial patch to address this confusion. Signed-off-by: S. Wendy Cheng <[EMAIL PROTECTED]> --- linux-2.6.12/fs/aio.c 2005-06-17 15:48:29.0 -0400 +++ linux/fs/aio.c 2005-07-12 11:26:08.503256160 -0400 @@ -1660,7 +1660,7 @@ asmlinkage long sys_io_cancel(aio_contex ret = -EFAULT; } } else - printk(KERN_DEBUG "iocb has no cancel operation\n"); + ret = -ENOSYS; put_ioctx(ctx);
Re: [PATCH] Add ENOSYS into sys_io_cancel
Benjamin LaHaise wrote: Also, please cc [EMAIL PROTECTED] on future aio patches. Didn't realize the patch was sent to linux-kernel (that I don't subscribe) instead of linux-aio - revised patch attached. Thanks for the help Wendy On Mon, Jul 11, 2005 at 03:06:52PM -0400, Wendy Cheng wrote: Note that other than few exceptions, most of the current filesystem and/or drivers do not have aio cancel specifically defined (kiob-ki_cancel field is mostly NULL). However, sys_io_cancel system call universally sets return code to -EGAIN. This gives applications a wrong impression that this call is implemented but just never works. We have customer inquires about this issue. Upload a trivial patch to address this confusion. Signed-off-by: S. Wendy Cheng [EMAIL PROTECTED] --- linux-2.6.12/fs/aio.c 2005-06-17 15:48:29.0 -0400 +++ linux/fs/aio.c 2005-07-12 11:26:08.503256160 -0400 @@ -1660,7 +1660,7 @@ asmlinkage long sys_io_cancel(aio_contex ret = -EFAULT; } } else - printk(KERN_DEBUG iocb has no cancel operation\n); + ret = -ENOSYS; put_ioctx(ctx);
Re: [PATCH] Add ENOSYS into sys_io_cancel
On Tue, Jul 12, 2005 at 11:49:47AM -0400, Wendy Cheng wrote: Didn't realize the patch was sent to linux-kernel (that I don't subscribe) instead of linux-aio - revised patch attached. Thanks for the help Wendy Okay, applied. Thanks! -ben - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add ENOSYS into sys_io_cancel
Hello Wendy,
Two things: your patch needs to be properly signed off on. Read
Documentation/SubmittingPatches for a description of what that entials.
Secondly, your patch adds whitespace on the end of the else. Aside
from that, the printk should be removed -- just replace it with the
ret = -ENOSYS.
Also, please cc [EMAIL PROTECTED] on future aio patches. Cheers,
-ben
On Mon, Jul 11, 2005 at 03:06:52PM -0400, Wendy Cheng wrote:
> Previously sent via private mail that doesn't seem to go thru - resend
> via office mailer.
>
> Note that other than few exceptions, most of the current filesystem
> and/or drivers do not have aio cancel specifically defined
> (kiob->ki_cancel field is mostly NULL). However, sys_io_cancel system
> call universally sets return code to -EGAIN. This gives applications a
> wrong impression that this call is implemented but just never works. We
> have customer inquires about this issue.
>
> Upload a trivial patch to address this confusion.
>
> -- Wendy
>
>
> --- linux-2.6.12/fs/aio.c 2005-06-17 15:48:29.0 -0400
> +++ linux/fs/aio.c2005-07-10 12:48:14.0 -0400
> @@ -1641,8 +1641,9 @@ asmlinkage long sys_io_cancel(aio_contex
> cancel = kiocb->ki_cancel;
> kiocb->ki_users ++;
> kiocbSetCancelled(kiocb);
> - } else
> + } else
> cancel = NULL;
> +
> spin_unlock_irq(>ctx_lock);
>
> if (NULL != cancel) {
> @@ -1659,8 +1660,10 @@ asmlinkage long sys_io_cancel(aio_contex
> if (copy_to_user(result, , sizeof(tmp)))
> ret = -EFAULT;
> }
> - } else
> + } else {
> + ret = -ENOSYS;
> printk(KERN_DEBUG "iocb has no cancel operation\n");
> + }
>
> put_ioctx(ctx);
>
--
"Time is what keeps everything from happening all at once." -- John Wheeler
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Add ENOSYS into sys_io_cancel
Previously sent via private mail that doesn't seem to go thru - resend
via office mailer.
Note that other than few exceptions, most of the current filesystem
and/or drivers do not have aio cancel specifically defined
(kiob->ki_cancel field is mostly NULL). However, sys_io_cancel system
call universally sets return code to -EGAIN. This gives applications a
wrong impression that this call is implemented but just never works. We
have customer inquires about this issue.
Upload a trivial patch to address this confusion.
-- Wendy
--- linux-2.6.12/fs/aio.c 2005-06-17 15:48:29.0 -0400
+++ linux/fs/aio.c 2005-07-10 12:48:14.0 -0400
@@ -1641,8 +1641,9 @@ asmlinkage long sys_io_cancel(aio_contex
cancel = kiocb->ki_cancel;
kiocb->ki_users ++;
kiocbSetCancelled(kiocb);
- } else
+ } else
cancel = NULL;
+
spin_unlock_irq(>ctx_lock);
if (NULL != cancel) {
@@ -1659,8 +1660,10 @@ asmlinkage long sys_io_cancel(aio_contex
if (copy_to_user(result, , sizeof(tmp)))
ret = -EFAULT;
}
- } else
+ } else {
+ ret = -ENOSYS;
printk(KERN_DEBUG "iocb has no cancel operation\n");
+ }
put_ioctx(ctx);
[PATCH] Add ENOSYS into sys_io_cancel
Previously sent via private mail that doesn't seem to go thru - resend
via office mailer.
Note that other than few exceptions, most of the current filesystem
and/or drivers do not have aio cancel specifically defined
(kiob-ki_cancel field is mostly NULL). However, sys_io_cancel system
call universally sets return code to -EGAIN. This gives applications a
wrong impression that this call is implemented but just never works. We
have customer inquires about this issue.
Upload a trivial patch to address this confusion.
-- Wendy
--- linux-2.6.12/fs/aio.c 2005-06-17 15:48:29.0 -0400
+++ linux/fs/aio.c 2005-07-10 12:48:14.0 -0400
@@ -1641,8 +1641,9 @@ asmlinkage long sys_io_cancel(aio_contex
cancel = kiocb-ki_cancel;
kiocb-ki_users ++;
kiocbSetCancelled(kiocb);
- } else
+ } else
cancel = NULL;
+
spin_unlock_irq(ctx-ctx_lock);
if (NULL != cancel) {
@@ -1659,8 +1660,10 @@ asmlinkage long sys_io_cancel(aio_contex
if (copy_to_user(result, tmp, sizeof(tmp)))
ret = -EFAULT;
}
- } else
+ } else {
+ ret = -ENOSYS;
printk(KERN_DEBUG iocb has no cancel operation\n);
+ }
put_ioctx(ctx);
Re: [PATCH] Add ENOSYS into sys_io_cancel
Hello Wendy,
Two things: your patch needs to be properly signed off on. Read
Documentation/SubmittingPatches for a description of what that entials.
Secondly, your patch adds whitespace on the end of the else. Aside
from that, the printk should be removed -- just replace it with the
ret = -ENOSYS.
Also, please cc [EMAIL PROTECTED] on future aio patches. Cheers,
-ben
On Mon, Jul 11, 2005 at 03:06:52PM -0400, Wendy Cheng wrote:
Previously sent via private mail that doesn't seem to go thru - resend
via office mailer.
Note that other than few exceptions, most of the current filesystem
and/or drivers do not have aio cancel specifically defined
(kiob-ki_cancel field is mostly NULL). However, sys_io_cancel system
call universally sets return code to -EGAIN. This gives applications a
wrong impression that this call is implemented but just never works. We
have customer inquires about this issue.
Upload a trivial patch to address this confusion.
-- Wendy
--- linux-2.6.12/fs/aio.c 2005-06-17 15:48:29.0 -0400
+++ linux/fs/aio.c2005-07-10 12:48:14.0 -0400
@@ -1641,8 +1641,9 @@ asmlinkage long sys_io_cancel(aio_contex
cancel = kiocb-ki_cancel;
kiocb-ki_users ++;
kiocbSetCancelled(kiocb);
- } else
+ } else
cancel = NULL;
+
spin_unlock_irq(ctx-ctx_lock);
if (NULL != cancel) {
@@ -1659,8 +1660,10 @@ asmlinkage long sys_io_cancel(aio_contex
if (copy_to_user(result, tmp, sizeof(tmp)))
ret = -EFAULT;
}
- } else
+ } else {
+ ret = -ENOSYS;
printk(KERN_DEBUG iocb has no cancel operation\n);
+ }
put_ioctx(ctx);
--
Time is what keeps everything from happening all at once. -- John Wheeler
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Add ENOSYS into sys_io_cancel
Other than few exceptions (e.g. usb/gadget), none of the current filesystems and/or drivers that has io_cancel implemented (kiocb->ki_cancel left with NULL). However, the io_cancel() system call (sys_io_cancel) somehow universally sets return code to -EAGAIN. This gives us a false impression that io_cancel() is supported (implemented) but just never works - would appreciate if this patch is taken. -- s.w. __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com cancel.patch Description: 3748003194-cancel.patch
[PATCH] Add ENOSYS into sys_io_cancel
Other than few exceptions (e.g. usb/gadget), none of the current filesystems and/or drivers that has io_cancel implemented (kiocb-ki_cancel left with NULL). However, the io_cancel() system call (sys_io_cancel) somehow universally sets return code to -EAGAIN. This gives us a false impression that io_cancel() is supported (implemented) but just never works - would appreciate if this patch is taken. -- s.w. __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com cancel.patch Description: 3748003194-cancel.patch
