Re: [PATCH] Btrfs: fix fspath error deallocation

2016-05-10 Thread David Sterba
On Tue, May 10, 2016 at 02:56:20PM +0200, Vincent Stehlé wrote:
> Make sure to deallocate fspath with vfree() in case of error in
> init_ipath().
> 
> fspath is allocated with vmalloc() in init_data_container() since
> commit 425d17a290c0 ("Btrfs: use larger limit for translation of logical to
> inode").
> 
> Signed-off-by: Vincent Stehlé 
> Cc: Chris Mason 
> Cc: Josef Bacik 
> Cc: David Sterba 

Reviewed-by: David Sterba 


[PATCH] Btrfs: fix fspath error deallocation

2016-05-10 Thread Vincent Stehlé
Make sure to deallocate fspath with vfree() in case of error in
init_ipath().

fspath is allocated with vmalloc() in init_data_container() since
commit 425d17a290c0 ("Btrfs: use larger limit for translation of logical to
inode").

Signed-off-by: Vincent Stehlé 
Cc: Chris Mason 
Cc: Josef Bacik 
Cc: David Sterba 
---
 fs/btrfs/backref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 80e8472..d309018 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1991,7 +1991,7 @@ struct inode_fs_paths *init_ipath(s32 total_bytes, struct 
btrfs_root *fs_root,
 
ifp = kmalloc(sizeof(*ifp), GFP_NOFS);
if (!ifp) {
-   kfree(fspath);
+   vfree(fspath);
return ERR_PTR(-ENOMEM);
}
 
-- 
2.8.0.rc3