Re: [PATCH] Configure out DMI scanning code v2 (Linux Tiny)

2008-02-17 Thread Ingo Molnar 

* Andrew Morton <[EMAIL PROTECTED]> wrote:

> On Tue, 12 Feb 2008 12:56:45 -0600
> Matt Mackall <[EMAIL PROTECTED]> wrote:
> 
> > 
> > On Tue, 2008-02-12 at 10:04 +0100, Thomas Petazzoni wrote:
> > 
> > > Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in
> > > order to be able to remove the DMI table scanning code if it's not
> > > needed, and then reduce the kernel code size.
> > > 
> > > With CONFIG_DMI (i.e before) :
> > > 
> > >textdata bss dec hex filename
> > > 1076076  128656   98304 1303036  13e1fc vmlinux
> > > 
> > > Without CONFIG_DMI (i.e after) :
> > > 
> > >textdata bss dec hex filename
> > > 1068092  126308   98304 1292704  13b9a0 vmlinux
> > > 
> > > Result:
> > > 
> > >textdata bss dec hex filename
> > >   -7984   -2348   0  -10332   -285c vmlinux
> > > 
> > > The new option appears in "Processor type and features", only when
> > > CONFIG_EMBEDDED is defined.
> 
> Given this:
> 
> > > This patch is part of the Linux Tiny project, and is based on previous
> > > work done by Matt Mackall <[EMAIL PROTECTED]>.
> 
> 
> > Acked-by: Matt Mackall <[EMAIL PROTECTED]>
> 
> That should have been "Signed-off-by:".  I'll speculatively make that 
> change.

for the x86 bits:

Acked-by: Ingo Molnar <[EMAIL PROTECTED]>

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Configure out DMI scanning code v2 (Linux Tiny)

2008-02-12 Thread Andrew Morton 
On Tue, 12 Feb 2008 12:56:45 -0600
Matt Mackall <[EMAIL PROTECTED]> wrote:

> 
> On Tue, 2008-02-12 at 10:04 +0100, Thomas Petazzoni wrote:
> 
> > Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in
> > order to be able to remove the DMI table scanning code if it's not
> > needed, and then reduce the kernel code size.
> > 
> > With CONFIG_DMI (i.e before) :
> > 
> >textdata bss dec hex filename
> > 1076076  128656   98304 1303036  13e1fc vmlinux
> > 
> > Without CONFIG_DMI (i.e after) :
> > 
> >textdata bss dec hex filename
> > 1068092  126308   98304 1292704  13b9a0 vmlinux
> > 
> > Result:
> > 
> >textdata bss dec hex filename
> >   -7984   -2348   0  -10332   -285c vmlinux
> > 
> > The new option appears in "Processor type and features", only when
> > CONFIG_EMBEDDED is defined.

Given this:

> > This patch is part of the Linux Tiny project, and is based on previous
> > work done by Matt Mackall <[EMAIL PROTECTED]>.


> Acked-by: Matt Mackall <[EMAIL PROTECTED]>

That should have been "Signed-off-by:".  I'll speculatively make that
change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Configure out DMI scanning code v2 (Linux Tiny)

2008-02-12 Thread Matt Mackall 

On Tue, 2008-02-12 at 10:04 +0100, Thomas Petazzoni wrote:

> Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in
> order to be able to remove the DMI table scanning code if it's not
> needed, and then reduce the kernel code size.
> 
> With CONFIG_DMI (i.e before) :
> 
>textdata bss dec hex filename
> 1076076  128656   98304 1303036  13e1fc vmlinux
> 
> Without CONFIG_DMI (i.e after) :
> 
>textdata bss dec hex filename
> 1068092  126308   98304 1292704  13b9a0 vmlinux
> 
> Result:
> 
>textdata bss dec hex filename
>   -7984   -2348   0  -10332   -285c vmlinux
> 
> The new option appears in "Processor type and features", only when
> CONFIG_EMBEDDED is defined.
> 
> This patch is part of the Linux Tiny project, and is based on previous
> work done by Matt Mackall <[EMAIL PROTECTED]>.
> 
> Signed-off-by: Thomas Petazzoni <[EMAIL PROTECTED]>

Thanks for working on this.

Acked-by: Matt Mackall <[EMAIL PROTECTED]>

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] Configure out DMI scanning code v2 (Linux Tiny)

2008-02-12 Thread Thomas Petazzoni 
Hi,

Enclosed patch is an updated version, with proper credits to Matt
Mackall and the Linux Tiny project.

Sincerly,

Thomas

---

Turn CONFIG_DMI into a selectable option if EMBEDDED is defined, in
order to be able to remove the DMI table scanning code if it's not
needed, and then reduce the kernel code size.

With CONFIG_DMI (i.e before) :

   textdata bss dec hex filename
1076076  128656   98304 1303036  13e1fc vmlinux

Without CONFIG_DMI (i.e after) :

   textdata bss dec hex filename
1068092  126308   98304 1292704  13b9a0 vmlinux

Result:

   textdata bss dec hex filename
  -7984   -2348   0  -10332   -285c vmlinux

The new option appears in "Processor type and features", only when
CONFIG_EMBEDDED is defined.

This patch is part of the Linux Tiny project, and is based on previous
work done by Matt Mackall <[EMAIL PROTECTED]>.

Signed-off-by: Thomas Petazzoni <[EMAIL PROTECTED]>

---
 arch/x86/Kconfig|   12 +---
 include/linux/dmi.h |1 +
 2 files changed, 10 insertions(+), 3 deletions(-)

Index: linux/arch/x86/Kconfig
===
--- linux.orig/arch/x86/Kconfig 2008-02-11 16:51:50.0 +0100
+++ linux/arch/x86/Kconfig  2008-02-11 17:48:15.0 +0100
@@ -88,9 +88,6 @@
 config ARCH_MAY_HAVE_PC_FDC
def_bool y
 
-config DMI
-   def_bool y
-
 config RWSEM_GENERIC_SPINLOCK
def_bool !X86_XADD
 
@@ -433,6 +430,15 @@
 
 # Mark as embedded because too many people got it wrong.
 # The code disables itself when not needed.
+config DMI
+   default y
+   bool "Enable DMI scanning" if EMBEDDED
+   help
+ Enabled scanning of DMI to identify machine quirks. Say Y
+ here unless you have verified that your setup is not
+ affected by entries in the DMI blacklist. Required by PNP
+ BIOS code.
+
 config GART_IOMMU
bool "GART IOMMU support" if EMBEDDED
default y
Index: linux/include/linux/dmi.h
===
--- linux.orig/include/linux/dmi.h  2008-02-11 16:51:30.0 +0100
+++ linux/include/linux/dmi.h   2008-02-11 17:40:31.0 +0100
@@ -90,6 +90,7 @@
 static inline const char * dmi_get_system_info(int field) { return NULL; }
 static inline const struct dmi_device * dmi_find_device(int type, const char 
*name,
const struct dmi_device *from) { return NULL; }
+static inline void dmi_scan_machine(void) { return; }
 static inline int dmi_get_year(int year) { return 0; }
 static inline int dmi_name_in_vendors(const char *s) { return 0; }
 #define dmi_available 0


-- 
Thomas Petazzoni, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)


signature.asc
Description: PGP signature