Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
Bartlomiej Zolnierkiewicz writes: > Hi, > > On Friday, June 28, 2013 09:37:36 AM Olof Johansson wrote: >> Bartlomiej, >> >> Did you build test on the platforms you changed? You broke dove_defconfig: >> >> In file included from /home/olof/work/next/include/linux/skbuff.h:31:0, >> from /home/olof/work/next/include/linux/if_ether.h:23, >> from /home/olof/work/next/include/net/dsa.h:14, >> from /home/olof/work/next/arch/arm/plat-orion/common.c:21: >> /home/olof/work/next/arch/arm/plat-orion/common.c: In function >> 'orion_xor1_init': >> /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: error: >> 'DMA_MEMSET' undeclared (first use in this function) >> dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); >> ^ >> /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in >> definition of macro 'dma_cap_set' >> #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask)) >> ^ >> /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: note: each >> undeclared identifier is reported only once for each function it >> appears in >> dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); >> ^ >> /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in >> definition of macro 'dma_cap_set' >> #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask)) >> >> >> This would also have been found by a "git grep DMA_MEMSET" across the tree. >> >> Andrew, this is coming really late before the merge window, I think it >> makes sense to hold off to 3.12 if it can't be done without trivial >> regressions. :( > > Sorry for that. This is an old patch that I ported to current kernels. > I fixed rejects and verified that it compiles for cases that hit rejects > but unfortunately I forgot to check for new code related to DMA_MEMSET > functionality. Fortunately it seems that the problematic places are in > plat-orion/common.c and mv_xor.c. They are fixed in the attached patch. I just verified that v2 builds now on ARM dove_defconfig and kirkwood_defconfig (those were 2 that I noticed were broken by this change.) Hopefully Andrew can pick up v2. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
Hi,
On Friday, June 28, 2013 09:37:36 AM Olof Johansson wrote:
> Bartlomiej,
>
> Did you build test on the platforms you changed? You broke dove_defconfig:
>
> In file included from /home/olof/work/next/include/linux/skbuff.h:31:0,
> from /home/olof/work/next/include/linux/if_ether.h:23,
> from /home/olof/work/next/include/net/dsa.h:14,
> from /home/olof/work/next/arch/arm/plat-orion/common.c:21:
> /home/olof/work/next/arch/arm/plat-orion/common.c: In function
> 'orion_xor1_init':
> /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: error:
> 'DMA_MEMSET' undeclared (first use in this function)
> dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask);
> ^
> /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in
> definition of macro 'dma_cap_set'
> #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask))
> ^
> /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: note: each
> undeclared identifier is reported only once for each function it
> appears in
> dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask);
> ^
> /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in
> definition of macro 'dma_cap_set'
> #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask))
>
>
> This would also have been found by a "git grep DMA_MEMSET" across the tree.
>
> Andrew, this is coming really late before the merge window, I think it
> makes sense to hold off to 3.12 if it can't be done without trivial
> regressions. :(
Sorry for that. This is an old patch that I ported to current kernels.
I fixed rejects and verified that it compiles for cases that hit rejects
but unfortunately I forgot to check for new code related to DMA_MEMSET
functionality. Fortunately it seems that the problematic places are in
plat-orion/common.c and mv_xor.c. They are fixed in the attached patch.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
> -Olof
>
> On Thu, Jun 27, 2013 at 1:20 PM, Dan Williams wrote:
> > On Wed, Jun 26, 2013 at 6:31 AM, Bartlomiej Zolnierkiewicz
> > wrote:
> >> There have never been any real users of MEMSET operations
> >> since they have been introduced in January 2007 (commit
> >> 7405f74badf46b5d023c5d2b670b4471525f6c91 "dmaengine: refactor
> >> dmaengine around dma_async_tx_descriptor"). Therefore remove
> >> support for them for now, it can be always brought back when
> >> needed.
> >>
> >> Cc: Vinod Koul
> >> Cc: Dan Williams
> >> Cc: Tomasz Figa
> >> Cc: Andrew Morton
> >> Signed-off-by: Bartlomiej Zolnierkiewicz
> >> Signed-off-by: Kyungmin Park
> >> ---
> >
> > I see Andrew has already picked this up.
> >
> > Acked-by: Dan Williams
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
From: Bartlomiej Zolnierkiewicz
Subject: [PATCH v2] DMA: remove unused support for MEMSET operations
There have never been any real users of MEMSET operations since they have
been introduced in January 2007 by 7405f74badf4 ("dmaengine: refactor
dmaengine around dma_async_tx_descriptor"). Therefore remove support for
them for now, it can be always brought back when needed.
Acked-by: Dan Williams
Cc: Vinod Koul
Cc: Tomasz Figa
Cc: Andrew Morton
Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: Kyungmin Park
---
v2:
- fixed build problems noticed by Olof
- added Dan's Ack
v1:
- synced against next-20130626
previous submissions:
https://lkml.org/lkml/2012/12/5/116
https://lkml.org/lkml/2012/11/8/107
Documentation/crypto/async-tx-api.txt |1
arch/arm/mach-iop13xx/setup.c |3
arch/arm/plat-iop/adma.c |2
arch/arm/plat-orion/common.c | 10 --
crypto/async_tx/Kconfig |4 -
crypto/async_tx/Makefile |1
crypto/async_tx/async_memset.c| 89 --
drivers/dma/dmaengine.c |7 --
drivers/dma/ioat/dma.c|3
drivers/dma/ioat/dma_v2.h |1
drivers/dma/ioat/dma_v3.c | 114 --
drivers/dma/ioat/hw.h | 27
drivers/dma/iop-adma.c| 66 ---
drivers/dma/mv_xor.c | 62 --
drivers/dma/mv_xor.h |1
drivers/dma/ppc4xx/adma.c
Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
Bartlomiej, Did you build test on the platforms you changed? You broke dove_defconfig: In file included from /home/olof/work/next/include/linux/skbuff.h:31:0, from /home/olof/work/next/include/linux/if_ether.h:23, from /home/olof/work/next/include/net/dsa.h:14, from /home/olof/work/next/arch/arm/plat-orion/common.c:21: /home/olof/work/next/arch/arm/plat-orion/common.c: In function 'orion_xor1_init': /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: error: 'DMA_MEMSET' undeclared (first use in this function) dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask)) ^ /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: note: each undeclared identifier is reported only once for each function it appears in dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask)) This would also have been found by a "git grep DMA_MEMSET" across the tree. Andrew, this is coming really late before the merge window, I think it makes sense to hold off to 3.12 if it can't be done without trivial regressions. :( -Olof On Thu, Jun 27, 2013 at 1:20 PM, Dan Williams wrote: > On Wed, Jun 26, 2013 at 6:31 AM, Bartlomiej Zolnierkiewicz > wrote: >> There have never been any real users of MEMSET operations >> since they have been introduced in January 2007 (commit >> 7405f74badf46b5d023c5d2b670b4471525f6c91 "dmaengine: refactor >> dmaengine around dma_async_tx_descriptor"). Therefore remove >> support for them for now, it can be always brought back when >> needed. >> >> Cc: Vinod Koul >> Cc: Dan Williams >> Cc: Tomasz Figa >> Cc: Andrew Morton >> Signed-off-by: Bartlomiej Zolnierkiewicz >> Signed-off-by: Kyungmin Park >> --- > > I see Andrew has already picked this up. > > Acked-by: Dan Williams > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
Bartlomiej, Did you build test on the platforms you changed? You broke dove_defconfig: In file included from /home/olof/work/next/include/linux/skbuff.h:31:0, from /home/olof/work/next/include/linux/if_ether.h:23, from /home/olof/work/next/include/net/dsa.h:14, from /home/olof/work/next/arch/arm/plat-orion/common.c:21: /home/olof/work/next/arch/arm/plat-orion/common.c: In function 'orion_xor1_init': /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: error: 'DMA_MEMSET' undeclared (first use in this function) dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), (mask)) ^ /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: note: each undeclared identifier is reported only once for each function it appears in dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), (mask)) This would also have been found by a git grep DMA_MEMSET across the tree. Andrew, this is coming really late before the merge window, I think it makes sense to hold off to 3.12 if it can't be done without trivial regressions. :( -Olof On Thu, Jun 27, 2013 at 1:20 PM, Dan Williams d...@fb.com wrote: On Wed, Jun 26, 2013 at 6:31 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 dmaengine: refactor dmaengine around dma_async_tx_descriptor). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc: Tomasz Figa t.f...@samsung.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- I see Andrew has already picked this up. Acked-by: Dan Williams d...@fb.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
Hi, On Friday, June 28, 2013 09:37:36 AM Olof Johansson wrote: Bartlomiej, Did you build test on the platforms you changed? You broke dove_defconfig: In file included from /home/olof/work/next/include/linux/skbuff.h:31:0, from /home/olof/work/next/include/linux/if_ether.h:23, from /home/olof/work/next/include/net/dsa.h:14, from /home/olof/work/next/arch/arm/plat-orion/common.c:21: /home/olof/work/next/arch/arm/plat-orion/common.c: In function 'orion_xor1_init': /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: error: 'DMA_MEMSET' undeclared (first use in this function) dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), (mask)) ^ /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: note: each undeclared identifier is reported only once for each function it appears in dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), (mask)) This would also have been found by a git grep DMA_MEMSET across the tree. Andrew, this is coming really late before the merge window, I think it makes sense to hold off to 3.12 if it can't be done without trivial regressions. :( Sorry for that. This is an old patch that I ported to current kernels. I fixed rejects and verified that it compiles for cases that hit rejects but unfortunately I forgot to check for new code related to DMA_MEMSET functionality. Fortunately it seems that the problematic places are in plat-orion/common.c and mv_xor.c. They are fixed in the attached patch. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -Olof On Thu, Jun 27, 2013 at 1:20 PM, Dan Williams d...@fb.com wrote: On Wed, Jun 26, 2013 at 6:31 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 dmaengine: refactor dmaengine around dma_async_tx_descriptor). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc: Tomasz Figa t.f...@samsung.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- I see Andrew has already picked this up. Acked-by: Dan Williams d...@fb.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH v2] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations since they have been introduced in January 2007 by 7405f74badf4 (dmaengine: refactor dmaengine around dma_async_tx_descriptor). Therefore remove support for them for now, it can be always brought back when needed. Acked-by: Dan Williams d...@fb.com Cc: Vinod Koul vinod.k...@intel.com Cc: Tomasz Figa t.f...@samsung.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- v2: - fixed build problems noticed by Olof - added Dan's Ack v1: - synced against next-20130626 previous submissions: https://lkml.org/lkml/2012/12/5/116 https://lkml.org/lkml/2012/11/8/107 Documentation/crypto/async-tx-api.txt |1 arch/arm/mach-iop13xx/setup.c |3 arch/arm/plat-iop/adma.c |2 arch/arm/plat-orion/common.c | 10 -- crypto/async_tx/Kconfig |4 - crypto/async_tx/Makefile |1 crypto/async_tx/async_memset.c| 89 -- drivers/dma/dmaengine.c |7 -- drivers/dma/ioat/dma.c|3 drivers/dma/ioat/dma_v2.h |1 drivers/dma/ioat/dma_v3.c | 114 -- drivers/dma/ioat/hw.h | 27 drivers/dma/iop-adma.c| 66 --- drivers/dma/mv_xor.c | 62 -- drivers/dma/mv_xor.h |1 drivers/dma/ppc4xx/adma.c | 47 -- include/linux/async_tx.h |4 - include/linux/dmaengine.h |5 - 18 files changed
Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com writes: Hi, On Friday, June 28, 2013 09:37:36 AM Olof Johansson wrote: Bartlomiej, Did you build test on the platforms you changed? You broke dove_defconfig: In file included from /home/olof/work/next/include/linux/skbuff.h:31:0, from /home/olof/work/next/include/linux/if_ether.h:23, from /home/olof/work/next/include/net/dsa.h:14, from /home/olof/work/next/arch/arm/plat-orion/common.c:21: /home/olof/work/next/arch/arm/plat-orion/common.c: In function 'orion_xor1_init': /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: error: 'DMA_MEMSET' undeclared (first use in this function) dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), (mask)) ^ /home/olof/work/next/arch/arm/plat-orion/common.c:737:14: note: each undeclared identifier is reported only once for each function it appears in dma_cap_set(DMA_MEMSET, orion_xor1_channels_data[1].cap_mask); ^ /home/olof/work/next/include/linux/dmaengine.h:862:46: note: in definition of macro 'dma_cap_set' #define dma_cap_set(tx, mask) __dma_cap_set((tx), (mask)) This would also have been found by a git grep DMA_MEMSET across the tree. Andrew, this is coming really late before the merge window, I think it makes sense to hold off to 3.12 if it can't be done without trivial regressions. :( Sorry for that. This is an old patch that I ported to current kernels. I fixed rejects and verified that it compiles for cases that hit rejects but unfortunately I forgot to check for new code related to DMA_MEMSET functionality. Fortunately it seems that the problematic places are in plat-orion/common.c and mv_xor.c. They are fixed in the attached patch. I just verified that v2 builds now on ARM dove_defconfig and kirkwood_defconfig (those were 2 that I noticed were broken by this change.) Hopefully Andrew can pick up v2. Thanks, Kevin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
On Wed, Jun 26, 2013 at 6:31 AM, Bartlomiej Zolnierkiewicz wrote: > There have never been any real users of MEMSET operations > since they have been introduced in January 2007 (commit > 7405f74badf46b5d023c5d2b670b4471525f6c91 "dmaengine: refactor > dmaengine around dma_async_tx_descriptor"). Therefore remove > support for them for now, it can be always brought back when > needed. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Tomasz Figa > Cc: Andrew Morton > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- I see Andrew has already picked this up. Acked-by: Dan Williams -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [resend2 PATCH] DMA: remove unused support for MEMSET operations
On Wed, Jun 26, 2013 at 6:31 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 dmaengine: refactor dmaengine around dma_async_tx_descriptor). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc: Tomasz Figa t.f...@samsung.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- I see Andrew has already picked this up. Acked-by: Dan Williams d...@fb.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[resend2 PATCH] DMA: remove unused support for MEMSET operations
There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 "dmaengine: refactor dmaengine around dma_async_tx_descriptor"). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul Cc: Dan Williams Cc: Tomasz Figa Cc: Andrew Morton Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- synced against next-20130626 previous submissions: https://lkml.org/lkml/2012/12/5/116 https://lkml.org/lkml/2012/11/8/107 Documentation/crypto/async-tx-api.txt |1 arch/arm/mach-iop13xx/setup.c |3 arch/arm/plat-iop/adma.c |2 arch/arm/plat-orion/common.c |5 - crypto/async_tx/Kconfig |4 - crypto/async_tx/Makefile |1 crypto/async_tx/async_memset.c| 89 -- drivers/dma/dmaengine.c |7 -- drivers/dma/ioat/dma.c|3 drivers/dma/ioat/dma_v2.h |1 drivers/dma/ioat/dma_v3.c | 114 -- drivers/dma/ioat/hw.h | 27 drivers/dma/iop-adma.c| 66 --- drivers/dma/mv_xor.c | 60 - drivers/dma/mv_xor.h |1 drivers/dma/ppc4xx/adma.c | 47 -- include/linux/async_tx.h |4 - include/linux/dmaengine.h |5 - 18 files changed, 7 insertions(+), 433 deletions(-) Index: b/Documentation/crypto/async-tx-api.txt === --- a/Documentation/crypto/async-tx-api.txt 2013-06-26 15:13:12.302205826 +0200 +++ b/Documentation/crypto/async-tx-api.txt 2013-06-26 15:18:33.426205184 +0200 @@ -222,5 +222,4 @@ drivers/dma/: location for offload engin include/linux/async_tx.h: core header file for the async_tx api crypto/async_tx/async_tx.c: async_tx interface to dmaengine and common code crypto/async_tx/async_memcpy.c: copy offload -crypto/async_tx/async_memset.c: memory fill offload crypto/async_tx/async_xor.c: xor and xor zero sum offload Index: b/arch/arm/mach-iop13xx/setup.c === --- a/arch/arm/mach-iop13xx/setup.c 2013-06-26 15:13:12.434205826 +0200 +++ b/arch/arm/mach-iop13xx/setup.c 2013-06-26 15:18:33.426205184 +0200 @@ -469,7 +469,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data->cap_mask); dma_cap_set(DMA_XOR, plat_data->cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data->cap_mask); - dma_cap_set(DMA_MEMSET, plat_data->cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data->cap_mask); break; case IOP13XX_INIT_ADMA_1: @@ -479,7 +478,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data->cap_mask); dma_cap_set(DMA_XOR, plat_data->cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data->cap_mask); - dma_cap_set(DMA_MEMSET, plat_data->cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data->cap_mask); break; case IOP13XX_INIT_ADMA_2: @@ -489,7 +487,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data->cap_mask); dma_cap_set(DMA_XOR, plat_data->cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data->cap_mask); - dma_cap_set(DMA_MEMSET, plat_data->cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data->cap_mask); dma_cap_set(DMA_PQ, plat_data->cap_mask); dma_cap_set(DMA_PQ_VAL, plat_data->cap_mask); Index: b/arch/arm/plat-iop/adma.c === --- a/arch/arm/plat-iop/adma.c 2013-06-26 15:13:12.406205826 +0200 +++ b/arch/arm/plat-iop/adma.c 2013-06-26 15:18:33.426205184 +0200 @@ -192,12 +192,10 @@ static int __init iop3xx_adma_cap_init(v #ifdef CONFIG_ARCH_IOP32X /* the 32x AAU does not perform zero sum */ dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #else dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_XOR_VAL, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #endif Index: b/arch/arm/plat-orion/common.c === --- a/arch/arm/plat-orion/common.c
[resend2 PATCH] DMA: remove unused support for MEMSET operations
There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 dmaengine: refactor dmaengine around dma_async_tx_descriptor). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc: Tomasz Figa t.f...@samsung.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- synced against next-20130626 previous submissions: https://lkml.org/lkml/2012/12/5/116 https://lkml.org/lkml/2012/11/8/107 Documentation/crypto/async-tx-api.txt |1 arch/arm/mach-iop13xx/setup.c |3 arch/arm/plat-iop/adma.c |2 arch/arm/plat-orion/common.c |5 - crypto/async_tx/Kconfig |4 - crypto/async_tx/Makefile |1 crypto/async_tx/async_memset.c| 89 -- drivers/dma/dmaengine.c |7 -- drivers/dma/ioat/dma.c|3 drivers/dma/ioat/dma_v2.h |1 drivers/dma/ioat/dma_v3.c | 114 -- drivers/dma/ioat/hw.h | 27 drivers/dma/iop-adma.c| 66 --- drivers/dma/mv_xor.c | 60 - drivers/dma/mv_xor.h |1 drivers/dma/ppc4xx/adma.c | 47 -- include/linux/async_tx.h |4 - include/linux/dmaengine.h |5 - 18 files changed, 7 insertions(+), 433 deletions(-) Index: b/Documentation/crypto/async-tx-api.txt === --- a/Documentation/crypto/async-tx-api.txt 2013-06-26 15:13:12.302205826 +0200 +++ b/Documentation/crypto/async-tx-api.txt 2013-06-26 15:18:33.426205184 +0200 @@ -222,5 +222,4 @@ drivers/dma/: location for offload engin include/linux/async_tx.h: core header file for the async_tx api crypto/async_tx/async_tx.c: async_tx interface to dmaengine and common code crypto/async_tx/async_memcpy.c: copy offload -crypto/async_tx/async_memset.c: memory fill offload crypto/async_tx/async_xor.c: xor and xor zero sum offload Index: b/arch/arm/mach-iop13xx/setup.c === --- a/arch/arm/mach-iop13xx/setup.c 2013-06-26 15:13:12.434205826 +0200 +++ b/arch/arm/mach-iop13xx/setup.c 2013-06-26 15:18:33.426205184 +0200 @@ -469,7 +469,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data-cap_mask); dma_cap_set(DMA_XOR, plat_data-cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data-cap_mask); - dma_cap_set(DMA_MEMSET, plat_data-cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data-cap_mask); break; case IOP13XX_INIT_ADMA_1: @@ -479,7 +478,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data-cap_mask); dma_cap_set(DMA_XOR, plat_data-cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data-cap_mask); - dma_cap_set(DMA_MEMSET, plat_data-cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data-cap_mask); break; case IOP13XX_INIT_ADMA_2: @@ -489,7 +487,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data-cap_mask); dma_cap_set(DMA_XOR, plat_data-cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data-cap_mask); - dma_cap_set(DMA_MEMSET, plat_data-cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data-cap_mask); dma_cap_set(DMA_PQ, plat_data-cap_mask); dma_cap_set(DMA_PQ_VAL, plat_data-cap_mask); Index: b/arch/arm/plat-iop/adma.c === --- a/arch/arm/plat-iop/adma.c 2013-06-26 15:13:12.406205826 +0200 +++ b/arch/arm/plat-iop/adma.c 2013-06-26 15:18:33.426205184 +0200 @@ -192,12 +192,10 @@ static int __init iop3xx_adma_cap_init(v #ifdef CONFIG_ARCH_IOP32X /* the 32x AAU does not perform zero sum */ dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #else dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_XOR_VAL, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #endif Index: b/arch/arm/plat-orion/common.c
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thursday 08 November 2012 12:31:48 Alan Cox wrote: > On Thu, 08 Nov 2012 12:22:05 +0100 > Bartlomiej Zolnierkiewicz wrote: > > > On Thursday 08 November 2012 12:12:31 Alan Cox wrote: > > > On Thu, 08 Nov 2012 10:58:17 +0100 > > > Bartlomiej Zolnierkiewicz wrote: > > > > > > > From: Bartlomiej Zolnierkiewicz > > > > Subject: [PATCH] DMA: remove unused support for MEMSET operations > > > > > > > > There have never been any real users of MEMSET operations > > > > > > In tree users. > > > > Please show me them. > > Sorry ? There are potentially lots of out of tree users in both the ARM > and x86 communities. They had almost six years to submit their code to upstream and there is potentially no problem for these _out_of_tree_ users to maintain also memset code out of tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung Poland R Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thu, 08 Nov 2012 12:22:05 +0100 Bartlomiej Zolnierkiewicz wrote: > On Thursday 08 November 2012 12:12:31 Alan Cox wrote: > > On Thu, 08 Nov 2012 10:58:17 +0100 > > Bartlomiej Zolnierkiewicz wrote: > > > > > From: Bartlomiej Zolnierkiewicz > > > Subject: [PATCH] DMA: remove unused support for MEMSET operations > > > > > > There have never been any real users of MEMSET operations > > > > In tree users. > > Please show me them. Sorry ? There are potentially lots of out of tree users in both the ARM and x86 communities. > > And is it broken, if not why do you want to break it ? > > Well, it is partially broken as async_memset.c doesn't even built > currently in next (I've posted fix for that before noticing that > the whole code can be removed). Ok that does suggest it's not being used at all but it would be wise to check more widely. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thursday 08 November 2012 12:12:31 Alan Cox wrote: > On Thu, 08 Nov 2012 10:58:17 +0100 > Bartlomiej Zolnierkiewicz wrote: > > > From: Bartlomiej Zolnierkiewicz > > Subject: [PATCH] DMA: remove unused support for MEMSET operations > > > > There have never been any real users of MEMSET operations > > In tree users. Please show me them. There were no users except self-test one (which this patch also removes), the whole memset code has been dead since its introduction in January 2007. > And is it broken, if not why do you want to break it ? Well, it is partially broken as async_memset.c doesn't even built currently in next (I've posted fix for that before noticing that the whole code can be removed). Best regards, -- Bartlomiej Zolnierkiewicz Samsung Poland R Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thu, 08 Nov 2012 10:58:17 +0100 Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] DMA: remove unused support for MEMSET operations > > There have never been any real users of MEMSET operations In tree users. And is it broken, if not why do you want to break it ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] DMA: remove unused support for MEMSET operations
From: Bartlomiej Zolnierkiewicz Subject: [PATCH] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 "dmaengine: refactor dmaengine around dma_async_tx_descriptor"). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul Cc: Dan Williams Cc: Tomasz Figa Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- Documentation/crypto/async-tx-api.txt |1 arch/arm/mach-iop13xx/setup.c |3 - arch/arm/plat-iop/adma.c |2 arch/arm/plat-orion/common.c |5 - crypto/async_tx/Kconfig |4 - crypto/async_tx/Makefile |1 crypto/async_tx/async_memset.c| 88 --- drivers/dma/dmaengine.c |7 -- drivers/dma/ioat/dma.c|1 drivers/dma/ioat/dma_v3.c | 94 -- drivers/dma/iop-adma.c| 66 --- drivers/dma/mv_xor.c | 60 + drivers/dma/mv_xor.h |1 drivers/dma/ppc4xx/adma.c | 47 - include/linux/async_tx.h |4 - include/linux/dmaengine.h |5 - 16 files changed, 4 insertions(+), 385 deletions(-) Index: b/Documentation/crypto/async-tx-api.txt === --- a/Documentation/crypto/async-tx-api.txt 2012-11-07 15:00:06.208876620 +0100 +++ b/Documentation/crypto/async-tx-api.txt 2012-11-07 15:00:15.864876621 +0100 @@ -222,5 +222,4 @@ drivers/dma/: location for offload engin include/linux/async_tx.h: core header file for the async_tx api crypto/async_tx/async_tx.c: async_tx interface to dmaengine and common code crypto/async_tx/async_memcpy.c: copy offload -crypto/async_tx/async_memset.c: memory fill offload crypto/async_tx/async_xor.c: xor and xor zero sum offload Index: b/arch/arm/mach-iop13xx/setup.c === --- a/arch/arm/mach-iop13xx/setup.c 2012-11-07 15:15:11.000876512 +0100 +++ b/arch/arm/mach-iop13xx/setup.c 2012-11-07 15:15:21.068876510 +0100 @@ -469,7 +469,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data->cap_mask); dma_cap_set(DMA_XOR, plat_data->cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data->cap_mask); - dma_cap_set(DMA_MEMSET, plat_data->cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data->cap_mask); break; case IOP13XX_INIT_ADMA_1: @@ -479,7 +478,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data->cap_mask); dma_cap_set(DMA_XOR, plat_data->cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data->cap_mask); - dma_cap_set(DMA_MEMSET, plat_data->cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data->cap_mask); break; case IOP13XX_INIT_ADMA_2: @@ -489,7 +487,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data->cap_mask); dma_cap_set(DMA_XOR, plat_data->cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data->cap_mask); - dma_cap_set(DMA_MEMSET, plat_data->cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data->cap_mask); dma_cap_set(DMA_PQ, plat_data->cap_mask); dma_cap_set(DMA_PQ_VAL, plat_data->cap_mask); Index: b/arch/arm/plat-iop/adma.c === --- a/arch/arm/plat-iop/adma.c 2012-11-07 15:15:28.968876510 +0100 +++ b/arch/arm/plat-iop/adma.c 2012-11-07 15:15:44.540876510 +0100 @@ -192,12 +192,10 @@ static int __init iop3xx_adma_cap_init(v #ifdef CONFIG_ARCH_IOP32X /* the 32x AAU does not perform zero sum */ dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #else dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_XOR_VAL, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #endif Index: b/arch/arm/plat-orion/common.c === --- a/arch/arm/plat-orion/common.c 2012-11-07 15:15:50.744876507 +0100 +++ b/arch/arm/plat-orion/common.
[PATCH] DMA: remove unused support for MEMSET operations
From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations since they have been introduced in January 2007 (commit 7405f74badf46b5d023c5d2b670b4471525f6c91 dmaengine: refactor dmaengine around dma_async_tx_descriptor). Therefore remove support for them for now, it can be always brought back when needed. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc: Tomasz Figa t.f...@samsung.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/crypto/async-tx-api.txt |1 arch/arm/mach-iop13xx/setup.c |3 - arch/arm/plat-iop/adma.c |2 arch/arm/plat-orion/common.c |5 - crypto/async_tx/Kconfig |4 - crypto/async_tx/Makefile |1 crypto/async_tx/async_memset.c| 88 --- drivers/dma/dmaengine.c |7 -- drivers/dma/ioat/dma.c|1 drivers/dma/ioat/dma_v3.c | 94 -- drivers/dma/iop-adma.c| 66 --- drivers/dma/mv_xor.c | 60 + drivers/dma/mv_xor.h |1 drivers/dma/ppc4xx/adma.c | 47 - include/linux/async_tx.h |4 - include/linux/dmaengine.h |5 - 16 files changed, 4 insertions(+), 385 deletions(-) Index: b/Documentation/crypto/async-tx-api.txt === --- a/Documentation/crypto/async-tx-api.txt 2012-11-07 15:00:06.208876620 +0100 +++ b/Documentation/crypto/async-tx-api.txt 2012-11-07 15:00:15.864876621 +0100 @@ -222,5 +222,4 @@ drivers/dma/: location for offload engin include/linux/async_tx.h: core header file for the async_tx api crypto/async_tx/async_tx.c: async_tx interface to dmaengine and common code crypto/async_tx/async_memcpy.c: copy offload -crypto/async_tx/async_memset.c: memory fill offload crypto/async_tx/async_xor.c: xor and xor zero sum offload Index: b/arch/arm/mach-iop13xx/setup.c === --- a/arch/arm/mach-iop13xx/setup.c 2012-11-07 15:15:11.000876512 +0100 +++ b/arch/arm/mach-iop13xx/setup.c 2012-11-07 15:15:21.068876510 +0100 @@ -469,7 +469,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data-cap_mask); dma_cap_set(DMA_XOR, plat_data-cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data-cap_mask); - dma_cap_set(DMA_MEMSET, plat_data-cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data-cap_mask); break; case IOP13XX_INIT_ADMA_1: @@ -479,7 +478,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data-cap_mask); dma_cap_set(DMA_XOR, plat_data-cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data-cap_mask); - dma_cap_set(DMA_MEMSET, plat_data-cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data-cap_mask); break; case IOP13XX_INIT_ADMA_2: @@ -489,7 +487,6 @@ void __init iop13xx_platform_init(void) dma_cap_set(DMA_MEMCPY, plat_data-cap_mask); dma_cap_set(DMA_XOR, plat_data-cap_mask); dma_cap_set(DMA_XOR_VAL, plat_data-cap_mask); - dma_cap_set(DMA_MEMSET, plat_data-cap_mask); dma_cap_set(DMA_INTERRUPT, plat_data-cap_mask); dma_cap_set(DMA_PQ, plat_data-cap_mask); dma_cap_set(DMA_PQ_VAL, plat_data-cap_mask); Index: b/arch/arm/plat-iop/adma.c === --- a/arch/arm/plat-iop/adma.c 2012-11-07 15:15:28.968876510 +0100 +++ b/arch/arm/plat-iop/adma.c 2012-11-07 15:15:44.540876510 +0100 @@ -192,12 +192,10 @@ static int __init iop3xx_adma_cap_init(v #ifdef CONFIG_ARCH_IOP32X /* the 32x AAU does not perform zero sum */ dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #else dma_cap_set(DMA_XOR, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_XOR_VAL, iop3xx_aau_data.cap_mask); - dma_cap_set(DMA_MEMSET, iop3xx_aau_data.cap_mask); dma_cap_set(DMA_INTERRUPT, iop3xx_aau_data.cap_mask); #endif Index: b/arch/arm/plat-orion/common.c === --- a/arch/arm/plat-orion/common.c 2012-11-07 15:15:50.744876507
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thu, 08 Nov 2012 10:58:17 +0100 Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations In tree users. And is it broken, if not why do you want to break it ? Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thursday 08 November 2012 12:12:31 Alan Cox wrote: On Thu, 08 Nov 2012 10:58:17 +0100 Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations In tree users. Please show me them. There were no users except self-test one (which this patch also removes), the whole memset code has been dead since its introduction in January 2007. And is it broken, if not why do you want to break it ? Well, it is partially broken as async_memset.c doesn't even built currently in next (I've posted fix for that before noticing that the whole code can be removed). Best regards, -- Bartlomiej Zolnierkiewicz Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thu, 08 Nov 2012 12:22:05 +0100 Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: On Thursday 08 November 2012 12:12:31 Alan Cox wrote: On Thu, 08 Nov 2012 10:58:17 +0100 Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations In tree users. Please show me them. Sorry ? There are potentially lots of out of tree users in both the ARM and x86 communities. And is it broken, if not why do you want to break it ? Well, it is partially broken as async_memset.c doesn't even built currently in next (I've posted fix for that before noticing that the whole code can be removed). Ok that does suggest it's not being used at all but it would be wise to check more widely. Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: remove unused support for MEMSET operations
On Thursday 08 November 2012 12:31:48 Alan Cox wrote: On Thu, 08 Nov 2012 12:22:05 +0100 Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: On Thursday 08 November 2012 12:12:31 Alan Cox wrote: On Thu, 08 Nov 2012 10:58:17 +0100 Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] DMA: remove unused support for MEMSET operations There have never been any real users of MEMSET operations In tree users. Please show me them. Sorry ? There are potentially lots of out of tree users in both the ARM and x86 communities. They had almost six years to submit their code to upstream and there is potentially no problem for these _out_of_tree_ users to maintain also memset code out of tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
