Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs
On Thu, 2 Aug 2007, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Fixes WARN_ON() on bitfiels ops for all architectures that have > been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. Well, considering ... On Tue, 31 Jul 2007, Alexey Dobriyan wrote: > But I question the rationale of that commit: > [...] > I think that second case is more clear and immediately understandable. and On Tue, 31 Jul 2007, Linus Torvalds wrote: > For all I know, the proper solution is > to just revert the whole mess, and *not* make WARN_ON() return a value > at all, since that seems to be the fundamental mistake here. ... I think it makes sense to stop returning the value from WARN_ON() in the first place. There's only 5 places in the tree that uses its return value anyway, and one of them ( net/xfrm/xfrm_policy.c:681 ) is a good example of why it's less readable that way. Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs
On Thu, Aug 02, 2007 at 12:18:38AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Fixes WARN_ON() on bitfiels ops for all architectures that have > been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. > > Cc: Alexey Dobriyan <[EMAIL PROTECTED]> > Cc: Herbert Xu <[EMAIL PROTECTED]> > Cc: Paul Mundt <[EMAIL PROTECTED]> > Cc: Haavard Skinnemoen <[EMAIL PROTECTED]> > Cc: Matthew Wilcox <[EMAIL PROTECTED]> > Cc: Kyle McMartin <[EMAIL PROTECTED]> > Cc: Martin Schwidefsky <[EMAIL PROTECTED]> > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Acked-by: Paul Mundt <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix WARN_ON() on bitfield ops for all other archs
From: Heiko Carstens <[EMAIL PROTECTED]>
Fixes WARN_ON() on bitfiels ops for all architectures that have
been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f.
Cc: Alexey Dobriyan <[EMAIL PROTECTED]>
Cc: Herbert Xu <[EMAIL PROTECTED]>
Cc: Paul Mundt <[EMAIL PROTECTED]>
Cc: Haavard Skinnemoen <[EMAIL PROTECTED]>
Cc: Matthew Wilcox <[EMAIL PROTECTED]>
Cc: Kyle McMartin <[EMAIL PROTECTED]>
Cc: Martin Schwidefsky <[EMAIL PROTECTED]>
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
---
include/asm-avr32/bug.h |2 +-
include/asm-parisc/bug.h |2 +-
include/asm-s390/bug.h |2 +-
include/asm-sh/bug.h |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
Index: linux-2.6/include/asm-avr32/bug.h
===
--- linux-2.6.orig/include/asm-avr32/bug.h
+++ linux-2.6/include/asm-avr32/bug.h
@@ -57,7 +57,7 @@
#define WARN_ON(condition)
\
({ \
- typeof(condition) __ret_warn_on = (condition); \
+ int __ret_warn_on = !!(condition); \
if (unlikely(__ret_warn_on))\
_BUG_OR_WARN(BUGFLAG_WARNING); \
unlikely(__ret_warn_on);\
Index: linux-2.6/include/asm-parisc/bug.h
===
--- linux-2.6.orig/include/asm-parisc/bug.h
+++ linux-2.6/include/asm-parisc/bug.h
@@ -74,7 +74,7 @@
#define WARN_ON(x) ({ \
- typeof(x) __ret_warn_on = (x); \
+ int __ret_warn_on = !!(x); \
if (__builtin_constant_p(__ret_warn_on)) { \
if (__ret_warn_on) \
__WARN(); \
Index: linux-2.6/include/asm-s390/bug.h
===
--- linux-2.6.orig/include/asm-s390/bug.h
+++ linux-2.6/include/asm-s390/bug.h
@@ -50,7 +50,7 @@
#define BUG() __EMIT_BUG(0)
#define WARN_ON(x) ({ \
- typeof(x) __ret_warn_on = (x); \
+ int __ret_warn_on = !!(x); \
if (__builtin_constant_p(__ret_warn_on)) { \
if (__ret_warn_on) \
__EMIT_BUG(BUGFLAG_WARNING);\
Index: linux-2.6/include/asm-sh/bug.h
===
--- linux-2.6.orig/include/asm-sh/bug.h
+++ linux-2.6/include/asm-sh/bug.h
@@ -61,7 +61,7 @@ do { \
} while (0)
#define WARN_ON(x) ({ \
- typeof(x) __ret_warn_on = (x); \
+ int __ret_warn_on = !!(x); \
if (__builtin_constant_p(__ret_warn_on)) { \
if (__ret_warn_on) \
__WARN(); \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix WARN_ON() on bitfield ops for all other archs
From: Heiko Carstens [EMAIL PROTECTED]
Fixes WARN_ON() on bitfiels ops for all architectures that have
been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f.
Cc: Alexey Dobriyan [EMAIL PROTECTED]
Cc: Herbert Xu [EMAIL PROTECTED]
Cc: Paul Mundt [EMAIL PROTECTED]
Cc: Haavard Skinnemoen [EMAIL PROTECTED]
Cc: Matthew Wilcox [EMAIL PROTECTED]
Cc: Kyle McMartin [EMAIL PROTECTED]
Cc: Martin Schwidefsky [EMAIL PROTECTED]
Signed-off-by: Heiko Carstens [EMAIL PROTECTED]
---
include/asm-avr32/bug.h |2 +-
include/asm-parisc/bug.h |2 +-
include/asm-s390/bug.h |2 +-
include/asm-sh/bug.h |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
Index: linux-2.6/include/asm-avr32/bug.h
===
--- linux-2.6.orig/include/asm-avr32/bug.h
+++ linux-2.6/include/asm-avr32/bug.h
@@ -57,7 +57,7 @@
#define WARN_ON(condition)
\
({ \
- typeof(condition) __ret_warn_on = (condition); \
+ int __ret_warn_on = !!(condition); \
if (unlikely(__ret_warn_on))\
_BUG_OR_WARN(BUGFLAG_WARNING); \
unlikely(__ret_warn_on);\
Index: linux-2.6/include/asm-parisc/bug.h
===
--- linux-2.6.orig/include/asm-parisc/bug.h
+++ linux-2.6/include/asm-parisc/bug.h
@@ -74,7 +74,7 @@
#define WARN_ON(x) ({ \
- typeof(x) __ret_warn_on = (x); \
+ int __ret_warn_on = !!(x); \
if (__builtin_constant_p(__ret_warn_on)) { \
if (__ret_warn_on) \
__WARN(); \
Index: linux-2.6/include/asm-s390/bug.h
===
--- linux-2.6.orig/include/asm-s390/bug.h
+++ linux-2.6/include/asm-s390/bug.h
@@ -50,7 +50,7 @@
#define BUG() __EMIT_BUG(0)
#define WARN_ON(x) ({ \
- typeof(x) __ret_warn_on = (x); \
+ int __ret_warn_on = !!(x); \
if (__builtin_constant_p(__ret_warn_on)) { \
if (__ret_warn_on) \
__EMIT_BUG(BUGFLAG_WARNING);\
Index: linux-2.6/include/asm-sh/bug.h
===
--- linux-2.6.orig/include/asm-sh/bug.h
+++ linux-2.6/include/asm-sh/bug.h
@@ -61,7 +61,7 @@ do { \
} while (0)
#define WARN_ON(x) ({ \
- typeof(x) __ret_warn_on = (x); \
+ int __ret_warn_on = !!(x); \
if (__builtin_constant_p(__ret_warn_on)) { \
if (__ret_warn_on) \
__WARN(); \
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs
On Thu, Aug 02, 2007 at 12:18:38AM +0200, Heiko Carstens wrote: From: Heiko Carstens [EMAIL PROTECTED] Fixes WARN_ON() on bitfiels ops for all architectures that have been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. Cc: Alexey Dobriyan [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] Cc: Paul Mundt [EMAIL PROTECTED] Cc: Haavard Skinnemoen [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL PROTECTED] Cc: Kyle McMartin [EMAIL PROTECTED] Cc: Martin Schwidefsky [EMAIL PROTECTED] Signed-off-by: Heiko Carstens [EMAIL PROTECTED] Acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs
On Thu, 2 Aug 2007, Heiko Carstens wrote: From: Heiko Carstens [EMAIL PROTECTED] Fixes WARN_ON() on bitfiels ops for all architectures that have been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. Well, considering ... On Tue, 31 Jul 2007, Alexey Dobriyan wrote: But I question the rationale of that commit: [...] I think that second case is more clear and immediately understandable. and On Tue, 31 Jul 2007, Linus Torvalds wrote: For all I know, the proper solution is to just revert the whole mess, and *not* make WARN_ON() return a value at all, since that seems to be the fundamental mistake here. ... I think it makes sense to stop returning the value from WARN_ON() in the first place. There's only 5 places in the tree that uses its return value anyway, and one of them ( net/xfrm/xfrm_policy.c:681 ) is a good example of why it's less readable that way. Satyam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
