Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-16 Thread Jeff Garzik

applied to #upstream-fixes


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-16 Thread Alan
> Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work 
> correctly. The help text is a bit confusing:
> 
> config ATA_PIIX
> tristate "Intel PIIX/ICH SATA support"
> depends on PCI
> help
>   This option enables support for ICH5/6/7/8 Serial ATA.
>   If PATA support was enabled previously, this enables
>   support for select Intel PIIX/ICH PATA host controllers.

New help text

Signed-off-by: Alan Cox <[EMAIL PROTECTED]>

--- linux.vanilla-2.6.20-rc1/drivers/ata/Kconfig2006-12-14 
17:23:30.0 +
+++ linux-2.6.20-rc1/drivers/ata/Kconfig2006-12-16 12:29:50.198153800 
+
@@ -40,9 +40,9 @@
tristate "Intel PIIX/ICH SATA support"
depends on PCI
help
- This option enables support for ICH5/6/7/8 Serial ATA.
- If PATA support was enabled previously, this enables
- support for select Intel PIIX/ICH PATA host controllers.
+ This option enables support for ICH5/6/7/8 Serial ATA
+ and support for PATA on the Intel PIIX3/PIIX4/ICH series
+ PATA host controllers.
 
  If unsure, say N.
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-16 Thread Alan
 Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work 
 correctly. The help text is a bit confusing:
 
 config ATA_PIIX
 tristate Intel PIIX/ICH SATA support
 depends on PCI
 help
   This option enables support for ICH5/6/7/8 Serial ATA.
   If PATA support was enabled previously, this enables
   support for select Intel PIIX/ICH PATA host controllers.

New help text

Signed-off-by: Alan Cox [EMAIL PROTECTED]

--- linux.vanilla-2.6.20-rc1/drivers/ata/Kconfig2006-12-14 
17:23:30.0 +
+++ linux-2.6.20-rc1/drivers/ata/Kconfig2006-12-16 12:29:50.198153800 
+
@@ -40,9 +40,9 @@
tristate Intel PIIX/ICH SATA support
depends on PCI
help
- This option enables support for ICH5/6/7/8 Serial ATA.
- If PATA support was enabled previously, this enables
- support for select Intel PIIX/ICH PATA host controllers.
+ This option enables support for ICH5/6/7/8 Serial ATA
+ and support for PATA on the Intel PIIX3/PIIX4/ICH series
+ PATA host controllers.
 
  If unsure, say N.
 
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-16 Thread Jeff Garzik

applied to #upstream-fixes


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-14 Thread Alan
> Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work 
> correctly. The help text is a bit confusing:

The help text is out of date - thanks that is a real bug 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-14 Thread Alistair John Strachan
On Thursday 14 December 2006 19:53, Bill Nottingham wrote:
> Alistair John Strachan ([EMAIL PROTECTED]) said:
> > > > Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE
> > > > controller and boot off it?
> > >
> > > ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is
> > > specifically for the Intel MPIIX laptop chipset and pata_oldpiix
> > > explicitly for the original PIIX chipset and none of the later ones.
> >
> > Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and
> > greater. The kernel help text agrees with me.
> >
> > My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was
> > interested in using your pata_xxx drivers in replacement, assuming there
> > was support.
>
> pata_xxx is for older PIIX, not ICH4. ICH* is handled by ata_piix, which
> can drive both SATA *and* PATA in the new kernels. 

Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work 
correctly. The help text is a bit confusing:

config ATA_PIIX
tristate "Intel PIIX/ICH SATA support"
depends on PCI
help
  This option enables support for ICH5/6/7/8 Serial ATA.
  If PATA support was enabled previously, this enables
  support for select Intel PIIX/ICH PATA host controllers.

"Enabled previously"?

-- 
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-14 Thread Alistair John Strachan
On Thursday 14 December 2006 19:53, Bill Nottingham wrote:
 Alistair John Strachan ([EMAIL PROTECTED]) said:
Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE
controller and boot off it?
  
   ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is
   specifically for the Intel MPIIX laptop chipset and pata_oldpiix
   explicitly for the original PIIX chipset and none of the later ones.
 
  Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and
  greater. The kernel help text agrees with me.
 
  My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was
  interested in using your pata_xxx drivers in replacement, assuming there
  was support.

 pata_xxx is for older PIIX, not ICH4. ICH* is handled by ata_piix, which
 can drive both SATA *and* PATA in the new kernels. 

Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work 
correctly. The help text is a bit confusing:

config ATA_PIIX
tristate Intel PIIX/ICH SATA support
depends on PCI
help
  This option enables support for ICH5/6/7/8 Serial ATA.
  If PATA support was enabled previously, this enables
  support for select Intel PIIX/ICH PATA host controllers.

Enabled previously?

-- 
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-14 Thread Alan
 Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work 
 correctly. The help text is a bit confusing:

The help text is out of date - thanks that is a real bug 
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/