Re: [PATCH] INPUT: xpad: support Ardwiino Controllers
Hi Sanjay,
On Tue, Dec 01, 2020 at 08:19:23PM +1300, sanjay.govi...@gmail.com wrote:
> From: Sanjay Govind
>
> This commit adds support for Ardwiino Controllers
>
> Signed-off-by: Sanjay Govind
> ---
> drivers/input/joystick/xpad.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c77cdb3b62b5..91a5c7e7bdd2 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -245,6 +245,7 @@ static const struct xpad_device {
> { 0x12ab, 0x0301, "PDP AFTERGLOW AX.1", 0, XTYPE_XBOX360 },
> { 0x12ab, 0x0303, "Mortal Kombat Klassic FightStick",
> MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
> { 0x12ab, 0x8809, "Xbox DDR dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX
> },
> + { 0x1209, 0x2882, "Ardwiino Controller", 0, XTYPE_XBOX360 },
I moved this line above the entries for 12ab vendor and applied, thank
you.
> { 0x1430, 0x4748, "RedOctane Guitar Hero X-plorer", 0, XTYPE_XBOX360 },
> { 0x1430, 0x, "TX6500+ Dance Pad (first generation)",
> MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> { 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 },
> @@ -418,6 +419,7 @@ static const struct usb_device_id xpad_table[] = {
> XPAD_XBOXONE_VENDOR(0x0f0d),/* Hori Controllers */
> XPAD_XBOX360_VENDOR(0x1038),/* SteelSeries Controllers */
> XPAD_XBOX360_VENDOR(0x11c9),/* Nacon GC100XF */
> + XPAD_XBOX360_VENDOR(0x1209),/* Ardwiino Controllers */
> XPAD_XBOX360_VENDOR(0x12ab),/* X-Box 360 dance pads */
> XPAD_XBOX360_VENDOR(0x1430),/* RedOctane X-Box 360
> controllers */
> XPAD_XBOX360_VENDOR(0x146b),/* BigBen Interactive
> Controllers */
> --
> 2.29.2
>
--
Dmitry
[PATCH] INPUT: xpad: support Ardwiino Controllers
From: Sanjay Govind
This commit adds support for Ardwiino Controllers
Signed-off-by: Sanjay Govind
---
drivers/input/joystick/xpad.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index c77cdb3b62b5..91a5c7e7bdd2 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -245,6 +245,7 @@ static const struct xpad_device {
{ 0x12ab, 0x0301, "PDP AFTERGLOW AX.1", 0, XTYPE_XBOX360 },
{ 0x12ab, 0x0303, "Mortal Kombat Klassic FightStick",
MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
{ 0x12ab, 0x8809, "Xbox DDR dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX
},
+ { 0x1209, 0x2882, "Ardwiino Controller", 0, XTYPE_XBOX360 },
{ 0x1430, 0x4748, "RedOctane Guitar Hero X-plorer", 0, XTYPE_XBOX360 },
{ 0x1430, 0x, "TX6500+ Dance Pad (first generation)",
MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
{ 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 },
@@ -418,6 +419,7 @@ static const struct usb_device_id xpad_table[] = {
XPAD_XBOXONE_VENDOR(0x0f0d),/* Hori Controllers */
XPAD_XBOX360_VENDOR(0x1038),/* SteelSeries Controllers */
XPAD_XBOX360_VENDOR(0x11c9),/* Nacon GC100XF */
+ XPAD_XBOX360_VENDOR(0x1209),/* Ardwiino Controllers */
XPAD_XBOX360_VENDOR(0x12ab),/* X-Box 360 dance pads */
XPAD_XBOX360_VENDOR(0x1430),/* RedOctane X-Box 360
controllers */
XPAD_XBOX360_VENDOR(0x146b),/* BigBen Interactive
Controllers */
--
2.29.2
Re: [PATCH] INPUT: xpad: support Ardwiino Controllers
Hi Sanjay,
On Tue, Dec 01, 2020 at 07:48:45PM +1300, sanjay.govi...@gmail.com wrote:
> From: Sanjay Govind
>
> This commit adds support for Ardwiino Controllers
Thank you for resending the patch, it now is formatted properly. However
I believe you need to also add information about Ardwiino controllers to
xpad_device table so that they are properly identified by the kernel.
Thanks.
>
> Signed-off-by: Sanjay Govind
> ---
> drivers/input/joystick/xpad.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c77cdb3b62b5..c9d78e2acb38 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -418,6 +418,7 @@ static const struct usb_device_id xpad_table[] = {
> XPAD_XBOXONE_VENDOR(0x0f0d),/* Hori Controllers */
> XPAD_XBOX360_VENDOR(0x1038),/* SteelSeries Controllers */
> XPAD_XBOX360_VENDOR(0x11c9),/* Nacon GC100XF */
> + XPAD_XBOX360_VENDOR(0x1209),/* Ardwiino Controllers */
> XPAD_XBOX360_VENDOR(0x12ab),/* X-Box 360 dance pads */
> XPAD_XBOX360_VENDOR(0x1430),/* RedOctane X-Box 360
> controllers */
> XPAD_XBOX360_VENDOR(0x146b),/* BigBen Interactive
> Controllers */
> --
> 2.29.2
>
--
Dmitry
[PATCH] INPUT: xpad: support Ardwiino Controllers
From: Sanjay Govind
This commit adds support for Ardwiino Controllers
Signed-off-by: Sanjay Govind
---
drivers/input/joystick/xpad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index c77cdb3b62b5..c9d78e2acb38 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -418,6 +418,7 @@ static const struct usb_device_id xpad_table[] = {
XPAD_XBOXONE_VENDOR(0x0f0d),/* Hori Controllers */
XPAD_XBOX360_VENDOR(0x1038),/* SteelSeries Controllers */
XPAD_XBOX360_VENDOR(0x11c9),/* Nacon GC100XF */
+ XPAD_XBOX360_VENDOR(0x1209),/* Ardwiino Controllers */
XPAD_XBOX360_VENDOR(0x12ab),/* X-Box 360 dance pads */
XPAD_XBOX360_VENDOR(0x1430),/* RedOctane X-Box 360
controllers */
XPAD_XBOX360_VENDOR(0x146b),/* BigBen Interactive
Controllers */
--
2.29.2
Re: [PATCH] INPUT: xpad: support Ardwiino Controllers
Hi Sanjay,
On Thu, Nov 26, 2020 at 10:25:40PM +1300, Sanjay Govind wrote:
> This commit adds support for Ardwiino Controllers
Unfortunately the patch is line-wrapped, with tabs removed, and
therefore can not be applied. It is also sent as HTML so most mailing
lists dropped it. I guess you sent it through gmail's web interface,
which is known not to work for patch submission. Could you please resend
via "git send-email" which will ensure that it is formatted properly.
>
> Signed-off-by: Sanjay Govind
> ---
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c77cdb3b62b5..c9d78e2acb38 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -418,6 +418,7 @@ static const struct usb_device_id xpad_table[] = {
> XPAD_XBOXONE_VENDOR(0x0f0d),/* Hori Controllers */
> XPAD_XBOX360_VENDOR(0x1038),/* SteelSeries Controllers
> */
> XPAD_XBOX360_VENDOR(0x11c9),/* Nacon GC100XF */
> + XPAD_XBOX360_VENDOR(0x1209),/* Ardwiino Controllers */
> XPAD_XBOX360_VENDOR(0x12ab),/* X-Box 360 dance pads */
> XPAD_XBOX360_VENDOR(0x1430),/* RedOctane X-Box 360
> controllers */
> XPAD_XBOX360_VENDOR(0x146b),/* BigBen Interactive
> Controllers */
Thanks.
--
Dmitry
