Re: [PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution
On Tue, May 20, 2014 at 10:26:51AM +0100, Nick Dyer wrote: > Stephen Rothwell reports this build error: > > drivers/input/touchscreen/atmel_mxt_ts.c: In function > 'mxt_read_t9_resolution': > drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 > of '__swab16s' makes pointer from integer without a cast [enabled by default] > le16_to_cpus(range.x); > ^ > > I believe this is a correct fix. > > Signed-off-by: Nick Dyer > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c > b/drivers/input/touchscreen/atmel_mxt_ts.c > index d8ea3ed..97495c7 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -1040,8 +1040,8 @@ static int mxt_read_t9_resolution(struct mxt_data *data) > if (error) > return error; > > - le16_to_cpus(range.x); > - le16_to_cpus(range.y); > + le16_to_cpus(); > + le16_to_cpus(); > > error = __mxt_read_reg(client, > object->start_address + MXT_T9_ORIENT, > -- > 1.8.3.2 > Thank you, I folded it into the offending patch. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution
On Tue, May 20, 2014 at 10:26:51AM +0100, Nick Dyer wrote: Stephen Rothwell reports this build error: drivers/input/touchscreen/atmel_mxt_ts.c: In function 'mxt_read_t9_resolution': drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [enabled by default] le16_to_cpus(range.x); ^ I believe this is a correct fix. Signed-off-by: Nick Dyer nick.d...@itdev.co.uk --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index d8ea3ed..97495c7 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1040,8 +1040,8 @@ static int mxt_read_t9_resolution(struct mxt_data *data) if (error) return error; - le16_to_cpus(range.x); - le16_to_cpus(range.y); + le16_to_cpus(range.x); + le16_to_cpus(range.y); error = __mxt_read_reg(client, object-start_address + MXT_T9_ORIENT, -- 1.8.3.2 Thank you, I folded it into the offending patch. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution
From: Nick Dyer Stephen Rothwell reports this build error: drivers/input/touchscreen/atmel_mxt_ts.c: In function 'mxt_read_t9_resolution': drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [enabled by default] le16_to_cpus(range.x); ^ I believe this is a correct fix. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index d8ea3ed..97495c7 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1040,8 +1040,8 @@ static int mxt_read_t9_resolution(struct mxt_data *data) if (error) return error; - le16_to_cpus(range.x); - le16_to_cpus(range.y); + le16_to_cpus(); + le16_to_cpus(); error = __mxt_read_reg(client, object->start_address + MXT_T9_ORIENT, -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution
From: Nick Dyer nick.d...@itdev.co.uk Stephen Rothwell reports this build error: drivers/input/touchscreen/atmel_mxt_ts.c: In function 'mxt_read_t9_resolution': drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [enabled by default] le16_to_cpus(range.x); ^ I believe this is a correct fix. Signed-off-by: Nick Dyer nick.d...@itdev.co.uk --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index d8ea3ed..97495c7 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1040,8 +1040,8 @@ static int mxt_read_t9_resolution(struct mxt_data *data) if (error) return error; - le16_to_cpus(range.x); - le16_to_cpus(range.y); + le16_to_cpus(range.x); + le16_to_cpus(range.y); error = __mxt_read_reg(client, object-start_address + MXT_T9_ORIENT, -- 1.8.3.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
