Re: [PATCH] Input: gtco - remove driver

2021-01-08 Thread Jiri Kosina
On Thu, 17 Dec 2020, Dmitry Torokhov wrote:

> > > Note that our HID support has greatly improved over the last 10 years,
> > > we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO
> > > CalComp Digitizers and InterWrite School Products to blacklist") and see
> > > if GTCO devices actually work with normal HID drivers.
> > 
> > Sounds like a good plan to me. Perhaps you can do that in a series 
> > together, and stage that for 5.12?
> 
> Sorry, I already zapped the driver in 5.11.
> 
> Unfortunately I do not have this hardware, so while we could remove
> these devices from the blacklist we will have to do that blindly. Please
> let me know if you still want to do that.

We can also wait for the first person to potentially complain (if ever) 
about the driver going away -- that'd mean that the person does actually 
still have that hardware, and we could ask him to test with hid-generic.

Thanks,

-- 
Jiri Kosina
SUSE Labs



Re: [PATCH] Input: gtco - remove driver

2020-12-17 Thread Dmitry Torokhov
Hi Jiri,

On Thu, Dec 17, 2020 at 12:22:17PM +0100, Jiri Kosina wrote:
> On Sat, 5 Dec 2020, Dmitry Torokhov wrote:
> 
> > The driver has its own HID descriptor parsing code, that had and still
> > has several issues discovered by syzbot and other tools. Ideally we
> > should move the driver over to the HID subsystem, so that it uses proven
> > parsing code.  However the devices in question are EOL, and GTCO is not
> > willing to extend resources for that, so let's simply remove the driver.
> 
> Acked-by: Jiri Kosina 
> 
> > 
> > Note that our HID support has greatly improved over the last 10 years,
> > we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO
> > CalComp Digitizers and InterWrite School Products to blacklist") and see
> > if GTCO devices actually work with normal HID drivers.
> 
> Sounds like a good plan to me. Perhaps you can do that in a series 
> together, and stage that for 5.12?

Sorry, I already zapped the driver in 5.11.

Unfortunately I do not have this hardware, so while we could remove
these devices from the blacklist we will have to do that blindly. Please
let me know if you still want to do that.

Thank you.

-- 
Dmitry


Re: [PATCH] Input: gtco - remove driver

2020-12-17 Thread Jiri Kosina
On Sat, 5 Dec 2020, Dmitry Torokhov wrote:

> The driver has its own HID descriptor parsing code, that had and still
> has several issues discovered by syzbot and other tools. Ideally we
> should move the driver over to the HID subsystem, so that it uses proven
> parsing code.  However the devices in question are EOL, and GTCO is not
> willing to extend resources for that, so let's simply remove the driver.

Acked-by: Jiri Kosina 

> 
> Note that our HID support has greatly improved over the last 10 years,
> we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO
> CalComp Digitizers and InterWrite School Products to blacklist") and see
> if GTCO devices actually work with normal HID drivers.

Sounds like a good plan to me. Perhaps you can do that in a series 
together, and stage that for 5.12?

Thanks,

-- 
Jiri Kosina
SUSE Labs



[PATCH] Input: gtco - remove driver

2020-12-05 Thread Dmitry Torokhov
The driver has its own HID descriptor parsing code, that had and still
has several issues discovered by syzbot and other tools. Ideally we
should move the driver over to the HID subsystem, so that it uses proven
parsing code.  However the devices in question are EOL, and GTCO is not
willing to extend resources for that, so let's simply remove the driver.

Note that our HID support has greatly improved over the last 10 years,
we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO
CalComp Digitizers and InterWrite School Products to blacklist") and see
if GTCO devices actually work with normal HID drivers.

Signed-off-by: Dmitry Torokhov 
---
 drivers/input/tablet/Kconfig  |   12 -
 drivers/input/tablet/Makefile |1 -
 drivers/input/tablet/gtco.c   | 1043 -
 kernel/configs/android-recommended.config |1 -
 4 files changed, 1057 deletions(-)

diff --git a/drivers/input/tablet/Kconfig b/drivers/input/tablet/Kconfig
index 51c339182017..ec27eff6ae37 100644
--- a/drivers/input/tablet/Kconfig
+++ b/drivers/input/tablet/Kconfig
@@ -38,18 +38,6 @@ config TABLET_USB_AIPTEK
  To compile this driver as a module, choose M here: the
  module will be called aiptek.
 
-config TABLET_USB_GTCO
-   tristate "GTCO CalComp/InterWrite USB Support"
-   depends on USB && INPUT
-   help
- Say Y here if you want to use the USB version of the GTCO
- CalComp/InterWrite Tablet.  Make sure to say Y to "Mouse support"
- (CONFIG_INPUT_MOUSEDEV) and/or "Event interface support"
- (CONFIG_INPUT_EVDEV) as well.
-
- To compile this driver as a module, choose M here: the
- module will be called gtco.
-
 config TABLET_USB_HANWANG
tristate "Hanwang Art Master III tablet support (USB)"
depends on USB_ARCH_HAS_HCD
diff --git a/drivers/input/tablet/Makefile b/drivers/input/tablet/Makefile
index 8279ccc18b0a..adb636430717 100644
--- a/drivers/input/tablet/Makefile
+++ b/drivers/input/tablet/Makefile
@@ -6,7 +6,6 @@
 
 obj-$(CONFIG_TABLET_USB_ACECAD)+= acecad.o
 obj-$(CONFIG_TABLET_USB_AIPTEK)+= aiptek.o
-obj-$(CONFIG_TABLET_USB_GTCO)  += gtco.o
 obj-$(CONFIG_TABLET_USB_HANWANG) += hanwang.o
 obj-$(CONFIG_TABLET_USB_KBTAB) += kbtab.o
 obj-$(CONFIG_TABLET_USB_PEGASUS) += pegasus_notetaker.o
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
deleted file mode 100644
index 44bb1f69b4b2..
--- a/drivers/input/tablet/gtco.c
+++ /dev/null
@@ -1,1043 +0,0 @@
-/*-*- linux-c -*-
-
-GTCO digitizer USB driver
-
-TO CHECK:  Is pressure done right on report 5?
-
-Copyright (C) 2006  GTCO CalComp
-
-This program is free software; you can redistribute it and/or
-modify it under the terms of the GNU General Public License
-as published by the Free Software Foundation; version 2
-of the License.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with this program; if not, write to the Free Software
-Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-
-Permission to use, copy, modify, distribute, and sell this software and its
-documentation for any purpose is hereby granted without fee, provided that
-the above copyright notice appear in all copies and that both that
-copyright notice and this permission notice appear in supporting
-documentation, and that the name of GTCO-CalComp not be used in advertising
-or publicity pertaining to distribution of the software without specific,
-written prior permission. GTCO-CalComp makes no representations about the
-suitability of this software for any purpose.  It is provided "as is"
-without express or implied warranty.
-
-GTCO-CALCOMP DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
-INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
-EVENT SHALL GTCO-CALCOMP BE LIABLE FOR ANY SPECIAL, INDIRECT OR
-CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
-DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
-TORTIOUS ACTIONS, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
-PERFORMANCE OF THIS SOFTWARE.
-
-GTCO CalComp, Inc.
-7125 Riverwood Drive
-Columbia, MD 21046
-
-Jeremy Roberson jrober...@gtcocalcomp.com
-Scott Hill sh...@gtcocalcomp.com
-*/
-
-
-
-/*#define DEBUG*/
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include 
-
-/* Version with a Major number of 2 is for kernel inclusion only. */
-#define  GTCO_VERSION   "2.00.0006"
-
-
-/*   MACROS  */
-
-#define VENDOR_ID_GTCO   0x078C
-#define PID_400   0x400
-#define PID_401   0x401
-#define PID_1000