Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
On Thu, Oct 29, 2020 at 04:48:30PM +0100, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter > or member 'kid1' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter > or member 'kid2' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_1' description in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_2' description in 'asymmetric_key_id_same' > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Randy Dunlap > --- Reviewed-by: Jarkko Sakkinen > crypto/asymmetric_keys/asymmetric_type.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/crypto/asymmetric_keys/asymmetric_type.c > b/crypto/asymmetric_keys/asymmetric_type.c > index 33e77d846caa..ad8af3d70ac0 100644 > --- a/crypto/asymmetric_keys/asymmetric_type.c > +++ b/crypto/asymmetric_keys/asymmetric_type.c > @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id); > > /** > * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the > same. > - * @kid_1, @kid_2: The key IDs to compare > + * @kid1: The key ID to compare > + * @kid2: The key ID to compare > */ > bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1, > const struct asymmetric_key_id *kid2) > @@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same); > /** > * asymmetric_key_id_partial - Return true if two asymmetric keys IDs > * partially match > - * @kid_1, @kid_2: The key IDs to compare > + * @kid1: The key ID to compare > + * @kid2: The key ID to compare > */ > bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1, > const struct asymmetric_key_id *kid2) > -- > 2.25.1 > > /Jarkko
Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
On Thu, Oct 29, 2020 at 16:48:30 +0100, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter > or member 'kid1' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter > or member 'kid2' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_1' description in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_2' description in 'asymmetric_key_id_same' > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Randy Dunlap Reviewed-by: Ben Boeckel --Ben
[RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
Fix W=1 compile warnings (invalid kerneldoc): crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same' Signed-off-by: Krzysztof Kozlowski Acked-by: Randy Dunlap --- crypto/asymmetric_keys/asymmetric_type.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c index 33e77d846caa..ad8af3d70ac0 100644 --- a/crypto/asymmetric_keys/asymmetric_type.c +++ b/crypto/asymmetric_keys/asymmetric_type.c @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id); /** * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same. - * @kid_1, @kid_2: The key IDs to compare + * @kid1: The key ID to compare + * @kid2: The key ID to compare */ bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1, const struct asymmetric_key_id *kid2) @@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same); /** * asymmetric_key_id_partial - Return true if two asymmetric keys IDs * partially match - * @kid_1, @kid_2: The key IDs to compare + * @kid1: The key ID to compare + * @kid2: The key ID to compare */ bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1, const struct asymmetric_key_id *kid2) -- 2.25.1
Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
On 8/30/20 7:56 AM, Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 07:52:12PM +0200, Krzysztof Kozlowski wrote: >> Fix W=1 compile warnings (invalid kerneldoc): >> >> crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function >> parameter or member 'kid1' not described in 'asymmetric_key_id_same' >> crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function >> parameter or member 'kid2' not described in 'asymmetric_key_id_same' >> crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function >> parameter 'kid_1' description in 'asymmetric_key_id_same' >> crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function >> parameter 'kid_2' description in 'asymmetric_key_id_same' >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> crypto/asymmetric_keys/asymmetric_type.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > Hi David, Herbert, > > Any comments here? > > Best regards, > Krzysztof LGTM. Thanks. Acked-by: Randy Dunlap -- ~Randy
Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
On Wed, Aug 19, 2020 at 07:52:12PM +0200, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter > or member 'kid1' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter > or member 'kid2' not described in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_1' description in 'asymmetric_key_id_same' > crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_2' description in 'asymmetric_key_id_same' > > Signed-off-by: Krzysztof Kozlowski > --- > crypto/asymmetric_keys/asymmetric_type.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Hi David, Herbert, Any comments here? Best regards, Krzysztof
[RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
Fix W=1 compile warnings (invalid kerneldoc): crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same' Signed-off-by: Krzysztof Kozlowski --- crypto/asymmetric_keys/asymmetric_type.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c index 33e77d846caa..ad8af3d70ac0 100644 --- a/crypto/asymmetric_keys/asymmetric_type.c +++ b/crypto/asymmetric_keys/asymmetric_type.c @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id); /** * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same. - * @kid_1, @kid_2: The key IDs to compare + * @kid1: The key ID to compare + * @kid2: The key ID to compare */ bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1, const struct asymmetric_key_id *kid2) @@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same); /** * asymmetric_key_id_partial - Return true if two asymmetric keys IDs * partially match - * @kid_1, @kid_2: The key IDs to compare + * @kid1: The key ID to compare + * @kid2: The key ID to compare */ bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1, const struct asymmetric_key_id *kid2) -- 2.17.1
[PATCH] KEYS: asymmetric: Fix kerneldoc
Fix W=1 compile warnings (invalid kerneldoc): crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same' Signed-off-by: Krzysztof Kozlowski --- crypto/asymmetric_keys/asymmetric_type.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c index 33e77d846caa..ad8af3d70ac0 100644 --- a/crypto/asymmetric_keys/asymmetric_type.c +++ b/crypto/asymmetric_keys/asymmetric_type.c @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id); /** * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same. - * @kid_1, @kid_2: The key IDs to compare + * @kid1: The key ID to compare + * @kid2: The key ID to compare */ bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1, const struct asymmetric_key_id *kid2) @@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same); /** * asymmetric_key_id_partial - Return true if two asymmetric keys IDs * partially match - * @kid_1, @kid_2: The key IDs to compare + * @kid1: The key ID to compare + * @kid2: The key ID to compare */ bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1, const struct asymmetric_key_id *kid2) -- 2.17.1
