[PATCH] Kbuild: use normal compression settings for tar*-pkg
From: Andi Kleen
For large kernel configurations (like a distribution kernel)
targz-pkg takes a quite long time to just do the compression.
I clocked it at 15+mins for a SUSE kernel like config on a fast
system. And tarxz and bzip2 are even slower.
The main reason is that the script that is doing the taring sets
the highest compression level (-9). When I change it to just
use the defaults the gzip time for the same kernel goes down
to ~3 mins. I haven't tested xz and bzip, but I expect those
to be much faster too.
I'm not willing to wait that long for a small compression
gain. So just change the script to use the defaults.
Signed-off-by: Andi Kleen
---
scripts/package/buildtar |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/package/buildtar b/scripts/package/buildtar
index 8a7b155..632377f 100644
--- a/scripts/package/buildtar
+++ b/scripts/package/buildtar
@@ -28,15 +28,15 @@ case "${1}" in
file_ext=""
;;
targz-pkg)
- compress="gzip -c9"
+ compress="gzip"
file_ext=".gz"
;;
tarbz2-pkg)
- compress="bzip2 -c9"
+ compress="bzip2"
file_ext=".bz2"
;;
tarxz-pkg)
- compress="xz -c9"
+ compress="xz"
file_ext=".xz"
;;
*)
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
On Sat, Sep 08, 2012 at 12:47:59PM -0700, Andi Kleen wrote:
> From: Andi Kleen
>
> For large kernel configurations (like a distribution kernel)
> targz-pkg takes a quite long time to just do the compression.
> I clocked it at 15+mins for a SUSE kernel like config on a fast
> system. And tarxz and bzip2 are even slower.
>
> The main reason is that the script that is doing the taring sets
> the highest compression level (-9). When I change it to just
> use the defaults the gzip time for the same kernel goes down
> to ~3 mins. I haven't tested xz and bzip, but I expect those
> to be much faster too.
>
> I'm not willing to wait that long for a small compression
> gain. So just change the script to use the defaults.
Makes sense to me.
Reviewed-by: Fengguang Wu
> Signed-off-by: Andi Kleen
> ---
> scripts/package/buildtar |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 8a7b155..632377f 100644
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -28,15 +28,15 @@ case "${1}" in
> file_ext=""
> ;;
> targz-pkg)
> - compress="gzip -c9"
> + compress="gzip"
-c should be kept because it means --stdout and --keep
> file_ext=".gz"
> ;;
> tarbz2-pkg)
> - compress="bzip2 -c9"
> + compress="bzip2"
ditto
> file_ext=".bz2"
> ;;
> tarxz-pkg)
> - compress="xz -c9"
> + compress="xz"
ditto
> file_ext=".xz"
> ;;
> *)
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
> > -c should be kept because it means --stdout and --keep It seems to work without it. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
On Tue, Sep 11, 2012 at 05:01:09AM +0200, Andi Kleen wrote:
> >
> > -c should be kept because it means --stdout and --keep
>
> It seems to work without it.
Yeah I see: it's used in the pipe anyway:
tar cf - . $opts | ${compress} > "${tarball}${file_ext}"
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
On 09/08/2012 09:47 PM, Andi Kleen wrote:
> From: Andi Kleen
>
> For large kernel configurations (like a distribution kernel)
> targz-pkg takes a quite long time to just do the compression.
> I clocked it at 15+mins for a SUSE kernel like config on a fast
> system. And tarxz and bzip2 are even slower.
>
> The main reason is that the script that is doing the taring sets
> the highest compression level (-9). When I change it to just
> use the defaults the gzip time for the same kernel goes down
> to ~3 mins. I haven't tested xz and bzip, but I expect those
> to be much faster too.
>
> I'm not willing to wait that long for a small compression
> gain. So just change the script to use the defaults.
>
> Signed-off-by: Andi Kleen
> ---
> scripts/package/buildtar |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 8a7b155..632377f 100644
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -28,15 +28,15 @@ case "${1}" in
> file_ext=""
> ;;
> targz-pkg)
> - compress="gzip -c9"
> + compress="gzip"
> file_ext=".gz"
> ;;
> tarbz2-pkg)
> - compress="bzip2 -c9"
> + compress="bzip2"
> file_ext=".bz2"
> ;;
> tarxz-pkg)
> - compress="xz -c9"
> + compress="xz"
> file_ext=".xz"
> ;;
> *)
Maybe add new default compression options or rename actual ones to -hc-
(high compression) if users dont like it much?
Z.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
> Maybe add new default compression options or rename actual ones to -hc- > (high compression) if users dont like it much? Doesn't sound useful to me. The normal ones are good enough. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg
On 11.9.2012 02:46, Fengguang Wu wrote: > On Sat, Sep 08, 2012 at 12:47:59PM -0700, Andi Kleen wrote: >> From: Andi Kleen >> >> For large kernel configurations (like a distribution kernel) >> targz-pkg takes a quite long time to just do the compression. >> I clocked it at 15+mins for a SUSE kernel like config on a fast >> system. And tarxz and bzip2 are even slower. >> >> The main reason is that the script that is doing the taring sets >> the highest compression level (-9). When I change it to just >> use the defaults the gzip time for the same kernel goes down >> to ~3 mins. I haven't tested xz and bzip, but I expect those >> to be much faster too. >> >> I'm not willing to wait that long for a small compression >> gain. So just change the script to use the defaults. > > Makes sense to me. > > Reviewed-by: Fengguang Wu Applied to kbuild.git#kbuild. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
