Re: [PATCH] MIPS: loongson2: cpufreq: fix broken cpufreq

2013-07-11 Thread Viresh Kumar
On Fri, Jul 12, 2013 at 1:04 AM, Aaro Koskinen  wrote:
> Commit 42913c799 (MIPS: Loongson2: Use clk API instead of direct
> dereferences) broke the cpufreq functionality on Loongson2 boards:
> clk_set_rate() is called before the CPU frequency table is initialized,
> and therefore will always fail.
>
> Fix by moving the clk_set_rate() after the table initialization.
> Tested on Lemote FuLoong mini-PC.
>
> Signed-off-by: Aaro Koskinen 
> Cc: sta...@vger.kernel.org
> ---
>  drivers/cpufreq/loongson2_cpufreq.c | 11 ++-
>  1 file changed, 6 insertions(+), 5 deletions(-)

Ackec-by: Viresh Kumar 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] MIPS: loongson2: cpufreq: fix broken cpufreq

2013-07-11 Thread Aaro Koskinen
Commit 42913c799 (MIPS: Loongson2: Use clk API instead of direct
dereferences) broke the cpufreq functionality on Loongson2 boards:
clk_set_rate() is called before the CPU frequency table is initialized,
and therefore will always fail.

Fix by moving the clk_set_rate() after the table initialization.
Tested on Lemote FuLoong mini-PC.

Signed-off-by: Aaro Koskinen 
Cc: sta...@vger.kernel.org
---
 drivers/cpufreq/loongson2_cpufreq.c | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/cpufreq/loongson2_cpufreq.c 
b/drivers/cpufreq/loongson2_cpufreq.c
index d539127..f92b02a 100644
--- a/drivers/cpufreq/loongson2_cpufreq.c
+++ b/drivers/cpufreq/loongson2_cpufreq.c
@@ -118,11 +118,6 @@ static int loongson2_cpufreq_cpu_init(struct 
cpufreq_policy *policy)
clk_put(cpuclk);
return -EINVAL;
}
-   ret = clk_set_rate(cpuclk, rate);
-   if (ret) {
-   clk_put(cpuclk);
-   return ret;
-   }
 
/* clock table init */
for (i = 2;
@@ -130,6 +125,12 @@ static int loongson2_cpufreq_cpu_init(struct 
cpufreq_policy *policy)
 i++)
loongson2_clockmod_table[i].frequency = (rate * i) / 8;
 
+   ret = clk_set_rate(cpuclk, rate);
+   if (ret) {
+   clk_put(cpuclk);
+   return ret;
+   }
+
policy->cur = loongson2_cpufreq_get(policy->cpu);
 
cpufreq_frequency_table_get_attr(&loongson2_clockmod_table[0],
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/