Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain
On Thu, 15 Jan 2015 07:35:01 + Alexey Brodkin wrote: > Hi Clark, John, > > On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote: > > Some architectures are still stuck with non-NPTL toolchains. > > These are for example ARC, Blackfin, Xtensa etc. > > > > Still rt-tests are very good benchmarks and it would be good to enable use > > of > > at least selected (those that will be built) tests on those architectures. > > > > This change makes it possible to only build subset of tests that don't > > require > > NPTL calls. > > > > By default behavior is not modified - all tests are built, but if one wants > > to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line > > or modify "HAVE_NPTL" variable right in Makefile and execute "make". > > > > Signed-off-by: Alexey Brodkin > > Cc: Vineet Gupta > > Cc: Clark Williams > > --- > > Makefile | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 318a5c6..675edf7 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1,8 +1,13 @@ > > VERSION_STRING = 0.89 > > > > -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \ > > - ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c\ > > - pip_stress.c hackbench.c > > +HAVE_NPTL ?= yes > > + > > +ifeq ($(HAVE_NPTL),yes) > > +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c > > +endif > > + > > +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \ > > + hackbench.c > > > > TARGETS = $(sources:.c=) > > I'm wondering if there's a chance to get this patch reviewed and if > there're no objections applied? > > Regards, > Alexey Changes looked good to me. I've pulled it in and it will be in the next release. Clark pgpX8vunLzLqU.pgp Description: OpenPGP digital signature
Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain
On Thu, 15 Jan 2015 07:35:01 + Alexey Brodkin alexey.brod...@synopsys.com wrote: Hi Clark, John, On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote: Some architectures are still stuck with non-NPTL toolchains. These are for example ARC, Blackfin, Xtensa etc. Still rt-tests are very good benchmarks and it would be good to enable use of at least selected (those that will be built) tests on those architectures. This change makes it possible to only build subset of tests that don't require NPTL calls. By default behavior is not modified - all tests are built, but if one wants to build with non-NPTL toolchain just add HAVE_NPTL=no in command line or modify HAVE_NPTL variable right in Makefile and execute make. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Vineet Gupta vgu...@synopsys.com Cc: Clark Williams clark.willi...@gmail.com --- Makefile | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 318a5c6..675edf7 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,13 @@ VERSION_STRING = 0.89 -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \ - ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c\ - pip_stress.c hackbench.c +HAVE_NPTL ?= yes + +ifeq ($(HAVE_NPTL),yes) +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c +endif + +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \ + hackbench.c TARGETS = $(sources:.c=) I'm wondering if there's a chance to get this patch reviewed and if there're no objections applied? Regards, Alexey Changes looked good to me. I've pulled it in and it will be in the next release. Clark pgpX8vunLzLqU.pgp Description: OpenPGP digital signature
Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain
Hi Clark, John, On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote: > Some architectures are still stuck with non-NPTL toolchains. > These are for example ARC, Blackfin, Xtensa etc. > > Still rt-tests are very good benchmarks and it would be good to enable use of > at least selected (those that will be built) tests on those architectures. > > This change makes it possible to only build subset of tests that don't require > NPTL calls. > > By default behavior is not modified - all tests are built, but if one wants > to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line > or modify "HAVE_NPTL" variable right in Makefile and execute "make". > > Signed-off-by: Alexey Brodkin > Cc: Vineet Gupta > Cc: Clark Williams > --- > Makefile | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 318a5c6..675edf7 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,8 +1,13 @@ > VERSION_STRING = 0.89 > > -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c\ > - ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c\ > - pip_stress.c hackbench.c > +HAVE_NPTL ?= yes > + > +ifeq ($(HAVE_NPTL),yes) > +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c > +endif > + > +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \ > + hackbench.c > > TARGETS = $(sources:.c=) I'm wondering if there's a chance to get this patch reviewed and if there're no objections applied? Regards, Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Makefile: allow building selected tests with non-NPTL toolchain
Hi Clark, John, On Mon, 2014-11-10 at 10:16 +0300, Alexey Brodkin wrote: Some architectures are still stuck with non-NPTL toolchains. These are for example ARC, Blackfin, Xtensa etc. Still rt-tests are very good benchmarks and it would be good to enable use of at least selected (those that will be built) tests on those architectures. This change makes it possible to only build subset of tests that don't require NPTL calls. By default behavior is not modified - all tests are built, but if one wants to build with non-NPTL toolchain just add HAVE_NPTL=no in command line or modify HAVE_NPTL variable right in Makefile and execute make. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Vineet Gupta vgu...@synopsys.com Cc: Clark Williams clark.willi...@gmail.com --- Makefile | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 318a5c6..675edf7 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,13 @@ VERSION_STRING = 0.89 -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c\ - ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c\ - pip_stress.c hackbench.c +HAVE_NPTL ?= yes + +ifeq ($(HAVE_NPTL),yes) +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c +endif + +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \ + hackbench.c TARGETS = $(sources:.c=) I'm wondering if there's a chance to get this patch reviewed and if there're no objections applied? Regards, Alexey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Makefile: allow building selected tests with non-NPTL toolchain
Some architectures are still stuck with non-NPTL toolchains. These are for example ARC, Blackfin, Xtensa etc. Still rt-tests are very good benchmarks and it would be good to enable use of at least selected (those that will be built) tests on those architectures. This change makes it possible to only build subset of tests that don't require NPTL calls. By default behavior is not modified - all tests are built, but if one wants to build with non-NPTL toolchain just add "HAVE_NPTL=no" in command line or modify "HAVE_NPTL" variable right in Makefile and execute "make". Signed-off-by: Alexey Brodkin Cc: Vineet Gupta Cc: Clark Williams --- Makefile | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 318a5c6..675edf7 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,13 @@ VERSION_STRING = 0.89 -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \ - ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c\ - pip_stress.c hackbench.c +HAVE_NPTL ?= yes + +ifeq ($(HAVE_NPTL),yes) +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c +endif + +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \ + hackbench.c TARGETS = $(sources:.c=) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Makefile: allow building selected tests with non-NPTL toolchain
Some architectures are still stuck with non-NPTL toolchains. These are for example ARC, Blackfin, Xtensa etc. Still rt-tests are very good benchmarks and it would be good to enable use of at least selected (those that will be built) tests on those architectures. This change makes it possible to only build subset of tests that don't require NPTL calls. By default behavior is not modified - all tests are built, but if one wants to build with non-NPTL toolchain just add HAVE_NPTL=no in command line or modify HAVE_NPTL variable right in Makefile and execute make. Signed-off-by: Alexey Brodkin abrod...@synopsys.com Cc: Vineet Gupta vgu...@synopsys.com Cc: Clark Williams clark.willi...@gmail.com --- Makefile | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 318a5c6..675edf7 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,13 @@ VERSION_STRING = 0.89 -sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \ - ptsematest.c sigwaittest.c svsematest.c pmqtest.c sendme.c\ - pip_stress.c hackbench.c +HAVE_NPTL ?= yes + +ifeq ($(HAVE_NPTL),yes) +sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c +endif + +sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \ + hackbench.c TARGETS = $(sources:.c=) -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
