Re: [PATCH] PCI: mvebu: make mvebu_pci_bridge_emul_ops static

2019-10-17 Thread Lorenzo Pieralisi
On Tue, Oct 15, 2019 at 05:09:30PM +0100, Ben Dooks (Codethink) wrote:
> The mvebu_pci_bridge_emul_ops is not exported outside
> of the driver, so make it static to avoid the following
> sparse warning:
> 
> drivers/pci/controller/pci-mvebu.c:557:28: warning: symbol 
> 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks 
> ---
> Cc: Thomas Petazzoni 
> Cc: Jason Cooper 
> Cc: Lorenzo Pieralisi 
> Cc: Andrew Murray 
> Cc: Bjorn Helgaas 
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/pci/controller/pci-mvebu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/misc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pci-mvebu.c 
> b/drivers/pci/controller/pci-mvebu.c
> index d3a0419e42f2..ed032e9a3156 100644
> --- a/drivers/pci/controller/pci-mvebu.c
> +++ b/drivers/pci/controller/pci-mvebu.c
> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct 
> pci_bridge_emul *bridge,
>   }
>  }
>  
> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>   .write_base = mvebu_pci_bridge_emul_base_conf_write,
>   .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
>   .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
> -- 
> 2.23.0
> 


[PATCH] PCI: mvebu: make mvebu_pci_bridge_emul_ops static

2019-10-15 Thread Ben Dooks (Codethink)
The mvebu_pci_bridge_emul_ops is not exported outside
of the driver, so make it static to avoid the following
sparse warning:

drivers/pci/controller/pci-mvebu.c:557:28: warning: symbol 
'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks 
---
Cc: Thomas Petazzoni 
Cc: Jason Cooper 
Cc: Lorenzo Pieralisi 
Cc: Andrew Murray 
Cc: Bjorn Helgaas 
Cc: linux-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/pci/controller/pci-mvebu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-mvebu.c 
b/drivers/pci/controller/pci-mvebu.c
index d3a0419e42f2..ed032e9a3156 100644
--- a/drivers/pci/controller/pci-mvebu.c
+++ b/drivers/pci/controller/pci-mvebu.c
@@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct 
pci_bridge_emul *bridge,
}
 }
 
-struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
+static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
.write_base = mvebu_pci_bridge_emul_base_conf_write,
.read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
.write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
-- 
2.23.0