Re: [PATCH] PCI: xilinx: make of_device_ids const.

[Bjorn Helgaas]

On Tue, Jun 20, 2017 at 11:17:48AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by  work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>text  data bss dec hex filename
> 195   600   0 795 31b drivers/pci/host/pcie-xilinx.o
> 
> File size after constify xilinx_pcie_of_match:
>text  data bss dec hex filename
> 595   184   0 779 30b drivers/pci/host/pcie-xilinx.o
> 
> Signed-off-by: Arvind Yadav 

Applied to pci/host-xilinx for v4.13, thanks!

> ---
>  drivers/pci/host/pcie-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
> index 2fe2df5..b621cb5 100644
> --- a/drivers/pci/host/pcie-xilinx.c
> +++ b/drivers/pci/host/pcie-xilinx.c
> @@ -696,7 +696,7 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
>   return err;
>  }
>  
> -static struct of_device_id xilinx_pcie_of_match[] = {
> +static const struct of_device_id xilinx_pcie_of_match[] = {
>   { .compatible = "xlnx,axi-pcie-host-1.00.a", },
>   {}
>  };
> -- 
> 1.9.1
> 
> 
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] PCI: xilinx: make of_device_ids const.

[Bjorn Helgaas]

On Tue, Jun 20, 2017 at 11:17:48AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by  work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>text  data bss dec hex filename
> 195   600   0 795 31b drivers/pci/host/pcie-xilinx.o
> 
> File size after constify xilinx_pcie_of_match:
>text  data bss dec hex filename
> 595   184   0 779 30b drivers/pci/host/pcie-xilinx.o
> 
> Signed-off-by: Arvind Yadav 

Applied to pci/host-xilinx for v4.13, thanks!

> ---
>  drivers/pci/host/pcie-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
> index 2fe2df5..b621cb5 100644
> --- a/drivers/pci/host/pcie-xilinx.c
> +++ b/drivers/pci/host/pcie-xilinx.c
> @@ -696,7 +696,7 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
>   return err;
>  }
>  
> -static struct of_device_id xilinx_pcie_of_match[] = {
> +static const struct of_device_id xilinx_pcie_of_match[] = {
>   { .compatible = "xlnx,axi-pcie-host-1.00.a", },
>   {}
>  };
> -- 
> 1.9.1
> 
> 
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] PCI: xilinx: make of_device_ids const.

[Arvind Yadav]

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by  work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   textdata bss dec hex filename
195 600   0 795 31b drivers/pci/host/pcie-xilinx.o

File size after constify xilinx_pcie_of_match:
   textdata bss dec hex filename
595 184   0 779 30b drivers/pci/host/pcie-xilinx.o

Signed-off-by: Arvind Yadav 
---
 drivers/pci/host/pcie-xilinx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 2fe2df5..b621cb5 100644
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -696,7 +696,7 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
return err;
 }
 
-static struct of_device_id xilinx_pcie_of_match[] = {
+static const struct of_device_id xilinx_pcie_of_match[] = {
{ .compatible = "xlnx,axi-pcie-host-1.00.a", },
{}
 };
-- 
1.9.1

[PATCH] PCI: xilinx: make of_device_ids const.

[Arvind Yadav]

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by  work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   textdata bss dec hex filename
195 600   0 795 31b drivers/pci/host/pcie-xilinx.o

File size after constify xilinx_pcie_of_match:
   textdata bss dec hex filename
595 184   0 779 30b drivers/pci/host/pcie-xilinx.o

Signed-off-by: Arvind Yadav 
---
 drivers/pci/host/pcie-xilinx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 2fe2df5..b621cb5 100644
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -696,7 +696,7 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
return err;
 }
 
-static struct of_device_id xilinx_pcie_of_match[] = {
+static const struct of_device_id xilinx_pcie_of_match[] = {
{ .compatible = "xlnx,axi-pcie-host-1.00.a", },
{}
 };
-- 
1.9.1