On Sat, 04 Aug 2007 23:48:34 +0200
Rafa__ Bilski <[EMAIL PROTECTED]> wrote:
> I mistyped
> # echo /dev/hdc1 >/sys/module/block2mtd/parameters/block2mt
> instead of sdc1. There is no /dev/hdc1. I have DVD-ROM as /dev/hdc.
> # dmesg
> block2mtd: version $Revision: 1.30 $
> block2mtd: error: cannot open device /dev/hdc1
> Looks right, but tray is locked. And it doesn't want to get out.
> # eject
> hdc: irq timeout: status=0xd0 { Busy }
> ide: failed opcode was: unknown
> WARNING: at kernel/irq/resend.c:70 check_irq_resend()
> [] check_irq_resend+0xab/0xc0
> [] enable_irq+0x4a/0xa0
> [] ide_error+0x47/0xa0
> [] cdrom_newpc_intr+0x0/0x300
> [] ide_timer_expiry+0x1e0/0x2d0
> [] ide_timer_expiry+0x0/0x2d0
> [] run_timer_softirq+0x116/0x160
> [] hrtimer_interrupt+0x165/0x1a0
> [] __do_softirq+0x42/0x90
> [] do_softirq+0x26/0x30
> [] irq_exit+0x5a/0x60
> [] do_IRQ+0x47/0x80
> [] common_interrupt+0x23/0x30
> [] acpi_processor_idle+0x162/0x380
> [] cpu_idle+0x4e/0x70
> [] start_kernel+0x1f5/0x240
> [] unknown_bootoption+0x0/0x1e0
> ===
>
> Removing bdput from do_open() in fs/block_dev.c seems
> to be a cure for irq timeout.
>
> Signed-off-by: Rafa__ Bilski <[EMAIL PROTECTED]>
> ---
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -1120,7 +1120,6 @@ static int do_open(struct block_device *
> disk = get_gendisk(bdev->bd_dev, &part);
> if (!disk) {
> unlock_kernel();
> - bdput(bdev);
> return ret;
> }
> owner = disk->fops->owner;
>
>From my reading, this patch will fix the blkdev_get() error path, but will
break the blkdev_open() path.
It could be that we also need to add a bdput() into blkdev_open() if
do_open() failed (to balance blkdev_open()'s bd_acquire()).
It's pretty damn ugly that do_open() attempts to fix up the caller's
refcounting.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
