Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

2017-11-24 Thread Greg KH 
On Sat, Nov 18, 2017 at 06:46:38PM +0100, Fabian Baumanis wrote:
> Removed uneccessary parantheses which were sorrounding two
> if-statements.
> 
> Signed-off-by: Fabian Baumanis 
> ---
>  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
> b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 1cc9b7e..c77b994 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, 
> struct comedi_subdevice *s)
>     devpriv->ai_add_back = 0;
>     if (devpriv->master) {
>     devpriv->usedma = 1;
> -   if ((cmd->flags & CMDF_WAKE_EOS) &&
> -   (cmd->scan_end_arg == 1)) {
> +   if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {

Ick, no, now I need to remember which has higher precedence, "&" or
"&&".  It's "&" right?  I should not have to go look it up.

The code as-is is just fine.

thanks,

greg k-h

Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

2017-11-24 Thread Greg KH 
On Sat, Nov 18, 2017 at 06:46:38PM +0100, Fabian Baumanis wrote:
> Removed uneccessary parantheses which were sorrounding two
> if-statements.
> 
> Signed-off-by: Fabian Baumanis 
> ---
>  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
> b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 1cc9b7e..c77b994 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, 
> struct comedi_subdevice *s)
>     devpriv->ai_add_back = 0;
>     if (devpriv->master) {
>     devpriv->usedma = 1;
> -   if ((cmd->flags & CMDF_WAKE_EOS) &&
> -   (cmd->scan_end_arg == 1)) {
> +   if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {

Ick, no, now I need to remember which has higher precedence, "&" or
"&&".  It's "&" right?  I should not have to go look it up.

The code as-is is just fine.

thanks,

greg k-h

Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

2017-11-20 Thread Ian Abbott 

On 18/11/17 17:46, Fabian Baumanis wrote:

Removed uneccessary parantheses which were sorrounding two
if-statements.


There is only one 'if' statement changed by the patch.  Apart from that 
(and the typos in the patch description), the patch is fine as far as it 
goes.  However, the checkpatch script identifies several similar 
"unnecessary parentheses" issues in this file, and it would be better to 
take care of them all with a single patch rather than patching them one 
at a time.




Signed-off-by: Fabian Baumanis 
---
  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
b/drivers/staging/comedi/drivers/adl_pci9118.c
index 1cc9b7e..c77b994 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct 
comedi_subdevice *s)
     devpriv->ai_add_back = 0;
     if (devpriv->master) {
     devpriv->usedma = 1;
-   if ((cmd->flags & CMDF_WAKE_EOS) &&
-   (cmd->scan_end_arg == 1)) {
+   if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {
     if (cmd->convert_src == TRIG_NOW)
     devpriv->ai_add_back = 1;
     if (cmd->convert_src == TRIG_TIMER) {




--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-

Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

2017-11-20 Thread Ian Abbott 

On 18/11/17 17:46, Fabian Baumanis wrote:

Removed uneccessary parantheses which were sorrounding two
if-statements.


There is only one 'if' statement changed by the patch.  Apart from that 
(and the typos in the patch description), the patch is fine as far as it 
goes.  However, the checkpatch script identifies several similar 
"unnecessary parentheses" issues in this file, and it would be better to 
take care of them all with a single patch rather than patching them one 
at a time.




Signed-off-by: Fabian Baumanis 
---
  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
b/drivers/staging/comedi/drivers/adl_pci9118.c
index 1cc9b7e..c77b994 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct 
comedi_subdevice *s)
     devpriv->ai_add_back = 0;
     if (devpriv->master) {
     devpriv->usedma = 1;
-   if ((cmd->flags & CMDF_WAKE_EOS) &&
-   (cmd->scan_end_arg == 1)) {
+   if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {
     if (cmd->convert_src == TRIG_NOW)
     devpriv->ai_add_back = 1;
     if (cmd->convert_src == TRIG_TIMER) {




--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-

[PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

2017-11-18 Thread Fabian Baumanis 
Removed uneccessary parantheses which were sorrounding two
if-statements.

Signed-off-by: Fabian Baumanis 
---
 drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
b/drivers/staging/comedi/drivers/adl_pci9118.c
index 1cc9b7e..c77b994 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct 
comedi_subdevice *s)
    devpriv->ai_add_back = 0;
    if (devpriv->master) {
    devpriv->usedma = 1;
-   if ((cmd->flags & CMDF_WAKE_EOS) &&
-   (cmd->scan_end_arg == 1)) {
+   if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {
    if (cmd->convert_src == TRIG_NOW)
    devpriv->ai_add_back = 1;
    if (cmd->convert_src == TRIG_TIMER) {
-- 
2.7.4

[PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

2017-11-18 Thread Fabian Baumanis 
Removed uneccessary parantheses which were sorrounding two
if-statements.

Signed-off-by: Fabian Baumanis 
---
 drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
b/drivers/staging/comedi/drivers/adl_pci9118.c
index 1cc9b7e..c77b994 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct 
comedi_subdevice *s)
    devpriv->ai_add_back = 0;
    if (devpriv->master) {
    devpriv->usedma = 1;
-   if ((cmd->flags & CMDF_WAKE_EOS) &&
-   (cmd->scan_end_arg == 1)) {
+   if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {
    if (cmd->convert_src == TRIG_NOW)
    devpriv->ai_add_back = 1;
    if (cmd->convert_src == TRIG_TIMER) {
-- 
2.7.4