Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, Jan 17, 2015 at 07:11:18PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr > comment is implied by the first argument being the channel. No parent bus > comment is already understood by the argument being NULL. > > Signed-off-by: Andrew Milkovich > --- > drivers/staging/unisys/virtpci/virtpci.c | 24 > 1 file changed, 8 insertions(+), 16 deletions(-) This patch doesn't apply at all to the staging-next branch of staging.git, so I can't apply it :( thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, Jan 17, 2015 at 07:11:18PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) This patch doesn't apply at all to the staging-next branch of staging.git, so I can't apply it :( thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, Jan 17, 2015 at 08:01:52PM -0800, Joe Perches wrote: > On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. > > which ones? > > As far as I can tell, none of the checkpatch > warnings on this file are actually addressed > by this patch. > > I see, you are correct. Before there was whitespace after the inline comments, but on the staging-testing branch this has already been fixed. Thanks, I'll look into the current checkpatch.pl issues. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
comment is implied by the first argument being the channel. No parent bus
comment is already understood by the argument being NULL.
Signed-off-by: Andrew Milkovich
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 8fdfd6f..ee212f8 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -275,10 +275,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus->platform_data /* chanptr */,
- _driver_info);
- write_vbus_bus_info(vbus->platform_data /* chanptr */,
- _driver_info);
+ write_vbus_chp_info(vbus->platform_data, _driver_info);
+ write_vbus_bus_info(vbus->platform_data, _driver_info);
LOGINF("Added vbus %d; device %s created successfully\n",
addparams->bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -462,8 +460,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams->chanptr);
LOGINF("Pausing vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */, VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Paused vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -483,8 +480,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF("Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */, VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -504,8 +500,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams->chanptr);
LOGINF("Resuming vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */, VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Resumed vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -526,8 +521,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF("Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */, VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -547,8 +541,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams->chanptr);
LOGINF("Deleting vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, , NULL);
if (i) {
LOGINF("Deleted vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -570,8 +563,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF("Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */, VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF("Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
comment is implied by the first argument being the channel. No parent bus
comment is already understood by the argument being NULL.
Signed-off-by: Andrew Milkovich
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 39b828d..1bb0946 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -279,10 +279,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus->platform_data /* chanptr */ ,
- _driver_info);
- write_vbus_bus_info(vbus->platform_data /* chanptr */ ,
- _driver_info);
+ write_vbus_chp_info(vbus->platform_data, _driver_info);
+ write_vbus_bus_info(vbus->platform_data, _driver_info);
LOGINF("Added vbus %d; device %s created successfully\n",
addparams->bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -466,8 +464,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams->chanptr);
LOGINF("Pausing vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Paused vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -487,8 +484,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF("Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -508,8 +504,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams->chanptr);
LOGINF("Resuming vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Resumed vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -530,8 +525,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF("Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -551,8 +545,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams->chanptr);
LOGINF("Deleting vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, , NULL);
if (i) {
LOGINF("Deleted vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -574,8 +567,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF("Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF("Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote: > Hi, > > On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > > chanptr > > > comment is implied by the first argument being the channel. No parent bus > > > comment is already understood by the argument being NULL. > > > > > > Signed-off-by: Andrew Milkovich > > > --- > > > drivers/staging/unisys/virtpci/virtpci.c | 24 > > > 1 file changed, 8 insertions(+), 16 deletions(-) > > > > This doesn't apply to my staging-testing branch at all, sorry. > > > > greg k-h > > Processing the patch with 'git apply' complains about a corruption; this is > due > to the fact that I ran cleanfile on the patch. The checkpatch.pl script was > giving errors about trailing whitespace. I ran cleanpatch, errors still showed > up, I ran cleanfile and it passed. > > Using 'patch -p1 < patchname' seems to work. Doesn't work for me, try it against the branch above, I think it was due to other changes in this driver in my tree. If not, just resend, maybe I messed something up on my end, it has been known to happen :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Hi again, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent bus > > comment is already understood by the argument being NULL. > > > > Signed-off-by: Andrew Milkovich > > --- > > drivers/staging/unisys/virtpci/virtpci.c | 24 > > 1 file changed, 8 insertions(+), 16 deletions(-) > > This doesn't apply to my staging-testing branch at all, sorry. > > greg k-h Looks like the '-f' switch on checkpatch.pl was the reason I was getting whitespace errors. I'll resubmit the proper patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent bus > > comment is already understood by the argument being NULL. > > > > Signed-off-by: Andrew Milkovich > > --- > > drivers/staging/unisys/virtpci/virtpci.c | 24 > > 1 file changed, 8 insertions(+), 16 deletions(-) > > This doesn't apply to my staging-testing branch at all, sorry. > > greg k-h Processing the patch with 'git apply' complains about a corruption; this is due to the fact that I ran cleanfile on the patch. The checkpatch.pl script was giving errors about trailing whitespace. I ran cleanpatch, errors still showed up, I ran cleanfile and it passed. Using 'patch -p1 < patchname' seems to work. I can resubmit the patch but for 'git apply' to work it will be failing the checkpatch.pl script. What should I do in this case? Andrew Milkovich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr > comment is implied by the first argument being the channel. No parent bus > comment is already understood by the argument being NULL. > > Signed-off-by: Andrew Milkovich > --- > drivers/staging/unisys/virtpci/virtpci.c | 24 > 1 file changed, 8 insertions(+), 16 deletions(-) This doesn't apply to my staging-testing branch at all, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) This doesn't apply to my staging-testing branch at all, sorry. greg k-h Processing the patch with 'git apply' complains about a corruption; this is due to the fact that I ran cleanfile on the patch. The checkpatch.pl script was giving errors about trailing whitespace. I ran cleanpatch, errors still showed up, I ran cleanfile and it passed. Using 'patch -p1 patchname' seems to work. I can resubmit the patch but for 'git apply' to work it will be failing the checkpatch.pl script. What should I do in this case? Andrew Milkovich -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote: Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) This doesn't apply to my staging-testing branch at all, sorry. greg k-h Processing the patch with 'git apply' complains about a corruption; this is due to the fact that I ran cleanfile on the patch. The checkpatch.pl script was giving errors about trailing whitespace. I ran cleanpatch, errors still showed up, I ran cleanfile and it passed. Using 'patch -p1 patchname' seems to work. Doesn't work for me, try it against the branch above, I think it was due to other changes in this driver in my tree. If not, just resend, maybe I messed something up on my end, it has been known to happen :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
comment is implied by the first argument being the channel. No parent bus
comment is already understood by the argument being NULL.
Signed-off-by: Andrew Milkovich amilkov...@gmail.com
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 39b828d..1bb0946 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -279,10 +279,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus-platform_data /* chanptr */ ,
- chipset_driver_info);
- write_vbus_bus_info(vbus-platform_data /* chanptr */ ,
- bus_driver_info);
+ write_vbus_chp_info(vbus-platform_data, chipset_driver_info);
+ write_vbus_bus_info(vbus-platform_data, bus_driver_info);
LOGINF(Added vbus %d; device %s created successfully\n,
addparams-bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -466,8 +464,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams-chanptr);
LOGINF(Pausing vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Paused vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -487,8 +484,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF(Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -508,8 +504,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams-chanptr);
LOGINF(Resuming vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Resumed vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -530,8 +525,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF(Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -551,8 +545,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams-chanptr);
LOGINF(Deleting vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i) {
LOGINF(Deleted vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -574,8 +567,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF(Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.2.2
--
To
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
comment is implied by the first argument being the channel. No parent bus
comment is already understood by the argument being NULL.
Signed-off-by: Andrew Milkovich amilkov...@gmail.com
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 8fdfd6f..ee212f8 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -275,10 +275,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus-platform_data /* chanptr */,
- chipset_driver_info);
- write_vbus_bus_info(vbus-platform_data /* chanptr */,
- bus_driver_info);
+ write_vbus_chp_info(vbus-platform_data, chipset_driver_info);
+ write_vbus_bus_info(vbus-platform_data, bus_driver_info);
LOGINF(Added vbus %d; device %s created successfully\n,
addparams-bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -462,8 +460,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams-chanptr);
LOGINF(Pausing vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */, VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Paused vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -483,8 +480,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF(Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */, VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -504,8 +500,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams-chanptr);
LOGINF(Resuming vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */, VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Resumed vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -526,8 +521,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF(Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */, VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -547,8 +541,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams-chanptr);
LOGINF(Deleting vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i) {
LOGINF(Deleted vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -570,8 +563,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF(Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */, VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.2.2
--
To unsubscribe from
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) This doesn't apply to my staging-testing branch at all, sorry. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Sat, Jan 17, 2015 at 08:01:52PM -0800, Joe Perches wrote: On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. I see, you are correct. Before there was whitespace after the inline comments, but on the staging-testing branch this has already been fixed. Thanks, I'll look into the current checkpatch.pl issues. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Hi again, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) This doesn't apply to my staging-testing branch at all, sorry. greg k-h Looks like the '-f' switch on checkpatch.pl was the reason I was getting whitespace errors. I'll resubmit the proper patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
comment is implied by the first argument being the channel. No parent bus
comment is already understood by the argument being NULL.
Signed-off-by: Andrew Milkovich
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 39b828d..1bb0946 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -279,10 +279,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus->platform_data /* chanptr */ ,
- _driver_info);
- write_vbus_bus_info(vbus->platform_data /* chanptr */ ,
- _driver_info);
+ write_vbus_chp_info(vbus->platform_data, _driver_info);
+ write_vbus_bus_info(vbus->platform_data, _driver_info);
LOGINF("Added vbus %d; device %s created successfully\n",
addparams->bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -466,8 +464,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams->chanptr);
LOGINF("Pausing vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Paused vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -487,8 +484,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF("Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -508,8 +504,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams->chanptr);
LOGINF("Resuming vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Resumed vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -530,8 +525,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF("Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -551,8 +545,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams->chanptr);
LOGINF("Deleting vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, , NULL);
if (i) {
LOGINF("Deleted vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -574,8 +567,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF("Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF("Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
comment is implied by the first argument being the channel. No parent bus
comment is already understood by the argument being NULL.
Signed-off-by: Andrew Milkovich amilkov...@gmail.com
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 39b828d..1bb0946 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -279,10 +279,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus-platform_data /* chanptr */ ,
- chipset_driver_info);
- write_vbus_bus_info(vbus-platform_data /* chanptr */ ,
- bus_driver_info);
+ write_vbus_chp_info(vbus-platform_data, chipset_driver_info);
+ write_vbus_bus_info(vbus-platform_data, bus_driver_info);
LOGINF(Added vbus %d; device %s created successfully\n,
addparams-bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -466,8 +464,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams-chanptr);
LOGINF(Pausing vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Paused vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -487,8 +484,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF(Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -508,8 +504,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams-chanptr);
LOGINF(Resuming vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Resumed vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -530,8 +525,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF(Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -551,8 +545,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams-chanptr);
LOGINF(Deleting vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i) {
LOGINF(Deleted vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -574,8 +567,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF(Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.2.2
--
To unsubscribe
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Mon, Jan 12, 2015 at 02:53:53PM -0800, Andrew Milkovich wrote: > Hi, > > On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: > > On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: > > > Fixed coding style errors per checkpatch.pl. Inline comments removed. > > > > What coding errors did you fix? Please be specific. > > Some inline comments were removed. Some talked about chanptr, which is known > because the first argument is the chan. > > The other comments talked about no parent bus, but NULL signifies that there > is > no parent bus. I was trying to hint that this needs to be in the changelog entry... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Hi, On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: > On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed. > > What coding errors did you fix? Please be specific. Some inline comments were removed. Some talked about chanptr, which is known because the first argument is the chan. The other comments talked about no parent bus, but NULL signifies that there is no parent bus. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Hi, On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. Some inline comments were removed. Some talked about chanptr, which is known because the first argument is the chan. The other comments talked about no parent bus, but NULL signifies that there is no parent bus. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Mon, Jan 12, 2015 at 02:53:53PM -0800, Andrew Milkovich wrote: Hi, On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. Some inline comments were removed. Some talked about chanptr, which is known because the first argument is the chan. The other comments talked about no parent bus, but NULL signifies that there is no parent bus. I was trying to hint that this needs to be in the changelog entry... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed.
Signed-off-by: Andrew Milkovich
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 39b828d..1bb0946 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -279,10 +279,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus->platform_data /* chanptr */ ,
- _driver_info);
- write_vbus_bus_info(vbus->platform_data /* chanptr */ ,
- _driver_info);
+ write_vbus_chp_info(vbus->platform_data, _driver_info);
+ write_vbus_bus_info(vbus->platform_data, _driver_info);
LOGINF("Added vbus %d; device %s created successfully\n",
addparams->bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -466,8 +464,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams->chanptr);
LOGINF("Pausing vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Paused vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -487,8 +484,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF("Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -508,8 +504,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams->chanptr);
LOGINF("Resuming vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, , NULL);
if (i)
LOGINF("Resumed vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -530,8 +525,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF("Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(" Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -551,8 +545,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams->chanptr);
LOGINF("Deleting vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTHBA_TYPE,
- , NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, , NULL);
if (i) {
LOGINF("Deleted vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -574,8 +567,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF("Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF("Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n",
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
[PATCH] Staging: unisys: virtpci: fixed coding style errors
Fixed coding style errors per checkpatch.pl. Inline comments removed.
Signed-off-by: Andrew Milkovich amilkov...@gmail.com
---
drivers/staging/unisys/virtpci/virtpci.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index 39b828d..1bb0946 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -279,10 +279,8 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0;
}
- write_vbus_chp_info(vbus-platform_data /* chanptr */ ,
- chipset_driver_info);
- write_vbus_bus_info(vbus-platform_data /* chanptr */ ,
- bus_driver_info);
+ write_vbus_chp_info(vbus-platform_data, chipset_driver_info);
+ write_vbus_bus_info(vbus-platform_data, bus_driver_info);
LOGINF(Added vbus %d; device %s created successfully\n,
addparams-bus_no, BUS_ID(vbus));
POSTCODE_LINUX_2(VPCI_CREATE_EXIT_PC, POSTCODE_SEVERITY_INFO);
@@ -466,8 +464,7 @@ static int pause_vhba(struct pause_virt_guestpart
*pauseparams)
GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams-chanptr);
LOGINF(Pausing vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverdown(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Paused vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -487,8 +484,7 @@ static int pause_vnic(struct pause_virt_guestpart
*pauseparams)
LOGINF(Pausing vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverdown(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Paused vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -508,8 +504,7 @@ static int resume_vhba(struct resume_virt_guestpart
*resumeparams)
GET_SCSIADAPINFO_FROM_CHANPTR(resumeparams-chanptr);
LOGINF(Resuming vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_serverup(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i)
LOGINF(Resumed vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -530,8 +525,7 @@ resume_vnic(struct resume_virt_guestpart *resumeparams)
LOGINF(Resuming vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_serverup(NULL /*no parent bus */ , VIRTNIC_TYPE,
- NULL, net.mac_addr);
+ i = virtpci_device_serverup(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF( Resumed vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
@@ -551,8 +545,7 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
GET_SCSIADAPINFO_FROM_CHANPTR(delparams-chanptr);
LOGINF(Deleting vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTHBA_TYPE,
- scsi.wwnn, NULL);
+ i = virtpci_device_del(NULL, VIRTHBA_TYPE, scsi.wwnn, NULL);
if (i) {
LOGINF(Deleted vhba wwnn:%x:%x\n, scsi.wwnn.wwnn1,
scsi.wwnn.wwnn2);
@@ -574,8 +567,7 @@ static int delete_vnic(struct del_virt_guestpart *delparams)
LOGINF(Deleting vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
net.mac_addr[3], net.mac_addr[4], net.mac_addr[5]);
- i = virtpci_device_del(NULL /*no parent bus */ , VIRTNIC_TYPE, NULL,
- net.mac_addr);
+ i = virtpci_device_del(NULL, VIRTNIC_TYPE, NULL, net.mac_addr);
if (i) {
LOGINF(Deleted vnic macaddr:%02x:%02x:%02x:%02x:%02x:%02x\n,
net.mac_addr[0], net.mac_addr[1], net.mac_addr[2],
--
2.1.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
