Re: [PATCH] Various cleanups/fixes to zcache (v3).
On Thu, Feb 14, 2013 at 09:29:26AM -0800, Greg KH wrote:
> On Thu, Feb 14, 2013 at 09:02:47AM -0800, Dan Magenheimer wrote:
> > > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > > Subject: Re: [PATCH] Various cleanups/fixes to zcache (v3).
> > >
> > > On Thu, Feb 14, 2013 at 08:56:01AM -0800, Dan Magenheimer wrote:
> > > > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> > > > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > > >
> > > > > From Konrad Rzeszutek Wilk # This line is
> > > > > ignored.
> > > > > From: Konrad Rzeszutek Wilk
> > > > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > > > In-Reply-To:
> > > > >
> > > > > Hey Greg,
> > > > >
> > > > > These patches do various cleanups of the zcache driver. The majority
> > > > > of the
> > > > > work is just to move all the different counters out to a debug file.
> > > > > The next
> > > > > step would be to figure out which ones are actually pertient and
> > > > > which can
> > > > > go under the knife. Oh, and also fix some of the compiler warnings.
> > > > >
> > > > > This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
> > > > > ("staging/zcache: Fix/improve zcache writeback code, tie to a config
> > > > > option")
> > > > > so should apply cleanly to your tree.
> > > > >
> > > > > Please apply.
> > > >
> > > > Useful cleanups.
> > > >
> > > > Hopefully not too late for 3.9-rc0.
> > >
> > > You all did see my "the staging tree is closed except for bugfixes for
> > > 3.9" message last week, right?
> >
> > Oops, sorry, no I missed that.
> >
> > > Sorry, this will have to wait for 3.10.
> >
> > No problem, no bugs fixed here, though I expect we'll see
> > the same complaints posted again about the compiler warnings.
>
> Then why not just redo that one patch, and send it to me, and then
> rebase all of the other patches on top of it? That way I can accept the
> "fix the complier warnings" patch now, and the rest can wait.
Aye aye captain. Going to send them tomorrow (zbud/zcache).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Various cleanups/fixes to zcache (v3).
On Thu, Feb 14, 2013 at 09:02:47AM -0800, Dan Magenheimer wrote:
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Subject: Re: [PATCH] Various cleanups/fixes to zcache (v3).
> >
> > On Thu, Feb 14, 2013 at 08:56:01AM -0800, Dan Magenheimer wrote:
> > > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> > > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > >
> > > > From Konrad Rzeszutek Wilk # This line is
> > > > ignored.
> > > > From: Konrad Rzeszutek Wilk
> > > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > > In-Reply-To:
> > > >
> > > > Hey Greg,
> > > >
> > > > These patches do various cleanups of the zcache driver. The majority of
> > > > the
> > > > work is just to move all the different counters out to a debug file.
> > > > The next
> > > > step would be to figure out which ones are actually pertient and which
> > > > can
> > > > go under the knife. Oh, and also fix some of the compiler warnings.
> > > >
> > > > This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
> > > > ("staging/zcache: Fix/improve zcache writeback code, tie to a config
> > > > option")
> > > > so should apply cleanly to your tree.
> > > >
> > > > Please apply.
> > >
> > > Useful cleanups.
> > >
> > > Hopefully not too late for 3.9-rc0.
> >
> > You all did see my "the staging tree is closed except for bugfixes for
> > 3.9" message last week, right?
>
> Oops, sorry, no I missed that.
>
> > Sorry, this will have to wait for 3.10.
>
> No problem, no bugs fixed here, though I expect we'll see
> the same complaints posted again about the compiler warnings.
Then why not just redo that one patch, and send it to me, and then
rebase all of the other patches on top of it? That way I can accept the
"fix the complier warnings" patch now, and the rest can wait.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] Various cleanups/fixes to zcache (v3).
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Subject: Re: [PATCH] Various cleanups/fixes to zcache (v3).
>
> On Thu, Feb 14, 2013 at 08:56:01AM -0800, Dan Magenheimer wrote:
> > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > >
> > > From Konrad Rzeszutek Wilk # This line is
> > > ignored.
> > > From: Konrad Rzeszutek Wilk
> > > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > > In-Reply-To:
> > >
> > > Hey Greg,
> > >
> > > These patches do various cleanups of the zcache driver. The majority of
> > > the
> > > work is just to move all the different counters out to a debug file. The
> > > next
> > > step would be to figure out which ones are actually pertient and which can
> > > go under the knife. Oh, and also fix some of the compiler warnings.
> > >
> > > This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
> > > ("staging/zcache: Fix/improve zcache writeback code, tie to a config
> > > option")
> > > so should apply cleanly to your tree.
> > >
> > > Please apply.
> >
> > Useful cleanups.
> >
> > Hopefully not too late for 3.9-rc0.
>
> You all did see my "the staging tree is closed except for bugfixes for
> 3.9" message last week, right?
Oops, sorry, no I missed that.
> Sorry, this will have to wait for 3.10.
No problem, no bugs fixed here, though I expect we'll see
the same complaints posted again about the compiler warnings.
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Various cleanups/fixes to zcache (v3).
On Thu, Feb 14, 2013 at 08:56:01AM -0800, Dan Magenheimer wrote:
> > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> >
> > From Konrad Rzeszutek Wilk # This line is ignored.
> > From: Konrad Rzeszutek Wilk
> > Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> > In-Reply-To:
> >
> > Hey Greg,
> >
> > These patches do various cleanups of the zcache driver. The majority of the
> > work is just to move all the different counters out to a debug file. The
> > next
> > step would be to figure out which ones are actually pertient and which can
> > go under the knife. Oh, and also fix some of the compiler warnings.
> >
> > This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
> > ("staging/zcache: Fix/improve zcache writeback code, tie to a config
> > option")
> > so should apply cleanly to your tree.
> >
> > Please apply.
>
> Useful cleanups.
>
> Hopefully not too late for 3.9-rc0.
You all did see my "the staging tree is closed except for bugfixes for
3.9" message last week, right?
Sorry, this will have to wait for 3.10.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] Various cleanups/fixes to zcache (v3).
> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> Subject: [PATCH] Various cleanups/fixes to zcache (v3).
>
> From Konrad Rzeszutek Wilk # This line is ignored.
> From: Konrad Rzeszutek Wilk
> Subject: [PATCH] Various cleanups/fixes to zcache (v3).
> In-Reply-To:
>
> Hey Greg,
>
> These patches do various cleanups of the zcache driver. The majority of the
> work is just to move all the different counters out to a debug file. The next
> step would be to figure out which ones are actually pertient and which can
> go under the knife. Oh, and also fix some of the compiler warnings.
>
> This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
> ("staging/zcache: Fix/improve zcache writeback code, tie to a config option")
> so should apply cleanly to your tree.
>
> Please apply.
Useful cleanups.
Hopefully not too late for 3.9-rc0.
Acked-by: Dan Magenheimer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Various cleanups/fixes to zcache (v3).
>From Konrad Rzeszutek Wilk # This line is ignored.
From: Konrad Rzeszutek Wilk
Subject: [PATCH] Various cleanups/fixes to zcache (v3).
In-Reply-To:
Hey Greg,
These patches do various cleanups of the zcache driver. The majority of the
work is just to move all the different counters out to a debug file. The next
step would be to figure out which ones are actually pertient and which can
go under the knife. Oh, and also fix some of the compiler warnings.
This is based on top of ommit 76426daf50d5df38893cc189e9ccd026093debc8
("staging/zcache: Fix/improve zcache writeback code, tie to a config option")
so should apply cleanly to your tree.
Please apply.
These patches are also available on this git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/mm.git
devel/zcache.cleanup.v2.5
if you would prefer to pull them.
drivers/staging/zcache/Kconfig | 8 +
drivers/staging/zcache/Makefile | 1 +
drivers/staging/zcache/debug.c | 71 ++
drivers/staging/zcache/debug.h | 229 ++
drivers/staging/zcache/ramster/ramster.c | 34 +--
drivers/staging/zcache/zbud.c| 130 ++
drivers/staging/zcache/zcache-main.c | 401 ---
7 files changed, 501 insertions(+), 373 deletions(-)
Konrad Rzeszutek Wilk (16):
zcache: s/int/bool/ on the various options.
zcache: Provide accessory functions for counter increase
zcache: Provide accessory functions for counter decrease.
zcache: The last of the atomic reads has now an accessory function.
zcache: Fix compile warnings due to usage of debugfs_create_size_t
zcache: Make the debug code use pr_debug
zcache: Move debugfs code out of zcache-main.c file.
zcache/debug: Use an array to initialize/use debugfs attributes.
zcache: Move the last of the debugfs counters out
zcache: Module license is defined twice.
zcache/debug: Coalesce all debug under CONFIG_ZCACHE_DEBUG
zcache/zbud: Fix compiler warnings.
zcache/zbud: Add incremental accessory counters
zcache/zbud: Provide the accessory functions for counter decrease.
ramster: Fix compile warnings due to usage of debugfs_create_size_t
zcache/zbud: Fix __init mismatch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
