Re: [PATCH] X86: Update alignment when 4K stacks are used.
On Mon 2007-06-25 06:43:37, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
>
> ---
>
> it's not clear from MAINTAINERS who's responsible for something this
> generic.
I'd cc andi here...
Pavel
> diff --git a/arch/i386/kernel/irq.c b/arch/i386/kernel/irq.c
> index d2daf67..504f134 100644
> --- a/arch/i386/kernel/irq.c
> +++ b/arch/i386/kernel/irq.c
> @@ -149,15 +149,11 @@ fastcall unsigned int do_IRQ(struct pt_regs *regs)
>
> #ifdef CONFIG_4KSTACKS
>
> -/*
> - * These should really be __section__(".bss.page_aligned") as well, but
> - * gcc's 3.0 and earlier don't handle that correctly.
> - */
> static char softirq_stack[NR_CPUS * THREAD_SIZE]
> - __attribute__((__aligned__(THREAD_SIZE)));
> + __attribute__((__section__(".bss.page_aligned")));
>
> static char hardirq_stack[NR_CPUS * THREAD_SIZE]
> - __attribute__((__aligned__(THREAD_SIZE)));
> + __attribute__((__section__(".bss.page_aligned")));
>
> /*
> * allocate per-cpu stacks for hardirq and for softirq processing
> --
>
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] X86: Update alignment when 4K stacks are used.
On Mon 2007-06-25 06:43:37, Robert P. J. Day wrote: Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- it's not clear from MAINTAINERS who's responsible for something this generic. I'd cc andi here... Pavel diff --git a/arch/i386/kernel/irq.c b/arch/i386/kernel/irq.c index d2daf67..504f134 100644 --- a/arch/i386/kernel/irq.c +++ b/arch/i386/kernel/irq.c @@ -149,15 +149,11 @@ fastcall unsigned int do_IRQ(struct pt_regs *regs) #ifdef CONFIG_4KSTACKS -/* - * These should really be __section__(.bss.page_aligned) as well, but - * gcc's 3.0 and earlier don't handle that correctly. - */ static char softirq_stack[NR_CPUS * THREAD_SIZE] - __attribute__((__aligned__(THREAD_SIZE))); + __attribute__((__section__(.bss.page_aligned))); static char hardirq_stack[NR_CPUS * THREAD_SIZE] - __attribute__((__aligned__(THREAD_SIZE))); + __attribute__((__section__(.bss.page_aligned))); /* * allocate per-cpu stacks for hardirq and for softirq processing -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] X86: Update alignment when 4K stacks are used.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
it's not clear from MAINTAINERS who's responsible for something this
generic.
diff --git a/arch/i386/kernel/irq.c b/arch/i386/kernel/irq.c
index d2daf67..504f134 100644
--- a/arch/i386/kernel/irq.c
+++ b/arch/i386/kernel/irq.c
@@ -149,15 +149,11 @@ fastcall unsigned int do_IRQ(struct pt_regs *regs)
#ifdef CONFIG_4KSTACKS
-/*
- * These should really be __section__(".bss.page_aligned") as well, but
- * gcc's 3.0 and earlier don't handle that correctly.
- */
static char softirq_stack[NR_CPUS * THREAD_SIZE]
- __attribute__((__aligned__(THREAD_SIZE)));
+ __attribute__((__section__(".bss.page_aligned")));
static char hardirq_stack[NR_CPUS * THREAD_SIZE]
- __attribute__((__aligned__(THREAD_SIZE)));
+ __attribute__((__section__(".bss.page_aligned")));
/*
* allocate per-cpu stacks for hardirq and for softirq processing
--
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] X86: Update alignment when 4K stacks are used.
Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- it's not clear from MAINTAINERS who's responsible for something this generic. diff --git a/arch/i386/kernel/irq.c b/arch/i386/kernel/irq.c index d2daf67..504f134 100644 --- a/arch/i386/kernel/irq.c +++ b/arch/i386/kernel/irq.c @@ -149,15 +149,11 @@ fastcall unsigned int do_IRQ(struct pt_regs *regs) #ifdef CONFIG_4KSTACKS -/* - * These should really be __section__(.bss.page_aligned) as well, but - * gcc's 3.0 and earlier don't handle that correctly. - */ static char softirq_stack[NR_CPUS * THREAD_SIZE] - __attribute__((__aligned__(THREAD_SIZE))); + __attribute__((__section__(.bss.page_aligned))); static char hardirq_stack[NR_CPUS * THREAD_SIZE] - __attribute__((__aligned__(THREAD_SIZE))); + __attribute__((__section__(.bss.page_aligned))); /* * allocate per-cpu stacks for hardirq and for softirq processing -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
