Re: [PATCH] android/ion: fix error return code in opensocket()

[wanghai (M)]

There is a syntax problem with this patch, please ignore it!

在 2020/11/18 18:39, Wang Hai 写道:

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 47a18c42d992 ("android/ion: userspace test utility for ion buffer 
sharing")
Reported-by: Hulk Robot 
Signed-off-by: Wang Hai 
---
  tools/testing/selftests/android/ion/ipcsocket.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/android/ion/ipcsocket.c 
b/tools/testing/selftests/android/ion/ipcsocket.c
index 7dc521002095..268e6b610357 100644
--- a/tools/testing/selftests/android/ion/ipcsocket.c
+++ b/tools/testing/selftests/android/ion/ipcsocket.c
@@ -28,8 +28,9 @@ int opensocket(int *sockfd, const char *name, int connecttype)
}
  
  	*sockfd = ret;

-   if (setsockopt(*sockfd, SOL_SOCKET, SO_REUSEADDR,
-   (char *), sizeof(int)) < 0) {
+   ret = setsockopt(*sockfd, SOL_SOCKET, SO_REUSEADDR, (char *),
+sizeof(int))
+   if (ret < 0) {
fprintf(stderr, "<%s>: Failed setsockopt: <%s>\n",
__func__, strerror(errno));
goto err;

[PATCH] android/ion: fix error return code in opensocket()

[Wang Hai]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 47a18c42d992 ("android/ion: userspace test utility for ion buffer 
sharing")
Reported-by: Hulk Robot 
Signed-off-by: Wang Hai 
---
 tools/testing/selftests/android/ion/ipcsocket.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/android/ion/ipcsocket.c 
b/tools/testing/selftests/android/ion/ipcsocket.c
index 7dc521002095..268e6b610357 100644
--- a/tools/testing/selftests/android/ion/ipcsocket.c
+++ b/tools/testing/selftests/android/ion/ipcsocket.c
@@ -28,8 +28,9 @@ int opensocket(int *sockfd, const char *name, int connecttype)
}
 
*sockfd = ret;
-   if (setsockopt(*sockfd, SOL_SOCKET, SO_REUSEADDR,
-   (char *), sizeof(int)) < 0) {
+   ret = setsockopt(*sockfd, SOL_SOCKET, SO_REUSEADDR, (char *),
+sizeof(int))
+   if (ret < 0) {
fprintf(stderr, "<%s>: Failed setsockopt: <%s>\n",
__func__, strerror(errno));
goto err;
-- 
2.17.1