Re: [PATCH] arm64: dts: hikey: Fix eMMC corruption regression
Hi John, On 2018/5/26 4:10, John Stultz wrote: > This patch is a partial revert of commit > abd7d0972a19 ("arm64: dts: hikey: Enable HS200 mode on eMMC") > > which has been causing eMMC corruption on my HiKey board. > > Symptoms usually looked like: > > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > ... > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc0: new HS200 MMC card at address 0001 > ... > dwmmc_k3 f723d000.dwmmc0: Unexpected command timeout, state 3 > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > print_req_error: I/O error, dev mmcblk0, sector 8810504 > Aborting journal on device mmcblk0p10-8. > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > EXT4-fs error (device mmcblk0p10): ext4_journal_check_start:61: Detected > aborted journal > EXT4-fs (mmcblk0p10): Remounting filesystem read-only > > And quite often this would result in a disk that wouldn't properly > boot even with older kernels. > > It seems the max-frequency property added by the above patch is > causing the problem, so remove it. > > Cc: Ryan Grachek > Cc: Wei Xu > Cc: Arnd Bergmann > Cc: Ulf Hansson > Cc: YongQin Liu > Cc: Leo Yan > Signed-off-by: John Stultz Thanks! Applied to the hisilicon fix tree. Best Regards, Wei > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 724a0d3..edb4ee0 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -299,7 +299,6 @@ > /* GPIO blocks 16 thru 19 do not appear to be routed to pins */ > > dwmmc_0: dwmmc0@f723d000 { > - max-frequency = <15000>; > cap-mmc-highspeed; > mmc-hs200-1_8v; > non-removable; >
Re: [PATCH] arm64: dts: hikey: Fix eMMC corruption regression
On Fri, May 25, 2018 at 08:10:47PM -0700, John Stultz wrote: > This patch is a partial revert of commit > abd7d0972a19 ("arm64: dts: hikey: Enable HS200 mode on eMMC") > > which has been causing eMMC corruption on my HiKey board. > > Symptoms usually looked like: > > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > ... > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc0: new HS200 MMC card at address 0001 > ... > dwmmc_k3 f723d000.dwmmc0: Unexpected command timeout, state 3 > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > print_req_error: I/O error, dev mmcblk0, sector 8810504 > Aborting journal on device mmcblk0p10-8. > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual > 40HZ div = 31) > mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual > 14880HZ div = 0) > EXT4-fs error (device mmcblk0p10): ext4_journal_check_start:61: Detected > aborted journal > EXT4-fs (mmcblk0p10): Remounting filesystem read-only > > And quite often this would result in a disk that wouldn't properly > boot even with older kernels. I tested this patch on the kernel 4.17.0-rc5, I don't see booting issue with this patch. Tested-by: Leo Yan > It seems the max-frequency property added by the above patch is > causing the problem, so remove it. Should Cc this patch to stable kernel mailing list as fixing? > Cc: Ryan Grachek > Cc: Wei Xu > Cc: Arnd Bergmann > Cc: Ulf Hansson > Cc: YongQin Liu > Cc: Leo Yan > Signed-off-by: John Stultz > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 724a0d3..edb4ee0 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -299,7 +299,6 @@ > /* GPIO blocks 16 thru 19 do not appear to be routed to pins */ > > dwmmc_0: dwmmc0@f723d000 { > - max-frequency = <15000>; > cap-mmc-highspeed; > mmc-hs200-1_8v; > non-removable; > -- > 2.7.4 >
[PATCH] arm64: dts: hikey: Fix eMMC corruption regression
This patch is a partial revert of commit abd7d0972a19 ("arm64: dts: hikey: Enable HS200 mode on eMMC") which has been causing eMMC corruption on my HiKey board. Symptoms usually looked like: mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) ... mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) mmc0: new HS200 MMC card at address 0001 ... dwmmc_k3 f723d000.dwmmc0: Unexpected command timeout, state 3 mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) print_req_error: I/O error, dev mmcblk0, sector 8810504 Aborting journal on device mmcblk0p10-8. mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 2480Hz (slot req 40Hz, actual 40HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 14880Hz (slot req 15000Hz, actual 14880HZ div = 0) EXT4-fs error (device mmcblk0p10): ext4_journal_check_start:61: Detected aborted journal EXT4-fs (mmcblk0p10): Remounting filesystem read-only And quite often this would result in a disk that wouldn't properly boot even with older kernels. It seems the max-frequency property added by the above patch is causing the problem, so remove it. Cc: Ryan Grachek Cc: Wei Xu Cc: Arnd Bergmann Cc: Ulf Hansson Cc: YongQin Liu Cc: Leo Yan Signed-off-by: John Stultz --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts index 724a0d3..edb4ee0 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts @@ -299,7 +299,6 @@ /* GPIO blocks 16 thru 19 do not appear to be routed to pins */ dwmmc_0: dwmmc0@f723d000 { - max-frequency = <15000>; cap-mmc-highspeed; mmc-hs200-1_8v; non-removable; -- 2.7.4