Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

[Shawn Guo]

On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> The offset of the reset request register is 0, the absolute address is
> 0x1e6. Boards without PSCI support will fail to perform a reset:
> 
> [   26.734700] reboot: Restarting system
> [   27.743259] Unable to restart system
> [   27.746845] Reboot failed -- System halted
> 
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle 

Applied, thanks.

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

[Michael Walle]

Hi Shawn,

Am 2021-01-07 07:40, schrieb Shawn Guo:

On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:

The offset of the reset request register is 0, the absolute address is
0x1e6. Boards without PSCI support will fail to perform a reset:

[   26.734700] reboot: Restarting system
[   27.743259] Unable to restart system
[   27.746845] Reboot failed -- System halted

Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
Signed-off-by: Michael Walle 


Out of curiosity, how did you get it fixed with your commit 
3f0fb37b22b4

("arm64: dts: ls1028a: fix reboot node") in the first place?


I simply must have missed it. There is also a fallback reset method
via the watchdog in the chain, which kicks in if this wasn't successful.
So if you test it, it is easy to think its working although its not.

-michael

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

[Shawn Guo]

On Thu, Jan 7, 2021 at 2:40 PM Shawn Guo  wrote:
>
> On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> > The offset of the reset request register is 0, the absolute address is
> > 0x1e6. Boards without PSCI support will fail to perform a reset:
> >
> > [   26.734700] reboot: Restarting system
> > [   27.743259] Unable to restart system
> > [   27.746845] Reboot failed -- System halted
> >
> > Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> > Signed-off-by: Michael Walle 
>
> Out of curiosity, how did you get it fixed with your commit 3f0fb37b22b4

How did you *not*, I meant.

Shawn

> ("arm64: dts: ls1028a: fix reboot node") in the first place?

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

[Shawn Guo]

On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> The offset of the reset request register is 0, the absolute address is
> 0x1e6. Boards without PSCI support will fail to perform a reset:
> 
> [   26.734700] reboot: Restarting system
> [   27.743259] Unable to restart system
> [   27.746845] Reboot failed -- System halted
> 
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle 

Out of curiosity, how did you get it fixed with your commit 3f0fb37b22b4
("arm64: dts: ls1028a: fix reboot node") in the first place?

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 045739dbcb17..0a5923e96d7f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -102,7 +102,7 @@
>   reboot {
>   compatible ="syscon-reboot";
>   regmap = <&rst>;
> - offset = <0xb0>;
> + offset = <0>;
>   mask = <0x02>;
>   };
>  
> -- 
> 2.20.1
> 

[PATCH] arm64: dts: ls1028a: fix the offset of the reset register

[Michael Walle]

The offset of the reset request register is 0, the absolute address is
0x1e6. Boards without PSCI support will fail to perform a reset:

[   26.734700] reboot: Restarting system
[   27.743259] Unable to restart system
[   27.746845] Reboot failed -- System halted

Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
Signed-off-by: Michael Walle 
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi 
b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 045739dbcb17..0a5923e96d7f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -102,7 +102,7 @@
reboot {
compatible ="syscon-reboot";
regmap = <&rst>;
-   offset = <0xb0>;
+   offset = <0>;
mask = <0x02>;
};
 
-- 
2.20.1