Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

[Bjorn Andersson]

On Thu, 27 Jun 2024 15:15:54 +0200, Luca Weiss wrote:
> Without explicitly specifying names for the regulators they are named
> based on the DeviceTree node name. This results in multiple regulators
> with the same name, making debug prints and regulator_summary impossible
> to reason about.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators
  commit: d870196e3383b92179dfc051fe6f038df9a94ea9

Best regards,
-- 
Bjorn Andersson 

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

[Konrad Dybcio]

On 27.06.2024 3:15 PM, Luca Weiss wrote:
> Without explicitly specifying names for the regulators they are named
> based on the DeviceTree node name. This results in multiple regulators
> with the same name, making debug prints and regulator_summary impossible
> to reason about.
> 
> Signed-off-by: Luca Weiss 
> ---

Reviewed-by: Konrad Dybcio 

Konrad

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

[Dmitry Baryshkov]

On Thu, Jun 27, 2024 at 03:15:54PM GMT, Luca Weiss wrote:
> Without explicitly specifying names for the regulators they are named
> based on the DeviceTree node name. This results in multiple regulators
> with the same name, making debug prints and regulator_summary impossible
> to reason about.
> 
> Signed-off-by: Luca Weiss 
> ---
>  arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 34 
> +++
>  1 file changed, 34 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov 

-- 
With best wishes
Dmitry

[PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

[Luca Weiss]

Without explicitly specifying names for the regulators they are named
based on the DeviceTree node name. This results in multiple regulators
with the same name, making debug prints and regulator_summary impossible
to reason about.

Signed-off-by: Luca Weiss 
---
 arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 34 +++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts 
b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
index a74f3ac09a5e..4e67bb80a026 100644
--- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
+++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
@@ -150,124 +150,145 @@ regulators-0 {
qcom,pmic-id = "a";
 
vreg_s1a: smps1 {
+   regulator-name = "vreg_s1a";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <120>;
};
 
vreg_s2a: smps2 {
+   regulator-name = "vreg_s2a";
regulator-min-microvolt = <1503000>;
regulator-max-microvolt = <2048000>;
};
 
vreg_l2a: ldo2 {
+   regulator-name = "vreg_l2a";
regulator-min-microvolt = <1503000>;
regulator-max-microvolt = <198>;
regulator-initial-mode = ;
};
 
vreg_l3a: ldo3 {
+   regulator-name = "vreg_l3a";
regulator-min-microvolt = <270>;
regulator-max-microvolt = <330>;
regulator-initial-mode = ;
};
 
vreg_l4a: ldo4 {
+   regulator-name = "vreg_l4a";
regulator-min-microvolt = <352000>;
regulator-max-microvolt = <801000>;
regulator-initial-mode = ;
};
 
vreg_l5a: ldo5 {
+   regulator-name = "vreg_l5a";
regulator-min-microvolt = <1503000>;
regulator-max-microvolt = <198>;
regulator-initial-mode = ;
};
 
vreg_l6a: ldo6 {
+   regulator-name = "vreg_l6a";
regulator-min-microvolt = <171>;
regulator-max-microvolt = <3544000>;
regulator-initial-mode = ;
};
 
vreg_l7a: ldo7 {
+   regulator-name = "vreg_l7a";
regulator-min-microvolt = <162>;
regulator-max-microvolt = <198>;
regulator-initial-mode = ;
};
 
vreg_l8a: ldo8 {
+   regulator-name = "vreg_l8a";
regulator-min-microvolt = <280>;
regulator-max-microvolt = <280>;
regulator-initial-mode = ;
};
 
vreg_l9a: ldo9 {
+   regulator-name = "vreg_l9a";
regulator-min-microvolt = <165>;
regulator-max-microvolt = <3401000>;
regulator-initial-mode = ;
};
 
vreg_l11a: ldo11 {
+   regulator-name = "vreg_l11a";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <200>;
regulator-initial-mode = ;
};
 
vreg_l12a: ldo12 {
+   regulator-name = "vreg_l12a";
regulator-min-microvolt = <162>;
regulator-max-microvolt = <198>;
regulator-initial-mode = ;
};
 
vreg_l13a: ldo13 {
+   regulator-name = "vreg_l13a";
regulator-min-microvolt = <57>;
regulator-max-microvolt = <65>;
regulator-initial-mode = ;
};
 
vreg_l14a: ldo14 {
+   regulator-name = "vreg_l14a";
regulator-min-microvolt = <170>;
regulator-max-microvolt = <190>;
regulator-initial-mode = ;
};
 
vreg_l15a: ldo15 {
+   regulator-name = "vreg_l15a";
regulator-min-microvolt = <110>;
regulator-max-microvolt = <1305000>;
regulator-initial-mode = ;
};
 
vreg_l16a: ldo16 {
+   regulator-name = "vreg_l16a";
regulator-min-microvolt = <83>;