Re: [PATCH] blackfin idle: Fix compile error

[Rafael J. Wysocki]

On Thursday, February 21, 2013 10:56:43 AM Lars-Peter Clausen wrote:
> Commit 26bab0c ("blackfin idle: delete pm_idle") introduced the following
> compile error:
>   arch/blackfin/kernel/process.c: In function ‘cpu_idle’:
>   arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use 
> in this function)
>   arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier 
> is reported only once
>   arch/blackfin/kernel/process.c:83: error: for each function it appears 
> in.)
>   arch/blackfin/kernel/process.c:88: error: implicit declaration of 
> function ‘idle’
> 
> This patch fixes it.
> 
> Signed-off-by: Lars-Peter Clausen 

Applied to linux-pm.git/linux-next, I'm going to push it to Linus later this
week.

Thanks,
Rafael


> ---
>  arch/blackfin/kernel/process.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
> index 8061426..9782c03 100644
> --- a/arch/blackfin/kernel/process.c
> +++ b/arch/blackfin/kernel/process.c
> @@ -80,12 +80,10 @@ void cpu_idle(void)
>   if (cpu_is_offline(smp_processor_id()))
>   cpu_die();
>  #endif
> - if (!idle)
> - idle = default_idle;
>   tick_nohz_idle_enter();
>   rcu_idle_enter();
>   while (!need_resched())
> - idle();
> + default_idle();
>   rcu_idle_exit();
>   tick_nohz_idle_exit();
>   preempt_enable_no_resched();
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] blackfin idle: Fix compile error

[Lars-Peter Clausen]

Commit 26bab0c ("blackfin idle: delete pm_idle") introduced the following
compile error:
arch/blackfin/kernel/process.c: In function ‘cpu_idle’:
arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use 
in this function)
arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier 
is reported only once
arch/blackfin/kernel/process.c:83: error: for each function it appears 
in.)
arch/blackfin/kernel/process.c:88: error: implicit declaration of 
function ‘idle’

This patch fixes it.

Signed-off-by: Lars-Peter Clausen 
---
 arch/blackfin/kernel/process.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
index 8061426..9782c03 100644
--- a/arch/blackfin/kernel/process.c
+++ b/arch/blackfin/kernel/process.c
@@ -80,12 +80,10 @@ void cpu_idle(void)
if (cpu_is_offline(smp_processor_id()))
cpu_die();
 #endif
-   if (!idle)
-   idle = default_idle;
tick_nohz_idle_enter();
rcu_idle_enter();
while (!need_resched())
-   idle();
+   default_idle();
rcu_idle_exit();
tick_nohz_idle_exit();
preempt_enable_no_resched();
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] blackfin idle: Fix compile error

[Lars-Peter Clausen]

Commit 26bab0c (blackfin idle: delete pm_idle) introduced the following
compile error:
arch/blackfin/kernel/process.c: In function ‘cpu_idle’:
arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use 
in this function)
arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier 
is reported only once
arch/blackfin/kernel/process.c:83: error: for each function it appears 
in.)
arch/blackfin/kernel/process.c:88: error: implicit declaration of 
function ‘idle’

This patch fixes it.

Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
 arch/blackfin/kernel/process.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
index 8061426..9782c03 100644
--- a/arch/blackfin/kernel/process.c
+++ b/arch/blackfin/kernel/process.c
@@ -80,12 +80,10 @@ void cpu_idle(void)
if (cpu_is_offline(smp_processor_id()))
cpu_die();
 #endif
-   if (!idle)
-   idle = default_idle;
tick_nohz_idle_enter();
rcu_idle_enter();
while (!need_resched())
-   idle();
+   default_idle();
rcu_idle_exit();
tick_nohz_idle_exit();
preempt_enable_no_resched();
-- 
1.8.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] blackfin idle: Fix compile error

[Rafael J. Wysocki]

On Thursday, February 21, 2013 10:56:43 AM Lars-Peter Clausen wrote:
 Commit 26bab0c (blackfin idle: delete pm_idle) introduced the following
 compile error:
   arch/blackfin/kernel/process.c: In function ‘cpu_idle’:
   arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use 
 in this function)
   arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier 
 is reported only once
   arch/blackfin/kernel/process.c:83: error: for each function it appears 
 in.)
   arch/blackfin/kernel/process.c:88: error: implicit declaration of 
 function ‘idle’
 
 This patch fixes it.
 
 Signed-off-by: Lars-Peter Clausen l...@metafoo.de

Applied to linux-pm.git/linux-next, I'm going to push it to Linus later this
week.

Thanks,
Rafael


 ---
  arch/blackfin/kernel/process.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
 
 diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
 index 8061426..9782c03 100644
 --- a/arch/blackfin/kernel/process.c
 +++ b/arch/blackfin/kernel/process.c
 @@ -80,12 +80,10 @@ void cpu_idle(void)
   if (cpu_is_offline(smp_processor_id()))
   cpu_die();
  #endif
 - if (!idle)
 - idle = default_idle;
   tick_nohz_idle_enter();
   rcu_idle_enter();
   while (!need_resched())
 - idle();
 + default_idle();
   rcu_idle_exit();
   tick_nohz_idle_exit();
   preempt_enable_no_resched();
 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/