Re: [PATCH] block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init

2020-11-30 Thread Jens Axboe 
On 11/29/20 7:20 PM, chenle...@gmail.com wrote:
> From: Lei Chen 
> 
> It's unnecessary to call wbt_update_limits explicitly within wbt_init,
> because it will be called in the following function wbt_queue_depth_changed.

Applied, thanks.

-- 
Jens Axboe

[PATCH] block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init

2020-11-29 Thread chenlei0x 
From: Lei Chen 

It's unnecessary to call wbt_update_limits explicitly within wbt_init,
because it will be called in the following function wbt_queue_depth_changed.

Signed-off-by: Lei Chen 
---
 block/blk-wbt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index fd41008..0321ca8 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -835,7 +835,6 @@ int wbt_init(struct request_queue *q)
rwb->enable_state = WBT_STATE_ON_DEFAULT;
rwb->wc = 1;
rwb->rq_depth.default_depth = RWB_DEF_DEPTH;
-   wbt_update_limits(rwb);
 
/*
 * Assign rwb and add the stats callback.
-- 
1.8.3.1