Re: [PATCH] can: rcar: Update help description for CAN_RCAR config
On 1/1/21 6:06 PM, Biju Das wrote: >> The rcar_can driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update >> the description to reflect this. > > Not sure we need to make it generic like dropping {1,2,3}/{1,2} and instead > use R-Car and RZ/G SoC's?? Sounds good. Better make the description more generic instead of updating it each time a new SoC comes along. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: OpenPGP digital signature
RE: [PATCH] can: rcar: Update help description for CAN_RCAR config
Hi Prabhakar, Thanks for the patch. > -Original Message- > From: Lad Prabhakar > Sent: 31 December 2020 16:00 > To: Geert Uytterhoeven ; Wolfgang Grandegger > ; Marc Kleine-Budde ; David S. > Miller ; Jakub Kicinski ; Masahiro > Yamada > Cc: linux-...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-renesas-...@vger.kernel.org; Prabhakar > ; Prabhakar Mahadev Lad lad...@bp.renesas.com> > Subject: [PATCH] can: rcar: Update help description for CAN_RCAR config > > The rcar_can driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update > the description to reflect this. Not sure we need to make it generic like dropping {1,2,3}/{1,2} and instead use R-Car and RZ/G SoC's?? Cheers, Biju > > Signed-off-by: Lad Prabhakar > --- > drivers/net/can/rcar/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/can/rcar/Kconfig b/drivers/net/can/rcar/Kconfig > index 8d36101b78e3..6bb0e7c052ad 100644 > --- a/drivers/net/can/rcar/Kconfig > +++ b/drivers/net/can/rcar/Kconfig > @@ -1,10 +1,10 @@ > # SPDX-License-Identifier: GPL-2.0 > config CAN_RCAR > - tristate "Renesas R-Car CAN controller" > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} CAN controller" > depends on ARCH_RENESAS || ARM > help > Say Y here if you want to use CAN controller found on Renesas R- > Car > - SoCs. > + Gen{1,2,3} and RZ/G{1,2} SoCs. > > To compile this driver as a module, choose M here: the module will > be called rcar_can. > -- > 2.17.1
[PATCH] can: rcar: Update help description for CAN_RCAR config
The rcar_can driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- drivers/net/can/rcar/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar/Kconfig b/drivers/net/can/rcar/Kconfig index 8d36101b78e3..6bb0e7c052ad 100644 --- a/drivers/net/can/rcar/Kconfig +++ b/drivers/net/can/rcar/Kconfig @@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 config CAN_RCAR - tristate "Renesas R-Car CAN controller" + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} CAN controller" depends on ARCH_RENESAS || ARM help Say Y here if you want to use CAN controller found on Renesas R-Car - SoCs. + Gen{1,2,3} and RZ/G{1,2} SoCs. To compile this driver as a module, choose M here: the module will be called rcar_can. -- 2.17.1