RE: [PATCH] clk: imx: pllv3: Fix fall through build warning
Quoting Anson Huang (2019-05-01 02:33:46) > Hi, Stephen > I saw Gustavo already sent out a patch to fix these two warnings, so > I will NOT sent the patch again, thanks. So I will apply that patch instead? Can you send your reviewed-by tag then?
RE: [PATCH] clk: imx: pllv3: Fix fall through build warning
Hi, Stephen I saw Gustavo already sent out a patch to fix these two warnings, so I will NOT sent the patch again, thanks. > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: Wednesday, May 1, 2019 2:17 AM > To: feste...@gmail.com; ker...@pengutronix.de; linux-arm- > ker...@lists.infradead.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; mturque...@baylibre.com; > s.ha...@pengutronix.de; shawn...@kernel.org; Anson Huang > ; Gustavo A. R. Silva > Cc: dl-linux-imx > Subject: Re: [PATCH] clk: imx: pllv3: Fix fall through build warning > > Quoting Anson Huang (2019-04-29 18:55:18) > > Fix below fall through build warning: > > > > drivers/clk/imx/clk-pllv3.c:453:21: warning: > > this statement may fall through [-Wimplicit-fallthrough=] > > > >pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > > ^ > > drivers/clk/imx/clk-pllv3.c:454:2: note: here > > case IMX_PLLV3_AV: > > ^~~~ > > > > Signed-off-by: Anson Huang > > --- > > Gustavo says there are two warnings. Please compile test with the right > options, add Reported-by tags when you get bug reports from someone, and > add a Fixes tag and then resend. > > > drivers/clk/imx/clk-pllv3.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > > index e892b9a..fbe4fe0 100644 > > --- a/drivers/clk/imx/clk-pllv3.c > > +++ b/drivers/clk/imx/clk-pllv3.c > > @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, > const char *name, > > case IMX_PLLV3_AV_IMX7: > > pll->num_offset = PLL_IMX7_NUM_OFFSET; > > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > > + /* fall through */ > > case IMX_PLLV3_AV: > > ops = &clk_pllv3_av_ops; > > break;
Re: [PATCH] clk: imx: pllv3: Fix fall through build warning
Quoting Anson Huang (2019-04-29 18:55:18) > Fix below fall through build warning: > > drivers/clk/imx/clk-pllv3.c:453:21: warning: > this statement may fall through [-Wimplicit-fallthrough=] > >pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > ^ > drivers/clk/imx/clk-pllv3.c:454:2: note: here > case IMX_PLLV3_AV: > ^~~~ > > Signed-off-by: Anson Huang > --- Gustavo says there are two warnings. Please compile test with the right options, add Reported-by tags when you get bug reports from someone, and add a Fixes tag and then resend. > drivers/clk/imx/clk-pllv3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > index e892b9a..fbe4fe0 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const > char *name, > case IMX_PLLV3_AV_IMX7: > pll->num_offset = PLL_IMX7_NUM_OFFSET; > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > + /* fall through */ > case IMX_PLLV3_AV: > ops = &clk_pllv3_av_ops; > break;
RE: [PATCH] clk: imx: pllv3: Fix fall through build warning
> From: Anson Huang > Sent: Tuesday, April 30, 2019 9:55 AM > Subject: [PATCH] clk: imx: pllv3: Fix fall through build warning > > Fix below fall through build warning: > > drivers/clk/imx/clk-pllv3.c:453:21: warning: > this statement may fall through [-Wimplicit-fallthrough=] > >pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > ^ > drivers/clk/imx/clk-pllv3.c:454:2: note: here > case IMX_PLLV3_AV: > ^~~~ > > Signed-off-by: Anson Huang Reviewed-by: Dong Aisheng Regards Dong Aisheng
[PATCH] clk: imx: pllv3: Fix fall through build warning
Fix below fall through build warning: drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=] pll->denom_offset = PLL_IMX7_DENOM_OFFSET; ^ drivers/clk/imx/clk-pllv3.c:454:2: note: here case IMX_PLLV3_AV: ^~~~ Signed-off-by: Anson Huang --- drivers/clk/imx/clk-pllv3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index e892b9a..fbe4fe0 100644 --- a/drivers/clk/imx/clk-pllv3.c +++ b/drivers/clk/imx/clk-pllv3.c @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name, case IMX_PLLV3_AV_IMX7: pll->num_offset = PLL_IMX7_NUM_OFFSET; pll->denom_offset = PLL_IMX7_DENOM_OFFSET; + /* fall through */ case IMX_PLLV3_AV: ops = &clk_pllv3_av_ops; break; -- 2.7.4