Re: [PATCH] clk: tegra: local arrays should be static
On Thursday 07 February 2013 10:00 PM, Peter De Schrijver wrote:
cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
clk-tegra30.c. Declare them static to avoid namespace polution.
Signed-off-by: Peter De Schrijver
Reviewed-by: Prashant Gaikwad
---
drivers/clk/tegra/clk-tegra30.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index a163812..d169ef0 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
}
-const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
-"pll_p_cclkg", "pll_p_out4_cclkg",
-"pll_p_out3_cclkg", "unused", "pll_x" };
-const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
- "pll_p_cclklp", "pll_p_out4_cclklp",
- "pll_p_out3_cclklp", "unused", "pll_x",
- "pll_x_out0" };
-const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
- "pll_p_out3", "pll_p_out2", "unused",
- "clk_32k", "pll_m_out1" };
+static const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
+ "pll_p_cclkg", "pll_p_out4_cclkg",
+ "pll_p_out3_cclkg", "unused", "pll_x" };
+static const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
+"pll_p_cclklp", "pll_p_out4_cclklp",
+"pll_p_out3_cclklp", "unused", "pll_x",
+"pll_x_out0" };
+static const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
+ "pll_p_out3", "pll_p_out2", "unused",
+ "clk_32k", "pll_m_out1" };
static void __init tegra30_super_clk_init(void)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] clk: tegra: local arrays should be static
On 02/07/2013 10:49 AM, Mike Turquette wrote: > Quoting Peter De Schrijver (2013-02-07 08:30:36) >> cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from >> within >> clk-tegra30.c. Declare them static to avoid namespace polution. >> >> Signed-off-by: Peter De Schrijver > > Acked-by: Mike Turquette I've applied this to Tegra's for-3.9/soc-ccf-fixes branch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] clk: tegra: local arrays should be static
Quoting Peter De Schrijver (2013-02-07 08:30:36) > cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within > clk-tegra30.c. Declare them static to avoid namespace polution. > > Signed-off-by: Peter De Schrijver Acked-by: Mike Turquette -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] clk: tegra: local arrays should be static
cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
clk-tegra30.c. Declare them static to avoid namespace polution.
Signed-off-by: Peter De Schrijver
---
drivers/clk/tegra/clk-tegra30.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index a163812..d169ef0 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
}
-const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
-"pll_p_cclkg", "pll_p_out4_cclkg",
-"pll_p_out3_cclkg", "unused", "pll_x" };
-const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
- "pll_p_cclklp", "pll_p_out4_cclklp",
- "pll_p_out3_cclklp", "unused", "pll_x",
- "pll_x_out0" };
-const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
- "pll_p_out3", "pll_p_out2", "unused",
- "clk_32k", "pll_m_out1" };
+static const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
+ "pll_p_cclkg", "pll_p_out4_cclkg",
+ "pll_p_out3_cclkg", "unused", "pll_x" };
+static const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
+"pll_p_cclklp", "pll_p_out4_cclklp",
+"pll_p_out3_cclklp", "unused", "pll_x",
+"pll_x_out0" };
+static const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
+ "pll_p_out3", "pll_p_out2", "unused",
+ "clk_32k", "pll_m_out1" };
static void __init tegra30_super_clk_init(void)
{
--
1.7.7.rc0.72.g4b5ea.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] clk: tegra: local arrays should be static
On 02/07/2013 10:49 AM, Mike Turquette wrote: Quoting Peter De Schrijver (2013-02-07 08:30:36) cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within clk-tegra30.c. Declare them static to avoid namespace polution. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com Acked-by: Mike Turquette mturque...@linaro.org I've applied this to Tegra's for-3.9/soc-ccf-fixes branch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] clk: tegra: local arrays should be static
On Thursday 07 February 2013 10:00 PM, Peter De Schrijver wrote:
cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
clk-tegra30.c. Declare them static to avoid namespace polution.
Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com
Reviewed-by: Prashant Gaikwad pgaik...@nvidia.com
---
drivers/clk/tegra/clk-tegra30.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index a163812..d169ef0 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
}
-const char *cclk_g_parents[] = { clk_m, pll_c, clk_32k, pll_m,
-pll_p_cclkg, pll_p_out4_cclkg,
-pll_p_out3_cclkg, unused, pll_x };
-const char *cclk_lp_parents[] = { clk_m, pll_c, clk_32k, pll_m,
- pll_p_cclklp, pll_p_out4_cclklp,
- pll_p_out3_cclklp, unused, pll_x,
- pll_x_out0 };
-const char *sclk_parents[] = { clk_m, pll_c_out1, pll_p_out4,
- pll_p_out3, pll_p_out2, unused,
- clk_32k, pll_m_out1 };
+static const char *cclk_g_parents[] = { clk_m, pll_c, clk_32k, pll_m,
+ pll_p_cclkg, pll_p_out4_cclkg,
+ pll_p_out3_cclkg, unused, pll_x };
+static const char *cclk_lp_parents[] = { clk_m, pll_c, clk_32k, pll_m,
+pll_p_cclklp, pll_p_out4_cclklp,
+pll_p_out3_cclklp, unused, pll_x,
+pll_x_out0 };
+static const char *sclk_parents[] = { clk_m, pll_c_out1, pll_p_out4,
+ pll_p_out3, pll_p_out2, unused,
+ clk_32k, pll_m_out1 };
static void __init tegra30_super_clk_init(void)
{
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] clk: tegra: local arrays should be static
cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
clk-tegra30.c. Declare them static to avoid namespace polution.
Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com
---
drivers/clk/tegra/clk-tegra30.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index a163812..d169ef0 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
}
-const char *cclk_g_parents[] = { clk_m, pll_c, clk_32k, pll_m,
-pll_p_cclkg, pll_p_out4_cclkg,
-pll_p_out3_cclkg, unused, pll_x };
-const char *cclk_lp_parents[] = { clk_m, pll_c, clk_32k, pll_m,
- pll_p_cclklp, pll_p_out4_cclklp,
- pll_p_out3_cclklp, unused, pll_x,
- pll_x_out0 };
-const char *sclk_parents[] = { clk_m, pll_c_out1, pll_p_out4,
- pll_p_out3, pll_p_out2, unused,
- clk_32k, pll_m_out1 };
+static const char *cclk_g_parents[] = { clk_m, pll_c, clk_32k, pll_m,
+ pll_p_cclkg, pll_p_out4_cclkg,
+ pll_p_out3_cclkg, unused, pll_x };
+static const char *cclk_lp_parents[] = { clk_m, pll_c, clk_32k, pll_m,
+pll_p_cclklp, pll_p_out4_cclklp,
+pll_p_out3_cclklp, unused, pll_x,
+pll_x_out0 };
+static const char *sclk_parents[] = { clk_m, pll_c_out1, pll_p_out4,
+ pll_p_out3, pll_p_out2, unused,
+ clk_32k, pll_m_out1 };
static void __init tegra30_super_clk_init(void)
{
--
1.7.7.rc0.72.g4b5ea.dirty
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] clk: tegra: local arrays should be static
Quoting Peter De Schrijver (2013-02-07 08:30:36) cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within clk-tegra30.c. Declare them static to avoid namespace polution. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com Acked-by: Mike Turquette mturque...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
