Re: [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call

2019-10-02 Thread Peter Ujfalusi



On 26/09/2019 13.45, Peter Ujfalusi wrote:
> ti_clk_register() calls it already so the driver should not create
> duplicated alias.

This patch will leave 'ret' as unused in of_dra7_atl_clock_setup(), I'll
send v2 in a minute or so.

> Signed-off-by: Peter Ujfalusi 
> ---
>  drivers/clk/ti/clk-dra7-atl.c | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index a01ca9395179..c0e0ee974151 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -207,11 +207,6 @@ static void __init of_dra7_atl_clock_setup(struct 
> device_node *node)
>   clk = ti_clk_register(NULL, _hw->hw, node->name);
>  
>   if (!IS_ERR(clk)) {
> - ret = ti_clk_add_alias(NULL, clk, node->name);
> - if (ret) {
> - clk_unregister(clk);
> - goto cleanup;
> - }
>   of_clk_add_provider(node, of_clk_src_simple_get, clk);
>   kfree(parent_names);
>   return;
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


[PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call

2019-09-26 Thread Peter Ujfalusi
ti_clk_register() calls it already so the driver should not create
duplicated alias.

Signed-off-by: Peter Ujfalusi 
---
 drivers/clk/ti/clk-dra7-atl.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index a01ca9395179..c0e0ee974151 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -207,11 +207,6 @@ static void __init of_dra7_atl_clock_setup(struct 
device_node *node)
clk = ti_clk_register(NULL, _hw->hw, node->name);
 
if (!IS_ERR(clk)) {
-   ret = ti_clk_add_alias(NULL, clk, node->name);
-   if (ret) {
-   clk_unregister(clk);
-   goto cleanup;
-   }
of_clk_add_provider(node, of_clk_src_simple_get, clk);
kfree(parent_names);
return;
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki